From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 0CC0D1F5 for ; Mon, 22 May 2017 17:18:58 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2017 08:18:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,377,1491289200"; d="scan'208";a="105148193" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.221.20]) ([10.237.221.20]) by fmsmga005.fm.intel.com with ESMTP; 22 May 2017 08:18:56 -0700 To: Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org References: <1495023908-10977-1-git-send-email-arybchenko@solarflare.com> <1495116004-11761-1-git-send-email-arybchenko@solarflare.com> <1495116004-11761-3-git-send-email-arybchenko@solarflare.com> <45b5b0a6-a5be-88d7-734f-c2b1dd1b31be@intel.com> <4e8bdd9d-e26d-0cb6-9e0f-68df9f42c5d3@intel.com> From: Sergio Gonzalez Monroy Message-ID: <0a3f7884-9794-a119-1595-d9ed2318b855@intel.com> Date: Mon, 22 May 2017 16:18:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <4e8bdd9d-e26d-0cb6-9e0f-68df9f42c5d3@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/sfc: support multi-process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 May 2017 15:18:59 -0000 On 22/05/2017 13:36, Ferruh Yigit wrote: > On 5/22/2017 1:07 PM, Andrew Rybchenko wrote: >> On 05/22/2017 02:29 PM, Ferruh Yigit wrote: >>> On 5/18/2017 3:00 PM, Andrew Rybchenko wrote: >>>> Signed-off-by: Andrew Rybchenko >>>> Reviewed-by: Andy Moreton >>> <...> >>> >>>> Linux VFIO = Y >>>> diff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h >>>> index 772a713..007ed24 100644 >>>> --- a/drivers/net/sfc/sfc.h >>>> +++ b/drivers/net/sfc/sfc.h >>>> @@ -225,7 +225,18 @@ struct sfc_adapter { >>>> uint8_t rss_key[SFC_RSS_KEY_SIZE]; >>>> #endif >>>> >>>> + /* >>>> + * Shared memory copy of the Rx datapath name to be used by >>>> + * the secondary process to find Rx datapath to be used. >>>> + */ >>>> + char *dp_rx_name; >>> Why not use sa->dp_rx->dp.name to find the dp_rx? That variable should >>> be shared between processes already? >> sa->dp_rx is a pointer to .data section (sfc_efx_rx or sfc_ef10_rx) >> which is (may be) different in primary and secondary processes. > OK, thanks. > Does it make sense to implement strdup as rte_strdup, so others can > re-use it? @sergio, what do you think? IMHO I would hold until there are more cases using it. Sergio