From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C23CA2EEB for ; Fri, 13 Sep 2019 23:04:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 089FE1F054; Fri, 13 Sep 2019 23:04:24 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id B145D1F040 for ; Fri, 13 Sep 2019 23:04:22 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 8E5A59C005B; Fri, 13 Sep 2019 21:04:20 +0000 (UTC) Received: from [192.168.1.192] (188.242.181.57) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 13 Sep 2019 22:04:15 +0100 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= CC: , Ivan Ilchenko References: <1568031190-16510-1-git-send-email-arybchenko@solarflare.com> <1568031190-16510-3-git-send-email-arybchenko@solarflare.com> <20190909125656.fxkbfvxja2z62bzv@bidouze.vm.6wind.com> From: Andrew Rybchenko Message-ID: <0a44761a-1fc9-f332-fb6f-4409b7d4beee@solarflare.com> Date: Sat, 14 Sep 2019 00:04:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190909125656.fxkbfvxja2z62bzv@bidouze.vm.6wind.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [188.242.181.57] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24908.002 X-TM-AS-Result: No-1.655400-8.000000-10 X-TMASE-MatchedRID: nVQUmLJJeya8rRvefcjeTQR6aubfrqNo69aS+7/zbj+qvcIF1TcLYHXX vhBypR7Z4GLMXNDnp2oipMzE+/uKKKX7JaGNhSXtnMQdNQ64xffLvfc3C6SWwmAMM0WKD4as1Is 5GvhmGbwcU3zG2Kw5DLzk08DcGe6U9TvmjmodoCktvPXhZLGnkX0tCKdnhB58ZYJ9vPJ1vSDefx 4FmMaZTOTCMddcL/gjxlblqLlYqXJS40xVmyf4sFtH2/b9D5wjAY4olp7FBiRs97o+oVcnplLq6 sO7aRjNoQgpnZd6P+3REEd1Fut1N9KDITN6vGksP3xkK2TogBaFcgJc+QNMwu8bJovJYm8FYupx 0XjSQPLDOFVmKqGJ4WptqaeO5a/g X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--1.655400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24908.002 X-MDID: 1568408661-bQ0Ikh12Vyn3 Subject: Re: [dpdk-dev] [PATCH 2/7] net/failsafe: check code of allmulticast mode switch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/9/19 3:56 PM, Gaëtan Rivet wrote: > On Mon, Sep 09, 2019 at 01:13:04PM +0100, Andrew Rybchenko wrote: >> From: Ivan Ilchenko >> >> rte_eth_allmulticast_enable()/rte_eth_allmulticast_disable() return >> value was changed from void to int, so this patch modify usage >> of these functions across net/failsafe according to new return type. >> >> Try to keep all-multicast mode consistent across all active >> devices in the case of failure. >> >> Signed-off-by: Ivan Ilchenko >> Signed-off-by: Andrew Rybchenko > A small nit below, but otherwise > Acked-by: Gaetan Rivet Thanks, will fix it in the next version and similar changes in promiscuous mode patches (to have no identical logs).