From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 75CB437B1 for ; Mon, 19 Sep 2016 19:04:24 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 19 Sep 2016 10:04:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,362,1470726000"; d="scan'208";a="763369123" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.115]) ([10.237.220.115]) by FMSMGA003.fm.intel.com with ESMTP; 19 Sep 2016 10:04:22 -0700 From: Ferruh Yigit To: Xiao Wang , wenzhuo.lu@intel.com References: <1472312902-16963-1-git-send-email-xiao.w.wang@intel.com> <1472312902-16963-18-git-send-email-xiao.w.wang@intel.com> Cc: dev@dpdk.org Message-ID: <0a4cbb05-a03a-0666-7c22-8d61616d15d4@intel.com> Date: Mon, 19 Sep 2016 18:04:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1472312902-16963-18-git-send-email-xiao.w.wang@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 17/39] net/ixgbe/base: access IOSF by host interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2016 17:04:25 -0000 On 8/27/2016 4:48 PM, Xiao Wang wrote: > This patch makes sure that we access IOSF registers through the HIC > (host interface command) for the majority of X550em devices. All devices > with NVM are capable of using the HIC. > > For consistency all instances where the ixgbe_read/write_iosf_sb_reg_x550 > is called directly are converted to function pointer calls. > > Signed-off-by: Xiao Wang > --- > drivers/net/ixgbe/base/ixgbe_phy.c | 2 +- > drivers/net/ixgbe/base/ixgbe_x550.c | 38 ++++++++++++++++++++++--------------- > 2 files changed, 24 insertions(+), 16 deletions(-) > > diff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c > index d33d0f8..ee8618f 100644 > --- a/drivers/net/ixgbe/base/ixgbe_phy.c > +++ b/drivers/net/ixgbe/base/ixgbe_phy.c > @@ -741,7 +741,7 @@ s32 ixgbe_write_phy_reg_generic(struct ixgbe_hw *hw, u32 reg_addr, > DEBUGFUNC("ixgbe_write_phy_reg_generic"); > > if (hw->mac.ops.acquire_swfw_sync(hw, gssr) == IXGBE_SUCCESS) { > - status = ixgbe_write_phy_reg_mdi(hw, reg_addr, device_type, > + status = hw->phy.ops.write_reg_mdi(hw, reg_addr, device_type, > phy_data); Is this IOSF register? ... > @@ -4504,7 +4512,7 @@ s32 ixgbe_write_phy_reg_x550a(struct ixgbe_hw *hw, u32 reg_addr, > DEBUGFUNC("ixgbe_write_phy_reg_x550a"); > > if (hw->mac.ops.acquire_swfw_sync(hw, mask) == IXGBE_SUCCESS) { > - status = ixgbe_write_phy_reg_mdi(hw, reg_addr, device_type, > + status = hw->phy.ops.write_reg_mdi(hw, reg_addr, device_type, same question? > phy_data); > hw->mac.ops.release_swfw_sync(hw, mask); > } else { >