From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EDA89436FD; Fri, 15 Dec 2023 13:54:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ACCFC4326E; Fri, 15 Dec 2023 13:54:36 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2068.outbound.protection.outlook.com [40.107.94.68]) by mails.dpdk.org (Postfix) with ESMTP id CB31840299; Fri, 15 Dec 2023 13:54:34 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LYXCNp5PELdiHriKCiA4B+UWp/UQx774vWj6uDnjI0yTH1fhDfS3LxxAjhPfJBCl1tvUECBoVB+KlZKnyFmRsYhRegHBpoj7ekHi0yvkuVjiRQYqwmdJp//AL68ylfgRehDiTMQKPkkxiGuZjQOC+cq3HAumUhug1q9TooPS2/BbBiuBIFT67a7VcVl8g5QfdjJGi7J8Ekr8lzfL79m7r58PtXu9brlz3jrua2Wt7bW/zHEVnu2BTFONjCs9dNiiWZNUOp7HmZ4ANU+mSDlcghy6ruuxHexG03b3TeDs1ny4g+DyO1JLQ2hIGe3CdWa0fK+a/Y893BSOAHMeUE/Z5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7pWgI/hUkj87xnTED5wam5fH9twpNqzhtAAZUD2+44A=; b=oYkXXrzjWudR+wgdwSbOZ9ojUTv/oGSAW83KCkEJ1UsIRS+ThabajSSDzUi+ak/UgC9Y7I+2HKWZP+l/Z+U6vh7E5ae5eCmpVjM57QYlSw9UGZtqbEWJYwPKbvi0bLmO4fupgVz6pf49wV5bgl/CqEiv5FHQy9pnPF3IGoYCV6/lqNGGzw9MgzrUZzUoCii6nsKycqi7OvVBXBecmfbfUVwtt5yokascSeclWQw//L4Zi73qRB8MUKvlj0nu6nY5evmn+Vq5J82TfWegY52H30E8MJDG2Z1z/Tgz2Ir6MNcdC7Iw+mVEnFJpuOp/WYPny71483NnUBv0+xY6/0Kzog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7pWgI/hUkj87xnTED5wam5fH9twpNqzhtAAZUD2+44A=; b=eSOyhOr0KX/o3DHoCj4bcWet6B+UYRanv03mgiEb+J/V/EvVjIw7HwOtOdsoHffRldXbWVfTFJ6dXQEwLszQ1TIt0m+2YLSJ1mF94YO7goTERjWowQfZw9FNHO2VK5kZ7+zbpSAbjBZOF5+iAe70Xh4SE3V9ZrjFEOhcQZpu8z0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB4041.namprd12.prod.outlook.com (2603:10b6:5:210::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28; Fri, 15 Dec 2023 12:54:32 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7091.030; Fri, 15 Dec 2023 12:54:32 +0000 Message-ID: <0a5a69d7-2d2e-4a0e-9d29-18ec856b5be2@amd.com> Date: Fri, 15 Dec 2023 12:54:24 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] net/nfp: fix free resource problem Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu , stable@dpdk.org, Peng Zhang References: <20231214102431.2091608-1-chaoyong.he@corigine.com> <20231214102431.2091608-3-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231214102431.2091608-3-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0102.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4041:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d71b6f4-bbdf-4017-23b9-08dbfd6cfb12 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 72vDBkInLGMFmQwPsibns0OfB3Mdrd+BYKrsRRQPs+NGmjB0sFKaDqB9U2xgCf2Ne7odJCLNzjKKVLCRY/MNMnXDoV7JNOc5HTSmp+MS1XxTx7Nxg0aroIe2P/0wNMqjYEZxl4G6Btw2w91+JvQO7DDgxBMUZJyIW6uerr62P4mn5oy5ONXQw4nZ3Ya3ow0Xdu3gB4z29BtbxUP4Mt86ZpISYJTPlA4exVs1EcLnapyyeoqMrC6KlZ513+I3TedtfqcO6nXpvQ4z92HEK94FS1c8QG2kuaqEk5qR+cc5ZUi4chp+MxuHvOPStZE6IRBe1EmBEN6/RRm10fMeptviFICFYq8iu53WLgmMCxnUenENKhIzLzooDeCfFG7BwMwiJbf6NgLmlhk7mLfeSCmAwJbCI+YGxZNFv7PHUrGzGrte3zyXOk3YWR7ASceKULzDfoZPz7IxTPTt8H34tJ/4JtDNW0HKgikGeqlxNY9YMYTtKU/Z1wB+khwHjbOBgxQ5EQc5gaA7Fp318PPvfGfXHcdkP6gEEzbXLF+vuxa4aTzz/QGS9aecX0nakwo8CCmWrknHCWyHc90ghfZiyjW19MB2LXRddWqcggFoIxY54AbKyaCtevjhtWAyHr9Ie1WuvTZjoWlmvncCCTEKD1KohQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(366004)(136003)(39860400002)(396003)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(2616005)(26005)(6506007)(6666004)(6512007)(53546011)(83380400001)(6486002)(41300700001)(5660300002)(44832011)(8936002)(8676002)(2906002)(478600001)(66946007)(66476007)(66556008)(4326008)(316002)(54906003)(86362001)(31696002)(38100700002)(36756003)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1pMNEVkMnMzOEN6ckJQMzY0SWFJRUU5cGtUaE1MTjJ2RlJXT3FBcEVhTU5k?= =?utf-8?B?L0o3WVBiOW5TU3pvRGJwRW1hVVkyV0hacEtlRVVrYk95aVo5UWUxYnNJTnVK?= =?utf-8?B?QVplU2lGMnByaFYveDhEYjF3bWxEOWF6L01TbUFtOGc0dlJxZFdQL0NVelg3?= =?utf-8?B?Sy9RdmdKVUg2NEFRZVZiSmRGL2kyMHQ2VHlCeEJqVXVBY29ZdUU1WnJDN1By?= =?utf-8?B?ZlB4Ym1jUlRsSkg2TS9odmNvcDNtempXMlJlUmprbDZpRHp1bU1iN3E0bmUy?= =?utf-8?B?M0hVR1ZuZGVUMlF5WGpJM0hndmJ3RE5CUVFGd1R6NDFZSHVubHA5ZXg1b09y?= =?utf-8?B?a3NCcFp3eXA5WkVpUFMyVGJiMFhFTHI2WG5iVGdSVVUxYXVabWVzRzRzdWVN?= =?utf-8?B?aC9JTXpUMjdDY21nY25yWFpvckVmZDFwa0NkcGdhTFplSDhCWUl1MmNGUFVU?= =?utf-8?B?dnBIQlB6OHcwdkp0bStNMTlsRlVSTXBQUk45MHpCS2lnY2h3MStabzdhb1po?= =?utf-8?B?RTRhTEdad3ZJWGVIT0VjN0RlaGxUc2Q5VGdUR2kySndQNm94bTV0Z0tuMGtU?= =?utf-8?B?RDZTSmxLSVBhRDRFb0RkRzdYYzllQWp3WUw2VkFzd2ZzSFpyUEhWZ3dlNkFo?= =?utf-8?B?Qk5PSWFvNDFRcWRXcERuTkZHNExWVnlzaWdDKzByelRib2pQaktFTEhrNWdw?= =?utf-8?B?ZEpJcHE4T0hTcjNyNDJsdkRFbndRZlRuWFlpTXJnczBmQ2poTnVvS0tTMm02?= =?utf-8?B?QndES0tUdi9WZ3NSRGMxWTJXanBVdUNZcWI0eTRUVDZycTVtR1RPNTVYcnQ4?= =?utf-8?B?d1lpWUsvSHl1eGZkMmkvOGozTkpTRUdYcVQxSHBzWWRRRUFIMVE2RzhWOThw?= =?utf-8?B?N2tudjZZVURSRzlNV002emhMbXVsN2k4YXM5eUVtamIyWFBoZVorMzl0SXpy?= =?utf-8?B?WnRqU0hhbXB4R3ZJSTVtVkdjaHJYdU5SajNtb0lQR3daL0ZCeHZjR0RiWTBr?= =?utf-8?B?N1UzV0JsdDZsTHFnUEdwQmxBcm16VUFlWTloZGJXa2FFckRaUXhIT2ZXWm1k?= =?utf-8?B?U0N6Sm42NDlwUWpFdTVDSmMybzNuZ2Z3RVc5VmV4c0FMbThqUWY3R3J4emRQ?= =?utf-8?B?azRUTnlMY1IxMzB5U1phSGQ3S04xa2wvaFZvYXBJY1M5MUxiOTJqaEJ4RUNQ?= =?utf-8?B?OStyQ2ZyM3FDVjUrb3E2RFlJWG1GazdsUjhPT0E1dkczVzBvYnNWSFh6Umg4?= =?utf-8?B?a1RFNzdxWDMvQVBRaHNGeWIzQkVSbkNEQlJOc0wwbzQ4WS92cW4wa0Y4T09V?= =?utf-8?B?K1ZuTmhLVGJ1VWpleFo0VkJkRkw0S3h2TStQaVpyay81T3g5Z2pBS3oxVUhS?= =?utf-8?B?cU1IMnR4dnB4bWYvNHkwL0pDU0R3bkNHRlI1SytvMGw2Y2hncnJyUys1NU82?= =?utf-8?B?S1pkaDRwMFlMYjdKOVlxUkRRL0ZFUlRyVGU2bFY5ekRvcytGZ3VGZnBodmVF?= =?utf-8?B?cDRTUDJ4dit1RHpoRWIvT1A3elZobVl5M0FWUmtuaHRZcEhPd3VRVHlQZ1dO?= =?utf-8?B?NHJlWC94ZjE2RHE1dGtFYm91aVV4Y0puZ0JrSmRZOTJXd0tYRlByWDZsM2FV?= =?utf-8?B?Vk44R1o1c0R1OWdpOEV6Yk9XZ09iR2xzYW1kNjdJQm5zYkgwMlMxN3RDZExJ?= =?utf-8?B?OXplcGMvQnJnZEwrOENucVpYSS9QeWliYTBYQjMrdXlEcTZwSXR0bEdMZWNs?= =?utf-8?B?eDc0QWNaTit4ZTB0QUpqa2VOazNSTTNVckV4VG9WS3lubGZiN3praTVMU2hs?= =?utf-8?B?TnFMbHJsZCtlcHZ0VzVjaytqL2dNakYrZ215Skd1WTA4L056dm5zM3dFVzFJ?= =?utf-8?B?Lzc0YVRSekp4T1FFZEhha1dDVEVIci9qcm9IcjFKdCtZNzdId0tKN0N4c0I2?= =?utf-8?B?cVJRYko1UEJ1NkNIZWx6bTlWcWQydHg5RU0wajhOa3hjdUhKUTNrd2RpRzBJ?= =?utf-8?B?dENaQ3BHMFU0OXFqNjZ2cXBEV0Q3YkNDSzdEWHBRZmJYNXVTVkFpZVpSZGxQ?= =?utf-8?B?dVoyK01odlhoNXdNN2lvT0VmTGhwelpBY0dqYkNxVlJDc29Ka0ZGNldYM2xK?= =?utf-8?Q?bVzQ=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d71b6f4-bbdf-4017-23b9-08dbfd6cfb12 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2023 12:54:31.8491 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lchgvpSakpWDFuIgaayer5Tmt81i+sg+cn/DEGU7QnfayMI/N2/PM9CW9sH955nb X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4041 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/14/2023 10:24 AM, Chaoyong He wrote: > From: Long Wu > > Set the representor array to NULL to avoid that close interface > does not free some resource. > > Fixes: a135bc1644d6 ("net/nfp: fix resource leak for flower firmware") > Cc: chaoyong.he@corigine.com > Cc: stable@dpdk.org > > Signed-off-by: Long Wu > Reviewed-by: Chaoyong He > Reviewed-by: Peng Zhang > --- > drivers/net/nfp/flower/nfp_flower_representor.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c > index 27ea3891bd..5f7c1fa737 100644 > --- a/drivers/net/nfp/flower/nfp_flower_representor.c > +++ b/drivers/net/nfp/flower/nfp_flower_representor.c > @@ -294,17 +294,30 @@ nfp_flower_repr_tx_burst(void *tx_queue, > static int > nfp_flower_repr_uninit(struct rte_eth_dev *eth_dev) > { > + uint16_t index; > struct nfp_flower_representor *repr; > > repr = eth_dev->data->dev_private; > rte_ring_free(repr->ring); > > + if (repr->repr_type == NFP_REPR_TYPE_PHYS_PORT) { > + index = NFP_FLOWER_CMSG_PORT_PHYS_PORT_NUM(repr->port_id); > + repr->app_fw_flower->phy_reprs[index] = NULL; > + } else { > + index = repr->vf_id; > + repr->app_fw_flower->vf_reprs[index] = NULL; > + } > + > return 0; > } > > static int > -nfp_flower_pf_repr_uninit(__rte_unused struct rte_eth_dev *eth_dev) > +nfp_flower_pf_repr_uninit(struct rte_eth_dev *eth_dev) > { > + struct nfp_flower_representor *repr = eth_dev->data->dev_private; > + > + repr->app_fw_flower->pf_repr = NULL; > Here it is assigned to NULL but is it freed? If freed, why not set to NULL where it is freed? Same for above phy_reprs & vf_reprs.