From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73E39A034F; Mon, 22 Mar 2021 18:24:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A46040040; Mon, 22 Mar 2021 18:24:15 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id DF8694003D for ; Mon, 22 Mar 2021 18:24:13 +0100 (CET) IronPort-SDR: fM3CsXeaaBhWYCKqqoiV4LuTrn/tXuQtWNzmi+R4hHN2zfiRAVjU/oqnMzj6RV2T5tmHEdSmWO huLWYe2BugQw== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="177446582" X-IronPort-AV: E=Sophos;i="5.81,269,1610438400"; d="scan'208";a="177446582" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 10:24:11 -0700 IronPort-SDR: 1o+FQIPqDQGL65VCXpgKxvxetvxrkCz2XDGxdRwlP7Z+tS7atlPMrii3WRWiutNCjzGydH6ErH LgiOhTkZl3oA== X-IronPort-AV: E=Sophos;i="5.81,269,1610438400"; d="scan'208";a="407918655" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.14.44]) ([10.252.14.44]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 10:24:09 -0700 From: Ferruh Yigit To: Thomas Monjalon , Qi Zhang , Andrew Rybchenko Cc: dev@dpdk.org, xiao.w.wang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, jia.guo@intel.com, qiming.yang@intel.com, haiyue.wang@intel.com, bruce.richardson@intel.com References: <20210310121626.2019863-1-qi.z.zhang@intel.com> <20210312121223.2028029-2-qi.z.zhang@intel.com> <93fd4fce-a961-8ccf-fd32-0386461e4e99@intel.com> <8879674.o8TafV64eK@thomas> <5a7ee4c7-8027-93bd-2e3f-4073e2769018@intel.com> X-User: ferruhy Message-ID: <0a7e9289-49ae-554d-1a34-28cf036520fc@intel.com> Date: Mon, 22 Mar 2021 17:24:05 +0000 MIME-Version: 1.0 In-Reply-To: <5a7ee4c7-8027-93bd-2e3f-4073e2769018@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/8] ether: refine debug compile option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/16/2021 4:37 PM, Ferruh Yigit wrote: > On 3/16/2021 1:39 PM, Thomas Monjalon wrote: >> 16/03/2021 14:05, Ferruh Yigit: >>> On 3/12/2021 12:12 PM, Qi Zhang wrote: >>>> PMDs use RTE_LIBRTE__DEBUG_RX|TX as compile option to wrap >>>> data path debug code. As .config has been removed since the meson build, >>>> It is not friendly for new DPDK users to notice those debug options. >>>> >>>> The patch introduces below compile options for specific Rx/Tx data path >>>> debug, so PMD can choose to reuse them to avoid maintain their own. >>>> >>>> - RTE_LIBRTE_ETHDEV_DEBUG_RX >>>> - RTE_LIBRTE_ETHDEV_DEBUG_TX >>>> >>>> Also, all the compile options are documented on the overview page, so >>>> users can easily find them. > > <...> > >>>> + >>>> +- ``RTE_LIBRTE_ETHDEV_DEBUG`` (default **disabled**) >>>> + >>>> +  Compile with debug code on data path. >> >> What is data path if not Rx or Tx? >> >>>> + >>>> +- ``RTE_LIBRTE_ETHDEV_DEBUG_RX`` (default **disabled**) >>>> + >>>> +  Compile with debug code on Rx data path. >>>> + >>>> +- ``RTE_LIBRTE_ETHDEV_DEBUG_TX`` (default **disabled**) >>>> + >>>> +  Compile with debug code on Tx data path. >> >> In general, I think "LIBRTE_" is redundant and useless as macro prefix. >> > > > 'RTE_LIBRTE_ETHDEV_DEBUG' already exits, it enables datapath debug without > distinguishing Rx or Tx. > > When we have _RX and _TX macro variants now, it may be possible to > 1- get rid of 'RTE_LIBRTE_ETHDEV_DEBUG' macro and continue with fine grained RX > & TX > 2- Use 'RTE_LIBRTE_ETHDEV_DEBUG' as an alias to enable both RX & TX > 3- Keep 'RTE_LIBRTE_ETHDEV_DEBUG' for ethdev layer datapath debug, and RX & TX > variants for PMDs. > > I think (3) can be more backward compatible, and can be helpful to separate > ethdev layer and PMD debugging, but no so strong opinion. Hi Qi, Reminder of above discussion, it is not addressed in v4. What do you think option 3 above?