From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EE62845BD2;
	Fri, 25 Oct 2024 09:43:49 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BA2A540264;
	Fri, 25 Oct 2024 09:43:49 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id EE68B400D5
 for <dev@dpdk.org>; Fri, 25 Oct 2024 09:43:47 +0200 (CEST)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru D82E65D
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1729842227;
 bh=AuZTAWV9Uf8nFmy7oeTXjETXJ4v4xXArVsiwsAzjNf8=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=ZY+nsLbnHyI1XpXkmZR2VUnFrtpS/2W6nIkjxtHr9sx1Khj+4VhWlNUXPfOag9B4C
 Ik3laFKkZdcUVu0Tkt9uPX+aDmO10mL0BKVIx76lcG2bd1uxRcAf6KxUHCWxe/ecYs
 ucfsKlOIv81fNh2wFG7Cv6E/CRSP8AsgwCgORfAU=
Received: from [192.168.1.38] (unknown [188.170.81.56])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id D82E65D;
 Fri, 25 Oct 2024 10:43:46 +0300 (MSK)
Message-ID: <0a9648e6-5784-4e74-a1f7-614aff0ce8b7@oktetlabs.ru>
Date: Fri, 25 Oct 2024 10:43:45 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC v2] ethdev: an API for cache stashing hints
To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <hofors@lysator.liu.se>,
 Wathsala Vithanage <wathsala.vithanage@arm.com>, dev@dpdk.org,
 Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@amd.com>
Cc: nd@arm.com, Dhruv Tripathi <dhruv.tripathi@arm.com>
References: <20240715221141.16153-1-wathsala.vithanage@arm.com>
 <f95e2d97-c312-4a0d-9182-2cce5d57a4a6@lysator.liu.se>
Content-Language: en-US
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <f95e2d97-c312-4a0d-9182-2cce5d57a4a6@lysator.liu.se>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 10/23/24 20:59, Mattias Rönnblom wrote:
> On 2024-07-16 00:11, Wathsala Vithanage wrote:

...

>> +/**
>> + *
>> + * @warning
>> + * @b EXPERIMENTAL: this API may change, or be removed, without prior 
>> notice
>> + *
>> + * Discover cache stashing hints and object types supported in the 
>> ethernet
>> + * device.
>> + *
> 
> Why is this needed?
> 
> It seems to me the application should just give hints what it thinks is 
> best, and then the PMD should do the best it can with that information.

+1, I think it is a very good idea

> 
> No validating, no discovering.
> 
> Now you have a lot of API verbiage for a fairly esoteric function.
> 
> Just to be clear: I think an API like this is a great idea. Controlling 
> how the NIC and other devices loads and stores data can be crucial.

+1