From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id B06FF2C8;
 Tue, 13 Dec 2016 12:52:29 +0100 (CET)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga104.jf.intel.com with ESMTP; 13 Dec 2016 03:52:28 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,341,1477983600"; d="scan'208";a="42049296"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29])
 ([10.237.220.29])
 by fmsmga006.fm.intel.com with ESMTP; 13 Dec 2016 03:52:27 -0800
To: Yong Wang <wang.yong19@zte.com.cn>, harish.patil@qlogic.com
References: <1480509129-27623-1-git-send-email-wang.yong19@zte.com.cn>
Cc: dpdk stable <stable@dpdk.org>, DPDK <dev@dpdk.org>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <0addf0ed-aab6-f977-6866-472ad0663cf6@intel.com>
Date: Tue, 13 Dec 2016 11:52:27 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <1480509129-27623-1-git-send-email-wang.yong19@zte.com.cn>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] net/qede: fix resource leak
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Dec 2016 11:52:30 -0000

On 11/30/2016 12:32 PM, Yong Wang wrote:
> Current code does not close 'fd' on function exit, leaking resources.
> 
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>

CC: stable@dpdk.org

> ---
>  drivers/net/qede/qede_main.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
> index ab22409..b666e1c 100644
> --- a/drivers/net/qede/qede_main.c
> +++ b/drivers/net/qede/qede_main.c
> @@ -137,6 +137,7 @@ static int qed_load_firmware_data(struct ecore_dev *edev)
>  
>  	if (fstat(fd, &st) < 0) {
>  		DP_NOTICE(edev, false, "Can't stat firmware file\n");
> +		close(fd);
>  		return -1;
>  	}
>  
> @@ -158,9 +159,11 @@ static int qed_load_firmware_data(struct ecore_dev *edev)
>  	if (edev->fw_len < 104) {
>  		DP_NOTICE(edev, false, "Invalid fw size: %" PRIu64 "\n",
>  			  edev->fw_len);
> +		close(fd);
>  		return -EINVAL;
>  	}
>  
> +	close(fd);
>  	return 0;
>  }
>  #endif
>