From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A2CDB2B88 for ; Wed, 1 Mar 2017 10:44:25 +0100 (CET) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 97FE061BAD; Wed, 1 Mar 2017 09:44:25 +0000 (UTC) Received: from [10.36.116.153] (ovpn-116-153.ams2.redhat.com [10.36.116.153]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v219iM8e022288 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 1 Mar 2017 04:44:24 -0500 To: Zhiyong Yang , dev@dpdk.org References: <1487926101-4637-1-git-send-email-zhiyong.yang@intel.com> <1487926101-4637-5-git-send-email-zhiyong.yang@intel.com> Cc: yuanhan.liu@linux.intel.com From: Maxime Coquelin Message-ID: <0ae31488-1ea6-abb8-7bd0-b5526dc9fc9f@redhat.com> Date: Wed, 1 Mar 2017 10:44:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1487926101-4637-5-git-send-email-zhiyong.yang@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 01 Mar 2017 09:44:25 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 4/5] net/vhost: remove limit of vhost TX burst size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 09:44:25 -0000 On 02/24/2017 09:48 AM, Zhiyong Yang wrote: > vhost removes limit of TX burst size(32 pkts) and supports to make > an best effort to transmit pkts. > > Cc: yuanhan.liu@linux.intel.com > Cc: maxime.coquelin@redhat.com > > Signed-off-by: Zhiyong Yang > --- > drivers/net/vhost/rte_eth_vhost.c | 24 ++++++++++++++++++++++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c > index e98cffd..1e1fa34 100644 > --- a/drivers/net/vhost/rte_eth_vhost.c > +++ b/drivers/net/vhost/rte_eth_vhost.c > @@ -52,6 +52,7 @@ > #define ETH_VHOST_QUEUES_ARG "queues" > #define ETH_VHOST_CLIENT_ARG "client" > #define ETH_VHOST_DEQUEUE_ZERO_COPY "dequeue-zero-copy" > +#define VHOST_MAX_PKT_BURST 32 > > static const char *valid_arguments[] = { > ETH_VHOST_IFACE_ARG, > @@ -434,8 +435,27 @@ eth_vhost_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs) > goto out; > > /* Enqueue packets to guest RX queue */ > - nb_tx = rte_vhost_enqueue_burst(r->vid, > - r->virtqueue_id, bufs, nb_bufs); > + if (likely(nb_bufs <= VHOST_MAX_PKT_BURST)) > + nb_tx = rte_vhost_enqueue_burst(r->vid, r->virtqueue_id, > + bufs, nb_bufs); > + else { > + uint16_t nb_send = nb_bufs; > + > + while (nb_send) { > + uint16_t nb_pkts; > + uint16_t num = (uint16_t)RTE_MIN(nb_send, > + VHOST_MAX_PKT_BURST); > + > + nb_pkts = rte_vhost_enqueue_burst(r->vid, > + r->virtqueue_id, > + &bufs[nb_tx], num); > + > + nb_tx += nb_pkts; > + nb_send -= nb_pkts; > + if (nb_pkts < num) > + break; > + } > + } It looks like the if/else could be avoided, but maybe you did so for performance reason? If this is the case, maybe you could add a comment or at least state this in the commit message. Thanks, Maxime > > r->stats.pkts += nb_tx; > r->stats.missed_pkts += nb_bufs - nb_tx; >