From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD428A0527; Mon, 9 Nov 2020 16:27:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B2455F13; Mon, 9 Nov 2020 16:27:55 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id CF3CE5B3C for ; Mon, 9 Nov 2020 16:27:52 +0100 (CET) IronPort-SDR: +DtpL0sbW8k/dXCTwisW6csqnvhDFrszedhSq3dMmTTmxOHOHrw5W6L6uF7c4RXsbVic7AWtzm Hdfy1ShSRCkg== X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="149100356" X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="149100356" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 07:27:42 -0800 IronPort-SDR: ebWdapyZRnWOyeB7jY6+CBsGh95f5hGiY7HwChArTZzdq0paKXtobFbC3MSDHBDPG36IH7OYX9 Ax/nraIzNT3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="473014708" Received: from silpixa00399498.ir.intel.com (HELO silpixa00399498.ger.corp.intel.com) ([10.237.222.52]) by orsmga004.jf.intel.com with ESMTP; 09 Nov 2020 07:27:42 -0800 From: Anatoly Burakov To: dev@dpdk.org Cc: Damjan Marion Date: Mon, 9 Nov 2020 15:27:47 +0000 Message-Id: <0ae7d9b2c1ee0e12f8ae7faa2d154c03ae7e0c92.1604935662.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH 21.02] mem: don't warn about base addr if not requested X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Any EAL memory allocation often goes through eal_get_virtual_area() function, which will print a warning whenever the resulting allocation didn't match the specified address requirements. This is useful for when we have requested a specific base virtual address, to let the user know that the mapping has deviated from that address. However, on Linux, we also have a default base address that's there to ensure better chances of successful secondary process initialization, as well as higher likelihood of the virtual areas to fit inside the IOMMU address width. Because of this default base address, there are warnings printed even when no base address was explicitly requested, which can be confusing to the user. Disable this warning unless base address was explicitly requested. Cc: Damjan Marion Signed-off-by: Anatoly Burakov --- Notes: I'm not entirely sure the trade off between user confusion and helpful debug information is worth it, but in my experience, i've stopped getting any emails about secondary processes a long time ago and this isn't a widely used feature, so i believe this is worth it. lib/librte_eal/common/eal_common_memory.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c index 33917fa835..6e0d6a0b1c 100644 --- a/lib/librte_eal/common/eal_common_memory.c +++ b/lib/librte_eal/common/eal_common_memory.c @@ -139,7 +139,8 @@ eal_get_virtual_area(void *requested_addr, size_t *size, rte_errno = EADDRNOTAVAIL; return NULL; } else if (requested_addr != NULL && addr_is_hint && - aligned_addr != requested_addr) { + aligned_addr != requested_addr && + internal_conf->base_virtaddr != 0) { RTE_LOG(WARNING, EAL, "WARNING! Base virtual address hint (%p != %p) not respected!\n", requested_addr, aligned_addr); RTE_LOG(WARNING, EAL, " This may cause issues with mapping memory into secondary processes\n"); -- 2.17.1