Re: [dpdk-dev] [RFC PATCH 1/5] kni: change and configure mac address

[Hemant Agrawal <hemant.agrawal@nxp.com>]

On 11/29/2017 4:01 AM, Ferruh Yigit wrote:
> On 5/3/2017 4:21 AM, Hemant Agrawal wrote:
>> This patch adds following:
>> 1. option to configure the mac address during create
>> 2. inform usespace, if mac address is being changed in linux
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>
> Hi Hemant,
Hi Ferruh,

Thanks for looking into it. It is a just a co-incidence that I started 
working on these again yesterday :)

I plan to send the updated patch along with application change in next 
few days.

>
> This RFC is waiting in patchwork for a while, is there plan to send a v1? I will
> mark patchset as RFC in patchwork.
>
> As far as I can follow latest patchset status is:
>
> provide initial value and add capability to change
> 1/5: MAC address
> 2/5: promisc mode
> 3/5: MTU
>
> There is a change request for 1/5, other two looks OK.

I am taking care of comments.

> But for all three the action done in kni_ops, which means application needs to
> implement these features.
> Not sure about pushing these common tasks to application, instead of all
> applications implement same thing, does it make sense to implement them in kni
> library?

I don't think it is a good thing to implement them in library itself.
Libary may not know about the equivalent Ethernet port and it may be a 
logical kni port also.

>
> 4/5: add gso_size info
> Nak because it uses mbuf field with another meaning
>
ok, I will try to find other means.

> 5/5: Add cleanup fix for multi process
> Multi process support is not supported in KNI at first place, if there is a need
> first it needs to be introduced and tested.

ok
>
>
> Thanks,
> ferruh
>