From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1119243CB8; Fri, 15 Mar 2024 12:17:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE53B42EE5; Fri, 15 Mar 2024 12:17:31 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2044.outbound.protection.outlook.com [40.107.243.44]) by mails.dpdk.org (Postfix) with ESMTP id 23F5442E6B for ; Fri, 15 Mar 2024 12:17:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y/d9IeVKZkn/FPAng2cHEmCvPE+JLADSQGhoA6DKWuad1+6dV9Rl1AFoRAyZrhVtRSINRhLU8yREkBfBDaLtLDZlWcb+9QKBhcy91c0Ov3tWU+4ZOOJA+pDnONj0mqPMbYjLV7BJ/bPENG7W6UNNiq3MqpBgCvVZaLLbUn86u84eeL2VWB+R+Uh+UMtKSo5q1verO45urSPGXnqb7vYAgmt2MgsykPxDrSCsqC58QaBGeAvT5sbMqDiV0huEXXIwtVbG5kGM7XE0Dj8rtDTWdyDYCcoFalb/F936hgDjlNuQtOAnFnFMXyq+i/wDxmJAtgDyMyECZ6DcYwktnOiGZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ne9IHGqoFIbQPyglW/X4UdOk7H53Hgo1Jdia+jQNb9s=; b=ZZmrogUX0MniH1+fR+FkEp8urRBuSu2mQswrAVkYGDnVbSVQIQB5eaHsGOIyV8kadtaVg7LUizSDmn/PWLmYajQGBniVr7VehcpFhglAA71AxrF46eWFQWwFFvR5fCuxdyQzR3OStWpNnjss/7/SG1owWQtgnmBJt+SOvzOvR0Ny/SyHEnjXBTAMYr21xofinjyo2OVMsswJU/F/naBbXmhU64NKuZq30UeKH7Xk6PZ6P6haFmJmBIPxa9x54nOIMVuCTwdpezfB36J4YLodEbpp1Lx/ZCqpdITYD4NNt7Vn2WaKZ/fbjG6cItQFCWsrvZfFcc4k6T6FXuLuo1tBeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ne9IHGqoFIbQPyglW/X4UdOk7H53Hgo1Jdia+jQNb9s=; b=UCDH6Xs6TQ/jwd561Aw9dIBb+esKdBRjzgz4iYB4NYGzzq12SMZ1IJkUBBQzLMstZaVtNBxUN1BsMFkVouTSZ8+cieIflOcIWUa7DtnlV6W2TjUl+27QAnuXbumbSNpPVaISMLnSDnWFBUKBQsMcTyvZwwL9R+xl5z2mTIGdlxs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH3PR12MB8235.namprd12.prod.outlook.com (2603:10b6:610:120::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.20; Fri, 15 Mar 2024 11:17:29 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7386.021; Fri, 15 Mar 2024 11:17:28 +0000 Message-ID: <0af89806-1dc8-4499-86f5-c7c6b9f44e25@amd.com> Date: Fri, 15 Mar 2024 11:17:24 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/testpmd: fix unpassed RSS algorithm Content-Language: en-US To: Jie Hai , dev@dpdk.org, Aman Singh , Yuying Zhang , Huisong Li Cc: fengchengwen@huawei.com References: <20240315030054.2976598-1-haijie1@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240315030054.2976598-1-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0254.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH3PR12MB8235:EE_ X-MS-Office365-Filtering-Correlation-Id: b8d65359-0775-4cd9-ea5e-08dc44e1800c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: saeRMR6z/v/8kE/76d6UkBhMYAL2jPwlkLSY4pzLby1G2GW+caGvNAqCvf9PeU+bwB3BsE/FlOipCG6J919LJH3r/+koKXKC0jJbKW0TLzc+geC1n49e7wGHqnNTFqaXJChqFD0/HfJKsxXvk85V7xLyxr0Qe55oEPxMGxFH5ZUKtzm6QnMxExfjsdsHQ5kt3gh+iGc0l1XhgktWR2kUMSUJg1rqE1uBWM8BwtlBlYTTmMogHrnWxmMWLQPgXaDGYJim4PwnpaNpNxhq65+f/KawAc37ArE2uHOs+99Jgq6LSn7Vmo0HoH7qliKtzSMEcdIgkuov8mKN0/gQpuK/U7Wf+cqPF2pvzqN6Dcx7HJ8mPNuKvm9bn/v8lFZqomskQVzVMUq8TyWQu8tZ4s+oc8BUFuBDIv2HDC/59PNE/DUGoQYp2jrcn3jFMX2EjX+T2uosLrM77pv3/b1TxCxCNJjCv5YehKzKL03y7bxjVgF4G7rd4MK2LdXsphb9JeWNLSIp9v1jVhDfzbeQqF2O55HuDs7BTq+BeA1XFasmaglI/C2/MGlKyRzUUSK7mUb8AyLC4GH6eyp3v61HKs1lc8rr2E2QhU0kpfrD4eT3Mgo9O8SiVIK40cGJcAVXjBJbbkJFs7wMRNbDDhYrK4vuLaqfKRqh/SD/Z2kpNFe4FQo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amFNTzBXeUVyWldMWU55VmxoK3BKL0o1RjIxTWZGWUtQNVJqeWx5Nk9IczYy?= =?utf-8?B?bHdtWUlDZVBRLzdyVUw0UDFRUU5YV0paaVR6aTYyeG9JdG5Nb1NQY05sWklu?= =?utf-8?B?R0ZYcGZyeVl4SVpMdFdQb0tabzgvZnNnOG5mOUxsN1F2SDBYaXlMUG5SZSth?= =?utf-8?B?Q1grMVZ2K3BySHpab2lVOXNsaElodmQ2bHVyTXBPbGVmRkN1Tnk3b2M1cDdt?= =?utf-8?B?c1dpWHlmQjBWaTc3UWpyd3c2Ky9md1BrVUJadlREbnNEMzFEcjA0RXZXbVdK?= =?utf-8?B?QUR2UklwK05LLzRzK21TZ2hSY2UrMlRQczdUSUFKTnV2SzFwN0wxWUh4RDRx?= =?utf-8?B?T1ppaG9BSzJTc0QxT01JR0JicHRZUlgxV3E2L1UraFlCbW5LbnhlV3gzNitY?= =?utf-8?B?bHVxZ0N1TDNuS2w0d1R3SVQ0b2VsVW0zeEVDSnRqaTNtdXdEbXd0RW9naG9p?= =?utf-8?B?eFZMV2V6eGpRb3pTN2NKMERLN2llNzZTVGFoeXNJZDNhWDZtcll4ZHJrcXo1?= =?utf-8?B?a3NjRVpSUHZWbVI2ZzNxNlNQTXg4QlB2ZVc3cTlPcnlDVHBjK25OT2U5OGJW?= =?utf-8?B?Tk5lR252Qmxub2c1V0drOFQxbVVmN0g1cW93c09GVlIyTDE1N1VrdE5EbkVl?= =?utf-8?B?V2VuTEpGbXpXQVVDQzl1RkpqQTBENytvT0c4ZHAxbmxDTUV0N21BekFmNFR1?= =?utf-8?B?blkvQTdMK24rZEtPTlY5Mml0VjNJVzZmQXcyNEc5aEdjQTAzb2N6ekpRR0xR?= =?utf-8?B?eFI0eGhhelA3MmdpQngxVktnV1RZRGRBbVR4VC85SFZOOUwxRFBDUzdRUHMw?= =?utf-8?B?QzhINEtveTRVY1M0MlZ5QnI3Z2NIVVVTemRDNm1veXo3UlVTbC9UNk54ZzdY?= =?utf-8?B?akZUaHNhVXB4UGdjSUZ1bFU1Ti9JSDVHeUs1WTVyUWtUVUd2enFhKzYrY21q?= =?utf-8?B?ZjhVZXlBN1UxcXBrcXBjV2hhR2o5aWxYN25QNW5nMkhMbGp4Kzh3MlpqQ2ZV?= =?utf-8?B?UVJ1TVFzSWtzRUpMZ3NNVytBTm5RaituNnBJdHd5c0RRaHpVZXNUS2JZWk9H?= =?utf-8?B?TVRUYXVyQ0MrZFlXclhONUFvS1BMMllKdFU2QlJobHJLanpIdENFK2JVaDdG?= =?utf-8?B?SkMyVXpCL1FYWU1sUm5Ra3hoUUU5RXpmeGRDVTNvL1RqaHc5YUJBWXlzMXcv?= =?utf-8?B?bk1hN205cEZNcVNrY3FHMVg3ZWtUOE1tOVRVOE1PTDBnQnBIMmEweVlQa3R0?= =?utf-8?B?Sis4ZUxCdDlLcjYzeUw0RW5tdnBtdVFoZlVza0xiRmNBU2wxekRrSkNxZXUw?= =?utf-8?B?OXBuYlBqUVJmdzR1MFFRSXpzNUhWN25BU1VvNmd0N0prcmlVUTlERjJWeTFT?= =?utf-8?B?M1VpRTVOQjA3NFlpaEhtSDQ3OElRUU9ZU0dJcWJyejlvcm4wQU9VOE9tRy9Q?= =?utf-8?B?ZjVDdi9aSXUxQUJneXgvY0pvMXRYdlpLb1lsTC9jR2o1WUZKeDlKaEx3alht?= =?utf-8?B?ZTRJdHpvdDg0VWlWcmkxdEVPTzRjbVhIWjhpTEhCbUkrd1paQis2bmxTVzhF?= =?utf-8?B?SUZtb1JSbEJUNGErWm1iQTU2bjJUUWhRSCtZNHUvcDdJdVVGa2xvTkIvMHdG?= =?utf-8?B?UjltL0wvM1didW5vOFNGUHlGUlZiSFR3eWkwTWVHc0FxWHYwMmJ5RCszM2xk?= =?utf-8?B?TUhnak40RjV5dDNObS9NcHpDWGxneU5DWlVuNlJLZWxsSE84d0RZMUd1RjZP?= =?utf-8?B?cG9OUCtOK0w4eXE4RFRIc0hzaEZWbDY0aitGVDU2UmlJbHRRcVMwN0MxdWZW?= =?utf-8?B?RjlXdkZuWHVNQWpicmlCQVRpdFZhWU9mdWJZZnRqZ1hhVUlRSnlmYXBwdkdq?= =?utf-8?B?Y2dsMDZBUW4rekhkYkdCRGovM0NtNFZpSVg3UEVTaFVIVVo2OVBGd3pQbGVE?= =?utf-8?B?S2R4dnhJUG9Ib1FLN2FaQ0F5azV6a2lUZXVBK0lCU2IxenVKbGwxMFQwVC9I?= =?utf-8?B?ZVZZOFJXdWNKR1BGTEZWS0V3NXc2QTc0VTQyMGpvTTUwOE9JV1dzQW1nN0tF?= =?utf-8?B?Vm55TGx2bDhvV0FQQmlCaVljcWQ0VGVhRUM2dFRHVThJdThFeFgzTDNGMGxq?= =?utf-8?Q?8dZFszQVtb4C51Ku8p0+xhwGb?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8d65359-0775-4cd9-ea5e-08dc44e1800c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 11:17:28.8931 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7pbG7lmOFKW38Fv3Qu7Xpc77G9DF2Car5z1O+ySl4kJSNuQEnmo6dBDb6itjYH6r X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8235 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/15/2024 3:00 AM, Jie Hai wrote: > The RSS algorithm from user is parased but not passed to the > rte_eth_dev_rss_hash_update() API as we wanted, this patch > fixes it. > > Fixes: 3da59f30a23f ("app/testpmd: set RSS hash algorithm") > Cc: stable@dpdk.org > > Signed-off-by: Jie Hai > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks. Sorry to see we missed something this simple, wasn't this tested when command is added?