From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4128AA0613 for ; Fri, 27 Sep 2019 10:47:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 115942BEA; Fri, 27 Sep 2019 10:47:47 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 28C962BE9; Fri, 27 Sep 2019 10:47:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2019 01:47:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,554,1559545200"; d="scan'208";a="214761861" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by fmsmga004.fm.intel.com with ESMTP; 27 Sep 2019 01:47:39 -0700 To: "Wei Hu (Xavier)" , dev@dpdk.org, Aaron Conole , test-report@dpdk.org Cc: xavier_huwei@163.com, xavier.huwei@tom.com, linuxarm@huawei.com, forest.zhouchang@huawei.com, Jeremy Plsek , Ali Alnubani References: <1569506528-60464-1-git-send-email-xavier.huwei@huawei.com> <1d5167d8-307a-ba20-632a-e45f945b854c@huawei.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <0b069879-cc8e-80f2-3df1-1d3bb0819d60@intel.com> Date: Fri, 27 Sep 2019 09:47:39 +0100 MIME-Version: 1.0 In-Reply-To: <1d5167d8-307a-ba20-632a-e45f945b854c@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 00/22] add hns3 ethernet PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/27/2019 7:52 AM, Wei Hu (Xavier) wrote: > Hi, Ferruh Yigit > > I sent out PATCH V3 to fix the conflict that occurs in > doc/guides/rel_notes/release_19_11.rst when performing > 'git am patch(PATCH V2 series)' operation based on the latest > dpdk-next-net because of the recent change in the repository. > > The page in patches.dpdk.org indicates that CI checking > against this series failed and terminated, the content of 'S/W/F' field is '---', the page as follows: > http://patches.dpdk.org/project/dpdk/list/?series=&submitter=1405&state=*&q=&archive=&delegate= > > The information of CI building as follows, and in fact > there was non incompatible pointer type error based on > the latest repo in my local server. > http://mails.dpdk.org/archives/test-report/2019-September/099170.html > > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4723:24: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] > .promiscuous_enable = hns3_dev_promiscuous_enable, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4723:24: note: (near initialization for ‘hns3_eth_dev_ops.promiscuous_enable’) > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4724:25: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] > .promiscuous_disable = hns3_dev_promiscuous_disable, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4724:25: note: (near initialization for ‘hns3_eth_dev_ops.promiscuous_disable’) > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4725:26: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] > .allmulticast_enable = hns3_dev_allmulticast_enable, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4725:26: note: (near initialization for ‘hns3_eth_dev_ops.allmulticast_enable’) > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4726:26: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] > .allmulticast_disable = hns3_dev_allmulticast_disable, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4726:26: note: (near initialization for ‘hns3_eth_dev_ops.allmulticast_disable’) > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4729:24: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] > .stats_reset = hns3_stats_reset, > ^~~~~~~~~~~~~~~~ > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4729:24: note: (near initialization for ‘hns3_eth_dev_ops.stats_reset’) > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4732:24: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] > .xstats_reset = hns3_dev_xstats_reset, > ^~~~~~~~~~~~~~~~~~~~~ > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4732:24: note: (near initialization for ‘hns3_eth_dev_ops.xstats_reset’) > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4735:28: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] > .dev_infos_get = hns3_dev_infos_get, > ^~~~~~~~~~~~~~~~~~ > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4735:28: note: (near initialization for ‘hns3_eth_dev_ops.dev_infos_get’) > cc1: error: unrecognized command line option ‘-Wno-address-of-packed-member’ [-Werror] > cc1: all warnings being treated as errors > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'hns3_ethdev.o' failed > make[6]: *** [hns3_ethdev.o] Error 1 > > > The detail information of the repository when making PATCH V3 on as follows: > > repo: http://dpdk.org/git/next/dpdk-next-net > branch: master Hi Xavier, Above repo and the branch is correct, also with a quick check your code seems correct too. CI is using wrong tree for the build test [1], @Ali, @Aaron and @Jeremy are on cc for long term investigation. Hopefully there will be a merge from next-net to main repo, that should fix the false positives in CI. Can you please follow the merge and ping us, so we can ask to Jeremy to re-run the test? Thanks, ferruh [1] Metadata from test: " Test-Label: Performance-Testing Test-Status: FAILURE http://dpdk.org/patch/59882 _build patch failure_ Submitter: Wei Hu (Xavier) Date: Thursday, September 26 2019 14:01:47 Applied on: CommitID:bd253daa7717835f88bbc58b09a94d0060380396 Apply patch set 59882-59901 failed: " Commit is from the main tree, that is why causing the build error. > > git log --oneline > 3be6962 app/testpmd: fix unused variable compile error > 5453153 app/testpmd: fix crash on port reset > 944ee10 net/ipn3ke: setup MTU during HW init > 52e3ab3 net/ice: remove Rx legacy descriptor definition > d27982e net/ice: switch to Rx flexible descriptor in AVX path > 0973c28 net/ice: switch to flexible descriptor in SSE path > 98ed8c1 net/ice: add protocol extraction support for per Rx queue > 03ff0d1 net/ice: handle the Rx flex descriptor > 2962f75 net/ice: add Rx flex descriptor definition > a03e11f net/i40e: limit the number of VF messages > 644032b net/ice/base: remove unused code > c02031f net/ice/base: add switch support for IPv6 tc field > 05859a5 net/ice/base: fix PTYPE bitmap > 4f07dc0 net/ice/base: fix alignment > 9d1c626 net/ice/base: use bitmap copy where appropriate > 3efd0a4 net/ice/base: remove unnecessary error log > 82c1c29 net/ice/base: fix 4 bytes alignment for PPPoE dummy packet > 17db50c net/ice/base: search field vector indices for result slots > 9ef53fb net/ice/base: remove unused DDP package macros > 665293f net/ice/base: fix segment in remove existing RSS rule > 079ca8c net/ice/base: fix the bitmap for TCP in RSS > d3e1ebd net/ice/base: add FDIR support for GTPU QFI field > > > Is there a way to reconstruct PATCH V3 in CI? Do we > resend PATCH V3 to trigger CI reconstruct them again? > Thanks for your suggestion. > > Regards > Xavier > > > On 2019/9/26 22:01, Wei Hu (Xavier) wrote: >> The Hisilicon Network Subsystem is a long term evolution IP which is >> supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920. >> >> This series add DPDK rte_ethdev poll mode driver for Hisilicon >> Network Subsystem 3(hns3) network engine. >> >> v2 -> v3: >> 1. Resolve the conflict problem when performing git operation >> based on the current repository. The conflict occurs in >> doc/guides/rel_notes/release_19_11.rst. >> >> v1 -> v2: >> 1. Address some comments from Jerin Jacob Kollanukkaran, >> Stephen Hemminger and Ferruh Yigit. >> >> Wei Hu (Xavier) (22): >> net/hns3: add build and doc infrastructure >> net/hns3: add hardware registers definition >> net/hns3: add some definitions for data structure and macro >> net/hns3: register hns3 PMD driver and add the log interface >> definition >> net/hns3: add support for cmd of hns3 PMD driver >> net/hns3: add the initialization of hns3 PMD driver >> net/hns3: add support for MAC address related operations >> net/hns3: add support for some misc operations >> net/hns3: add support for link_update operation >> net/hns3: add support for flow directory of hns3 PMD driver >> net/hns3: add support for RSS of hns3 PMD driver >> net/hns3: add support for flow control of hns3 PMD driver >> net/hns3: add support for vlan of hns3 PMD driver >> net/hns3: add support for mailbox of hns3 PMD driver >> net/hns3: add support for hns3 VF PMD driver >> net/hns3: add RX/TX package burst and queue related operation >> net/hns3: add start stop configure promiscuous ops >> net/hns3: add dump register ops for hns3 PMD driver >> net/hns3: add abnormal interrupt process for hns3 PMD driver >> net/hns3: add stats related ops for hns3 PMD driver >> net/hns3: add reset related process for hns3 PMD driver >> net/hns3: add multiple process support for hns3 PMD driver >> >> MAINTAINERS | 8 + >> config/common_base | 5 + >> config/common_linux | 5 + >> config/defconfig_arm-armv7a-linuxapp-gcc | 1 + >> config/defconfig_i686-native-linuxapp-gcc | 5 + >> config/defconfig_i686-native-linuxapp-icc | 5 + >> config/defconfig_ppc_64-power8-linuxapp-gcc | 1 + >> config/defconfig_x86_64-native-linuxapp-icc | 5 + >> config/defconfig_x86_x32-native-linuxapp-gcc | 5 + >> doc/guides/nics/features/hns3.ini | 34 + >> doc/guides/nics/features/hns3_vf.ini | 29 + >> doc/guides/nics/hns3.rst | 60 + >> doc/guides/nics/index.rst | 1 + >> doc/guides/rel_notes/release_19_11.rst | 6 + >> drivers/net/Makefile | 1 + >> drivers/net/hns3/Makefile | 45 + >> drivers/net/hns3/hns3_cmd.c | 565 +++ >> drivers/net/hns3/hns3_cmd.h | 761 ++++ >> drivers/net/hns3/hns3_dcb.c | 1642 +++++++++ >> drivers/net/hns3/hns3_dcb.h | 166 + >> drivers/net/hns3/hns3_ethdev.c | 4947 ++++++++++++++++++++++++++ >> drivers/net/hns3/hns3_ethdev.h | 645 ++++ >> drivers/net/hns3/hns3_ethdev_vf.c | 1725 +++++++++ >> drivers/net/hns3/hns3_fdir.c | 1059 ++++++ >> drivers/net/hns3/hns3_fdir.h | 205 ++ >> drivers/net/hns3/hns3_flow.c | 1903 ++++++++++ >> drivers/net/hns3/hns3_intr.c | 1166 ++++++ >> drivers/net/hns3/hns3_intr.h | 79 + >> drivers/net/hns3/hns3_logs.h | 34 + >> drivers/net/hns3/hns3_mbx.c | 353 ++ >> drivers/net/hns3/hns3_mbx.h | 136 + >> drivers/net/hns3/hns3_mp.c | 214 ++ >> drivers/net/hns3/hns3_mp.h | 14 + >> drivers/net/hns3/hns3_regs.c | 368 ++ >> drivers/net/hns3/hns3_regs.h | 99 + >> drivers/net/hns3/hns3_rss.c | 584 +++ >> drivers/net/hns3/hns3_rss.h | 124 + >> drivers/net/hns3/hns3_rxtx.c | 1676 +++++++++ >> drivers/net/hns3/hns3_rxtx.h | 317 ++ >> drivers/net/hns3/hns3_stats.c | 975 +++++ >> drivers/net/hns3/hns3_stats.h | 152 + >> drivers/net/hns3/meson.build | 37 + >> drivers/net/hns3/rte_pmd_hns3_version.map | 3 + >> drivers/net/meson.build | 1 + >> mk/rte.app.mk | 1 + >> 45 files changed, 20167 insertions(+) >> create mode 100644 doc/guides/nics/features/hns3.ini >> create mode 100644 doc/guides/nics/features/hns3_vf.ini >> create mode 100644 doc/guides/nics/hns3.rst >> create mode 100644 drivers/net/hns3/Makefile >> create mode 100644 drivers/net/hns3/hns3_cmd.c >> create mode 100644 drivers/net/hns3/hns3_cmd.h >> create mode 100644 drivers/net/hns3/hns3_dcb.c >> create mode 100644 drivers/net/hns3/hns3_dcb.h >> create mode 100644 drivers/net/hns3/hns3_ethdev.c >> create mode 100644 drivers/net/hns3/hns3_ethdev.h >> create mode 100644 drivers/net/hns3/hns3_ethdev_vf.c >> create mode 100644 drivers/net/hns3/hns3_fdir.c >> create mode 100644 drivers/net/hns3/hns3_fdir.h >> create mode 100644 drivers/net/hns3/hns3_flow.c >> create mode 100644 drivers/net/hns3/hns3_intr.c >> create mode 100644 drivers/net/hns3/hns3_intr.h >> create mode 100644 drivers/net/hns3/hns3_logs.h >> create mode 100644 drivers/net/hns3/hns3_mbx.c >> create mode 100644 drivers/net/hns3/hns3_mbx.h >> create mode 100644 drivers/net/hns3/hns3_mp.c >> create mode 100644 drivers/net/hns3/hns3_mp.h >> create mode 100644 drivers/net/hns3/hns3_regs.c >> create mode 100644 drivers/net/hns3/hns3_regs.h >> create mode 100644 drivers/net/hns3/hns3_rss.c >> create mode 100644 drivers/net/hns3/hns3_rss.h >> create mode 100644 drivers/net/hns3/hns3_rxtx.c >> create mode 100644 drivers/net/hns3/hns3_rxtx.h >> create mode 100644 drivers/net/hns3/hns3_stats.c >> create mode 100644 drivers/net/hns3/hns3_stats.h >> create mode 100644 drivers/net/hns3/meson.build >> create mode 100644 drivers/net/hns3/rte_pmd_hns3_version.map >> > >