From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id E18C61BA17 for ; Thu, 10 May 2018 12:37:30 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 94CBF480059; Thu, 10 May 2018 10:37:29 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Thu, 10 May 2018 11:37:24 +0100 To: Thomas Monjalon , References: <20180509094337.26112-1-thomas@monjalon.net> <20180509224313.27289-1-thomas@monjalon.net> <20180509224313.27289-6-thomas@monjalon.net> From: Andrew Rybchenko Message-ID: <0b071bfa-29e0-b014-1991-ef500b870a07@solarflare.com> Date: Thu, 10 May 2018 13:37:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180509224313.27289-6-thomas@monjalon.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23834.003 X-TM-AS-Result: No--6.238200-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1525948650-g4-Ufw3o8WcV Subject: Re: [dpdk-dev] [PATCH v2 05/11] ethdev: add probing finish function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 10:37:31 -0000 On 05/10/2018 01:43 AM, Thomas Monjalon wrote: > A new hook function is added and called inside the PMDs at the end > of the device probing: > - in primary process, after allocating, init and config > - in secondary process, after attaching and local init > > This new function is almost empty for now. > It will be used later to add some post-initialization processing. > > For the PMDs calling the helpers rte_eth_dev_create() or > rte_eth_dev_pci_generic_probe(), the hook rte_eth_dev_probing_finish() > is called from here, and not in the PMD itself. > > Note that the helper rte_eth_dev_create() could be used more, > especially for vdevs, avoiding some code duplication in PMDs. > > Cc: stable@dpdk.org Why Cc? > Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko