From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <akhil.goyal@nxp.com>
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
(mail-eopbgr60085.outbound.protection.outlook.com [40.107.6.85])
by dpdk.org (Postfix) with ESMTP id ABA1B5F20
for <dev@dpdk.org>; Mon, 17 Sep 2018 14:01:51 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=2ghfvZ3PiLyo0gBO+xZH7HTcaJeoYl9lj9sh9CKjJuo=;
b=lGXWjVTid6yAueIHrmg8GZSr5c+MZMUFonn4j1WBFTECcIyi1yLpY1at5adUXSHJFkXANnVay69RcMel9TR7DY5GiOXQlT5YB5i9DrtkHU5GXpW9hgdYOLj9ucfOUCAHA5dLsuPidK8zpF5/uyOnJR3i4dzJwKv1kIAksP0hb8U=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=akhil.goyal@nxp.com;
Received: from [10.232.134.144] (14.143.30.134) by
VI1PR04MB4896.eurprd04.prod.outlook.com (2603:10a6:803:56::29) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.1143.17; Mon, 17 Sep 2018 12:01:47 +0000
To: Anoob Joseph <ajoseph@caviumnetworks.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: Murthy NSSR <nidadavolu.murthy@caviumnetworks.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>, dev@dpdk.org,
Ankur Dwivedi <ankur.dwivedi@caviumnetworks.com>,
Anoob Joseph <anoob.joseph@caviumnetworks.com>,
Nithin Dabilpuram <nithin.dabilpuram@caviumnetworks.com>,
Ragothaman Jayaraman <rjayaraman@caviumnetworks.com>,
Srisivasubramanian S <ssrinivasan@caviumnetworks.com>,
Tejasree Kondoj <kondoj.tejasree@caviumnetworks.com>
References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com>
<1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com>
<1536033560-21541-10-git-send-email-ajoseph@caviumnetworks.com>
From: Akhil Goyal <akhil.goyal@nxp.com>
Message-ID: <0b2cecb1-f055-61d6-3c10-802d0d647b96@nxp.com>
Date: Mon, 17 Sep 2018 17:31:34 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <1536033560-21541-10-git-send-email-ajoseph@caviumnetworks.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Originating-IP: [14.143.30.134]
X-ClientProxiedBy: BM1PR01CA0100.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::16)
To VI1PR04MB4896.eurprd04.prod.outlook.com
(2603:10a6:803:56::29)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9332a53e-aa8e-4ac0-b191-08d61c9559c1
X-MS-Office365-Filtering-HT: Tenant
X-Microsoft-Antispam: BCL:0; PCL:0;
RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);
SRVR:VI1PR04MB4896;
X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4896;
3:9ZROHssNmizbcX2GEo81tj71oNcShGThrx66+ZsrJhs7W6vA/FZIRg0aEe+BQhkfUIYaocv7dEXBQI23irlOlF5R8vS2xd4Cf8dTdRm2sZI08xSyUSb99KST3Ncob+w0MrBg9kW3u716HefOynj3ZoMPmZTulCLFeoZDZF54XQFdJRRJrrtGmA97tt8KCbVOmbtkcAAr5g1DzNfse/0XfuJiiBtbDR7DG3yxc2IJqSlJQvy7QNEEFEfMVjRvhVlB;
25:J6crJWsPdx69/7U3HHM8Tajskjzz1+aDlKzK123jXafIQ2upwoQR3y9FNoOy00lczKNItgJFk+Fwmae0gsJNcwtAqxigEo9JYYPxAb9/5iCa9ZiO7K3OjaX219eeZO8JA1D7EFINQVTRf0R7xusZQDfMZAOzMHrhe7qnNMn9/0wO0E3aoZg1K7UJudfBsp4PNIkVZjb8Zp6m53lM2o/SlQAaqs3KjGplyIz+kdu7oxNjAK21GIJNGGGdJfmVS1P8q0IY3dSAYG70lOMwR3Nqs8Z9HvrrCT171Gv4ddWk/M+hloqJrXMfOpn49C9gZIgK30p85E3+LkDI/IkDXuOk6Q==;
31:LPyF9LF/7igPj8De0NLiQowIT6Yv1MB2r3yl7wyk17BtVj9fXeq/S3x/zfrAPJRC/Y84m9QOpac3WF0ksIIRsBy/3njKkMV42laaDO2bXGT443R5nWfU2GYs41Dd1yaM8/H6R3Gw2WqCrlrkgteINrhqPeZHbSKrCJDlts3/nT3gv2/yUvpaoHYWRUTdtr9F4Bi4vIjqJLQoHSNQ6+PJGfLjCSs5IKjwnz0UdvTg4m0=
X-MS-TrafficTypeDiagnostic: VI1PR04MB4896:
X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4896;
20:x/UAmLJWuj5yy5mgzZpIrYBxyG/aV/W4HHyHOH5AO8Ee9dlPV+SpQjDidHYkA0R/DUOdBjYNpZGxFJiz97XFCLNqz7jilLoxZTwaqex/452AnTQYo1HFqamElEVbiDTQDRWGdYVuuPnziWZ1K8ugsLJjEyAwEBX7Od7H9jGNKIZZxmpYyqejjxLDhhRV6VsAQl6zYmX1sAKMPtVsZOPtEn2msvXuQXSVEkwlUqahd3iV0HwVA+Pk3qf0hROCYi7Vi1qCqxthnHAO6PD1RhX5HyaYGxp16t/xvnqm1wIVd76oGoqvs8CzICirpNgeGxlah5qB/UgoCtzacQJOZL8UKKBM/eDWxMQ3sq8GzOE3qwspr13P5+3jf4/PXtAXLhUWoagmNIAmhm5EPXo2Ew9vRzdB0nh0mbCAPaEXOGwNdBCTeVYbkTeYofTRGTa7uvXCbNgCNskEWXf9NRA00kn29UkMZ1ui+wgETKP1a3HFV0A2meZct2t3CvzXzB0OSXl1;
4:jvHUlzWyReHgKN/H8TZF0kKp1Xi6LvAArEikgLjdZlBmLGxPRWBO58n5YjVueGlg+JJ7rfHbze/nrR8guAaGLRQNJ7JIsp5cKAuwijowh5f0aYIFMGFtTk7yGwJUOG8oKe1YnIPjKEL2k9jGWnmHg5rG7CuRCmw8Mc8u9YXQLipbZLCFIWolULiZQvsKCmZu3FM8sxC7KVgBoaEwrrZUkZ7eWi3+SDefjrCsD0kSVxVCFeqhN5Q2Xz6t7iHgjHmeEJkwF7G+pp5V18aHvpBVVw==
X-Microsoft-Antispam-PRVS: <VI1PR04MB489637101447B4947F15C1A4E61E0@VI1PR04MB4896.eurprd04.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-MS-Exchange-SenderADCheck: 1
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(10201501046)(3002001)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(201708071742011)(7699050);
SRVR:VI1PR04MB4896; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB4896;
X-Forefront-PRVS: 0798146F16
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(6049001)(39860400002)(396003)(136003)(376002)(346002)(366004)(189003)(199004)(14444005)(478600001)(230700001)(31686004)(476003)(97736004)(5009440100003)(50466002)(305945005)(58126008)(2616005)(486006)(956004)(386003)(67846002)(5660300001)(11346002)(446003)(53936002)(8936002)(316002)(81156014)(16526019)(26005)(186003)(54906003)(229853002)(65956001)(65806001)(110136005)(65826007)(6486002)(7416002)(77096007)(81166006)(47776003)(66066001)(8676002)(2906002)(4326008)(52116002)(44832011)(6246003)(68736007)(6666003)(7736002)(86362001)(16576012)(76176011)(31696002)(105586002)(3260700006)(25786009)(64126003)(106356001)(52146003)(23676004)(6116002)(36756003)(3846002)(2486003)(110426005);
DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB4896; H:[10.232.134.144]; FPR:;
SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
Received-SPF: None (protection.outlook.com: nxp.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA0TUI0ODk2OzIzOlhXamYzd3h2U08rRzQzdXlYbkJOTlh6OW12?=
=?utf-8?B?OENmNGp4SWtLeDRuMCt2L2h5SDlLTWVCeVJKMTd4TWFvK3dMNFk0d0p4RFBt?=
=?utf-8?B?TEoxRCtJbmRkQlUvRFpMTFZBTForRkQ3TE8xanBPOGdGL1RGUnNJRW15Wkx2?=
=?utf-8?B?RFlEemxvMHZ3WDVqa29NdXE2UGJpRG9HZVkrdGtTdFRUZFQvNmsxLzZjdW13?=
=?utf-8?B?a0tPNUlOVGFkSGUxU0VkanJhMTQySFNKMWVFam1KbEhJQ3kzMzJEOFA0N2Vi?=
=?utf-8?B?elNjanpWNHFPRzFNNDhldGtoaVpTTDRaaHJ4MVB2VjFmaFhwY2JMeERRVXBE?=
=?utf-8?B?Uld6bkhCU3FKTlZSMlR6NWRGekJqWXlkVVdYaGdwMTJlL1ZCSGkxTlJMK0w5?=
=?utf-8?B?RWswVDlTMjliVlcrUHZPeW9XZlFJZlpCa3pZMDE5bmQ3Q0JxMWloSHNBVlJT?=
=?utf-8?B?L1VIU2Q1dW51Wm4zeG5qRlFhRUNoV2xCODJxL1Frcm5hd25jMmVwYzNwMU5l?=
=?utf-8?B?b0ZscDZZSkNsOWdIWmdIbkpGWEordjJHb2ZsOGJkVFFXei9TdFlEYWNTUjhM?=
=?utf-8?B?cDlHajF2ZjNOTi9oOVZKVTdxQzNvK1pVamFkWDZjdmZ3N2NhOEQxamc2Z0cv?=
=?utf-8?B?TVNSUEhtL3RZS0IwV2kzSW94ZDZRcVJ3dXRhN1N6M0EzT2FGWUhyaVRwSEYy?=
=?utf-8?B?WkNlZ281ZEJKazBadDg4Mld3Rll0Ujk1VTJBNm9RRUQ3aXd6VUl6dXJCM1JV?=
=?utf-8?B?M2Fsd3JrMWFPM2VENzlvREZCZjRaa1RSL3JGTGRxUkZKd3h6Q3ZNZnF2TjRo?=
=?utf-8?B?ZmVlZUs4UDhrbU54NS9UUUMwYndJOFFJWnQ0V0Q0MjVYcFZoUDF1TW9hVHZN?=
=?utf-8?B?UTdIL1dBTGJ3dElVK3RPd3grZG90MkZFTnRIZHJJZUdvaXk1cGFMOVFaS0ZV?=
=?utf-8?B?emhQYW00SXBod1hvZ1phK0MwRnlSRU5TWlVrdlFyUE9JM0M3OG9tUkJrNSs3?=
=?utf-8?B?cWJLY2xlaFkyZmJiN1BpNythM3ROdXZTeFlsT2IyTWVDV0pHaDU3YmV3ODBD?=
=?utf-8?B?TStzSnh3eGNEMGo3RTVJR0ZUbCtkczAvcWh4bWN4RGRpeGl6UzA0Wm5RSXFm?=
=?utf-8?B?Z2t3Wkp2OEUvSCt4dkRhcG9sMjFnVk9HVmJkS1hKdW1KVnBpWXVZbVM2VjN0?=
=?utf-8?B?ZmltZlJ6SWJza0ZyRWpBYU9KcWVoSDc5NzRZdHlsTVR3TlpzTnhvTytWTmVE?=
=?utf-8?B?WFBPTGl3SWNIc2xJclZnQlN6a2pETWlISFZyVURVQ3RiWHRnNm1SQm8vTHdv?=
=?utf-8?B?SUJJNmdmbTBNTnNpNzViOVdvbnB1dGR1MGkrQjQyems3WjNyQVQ4YUJleFAx?=
=?utf-8?B?VlNENEdnOFBIT3NtNExEMHZCNllrWWl5LzczQTRXMDVVTTVQaWw3T1BDQWZt?=
=?utf-8?B?SUZLNDJYKzAwNmpGd0JabzZlQmtXUTlONW5YbnRDYmRqUWVELzBIRFBSZk0w?=
=?utf-8?B?eEZQUGlJbDRySVpzdDdMbHJHWlBreEswam1Pd0FkR2pRMC9ZTWtFQ29qbUVK?=
=?utf-8?B?NkhhZzBWZk43TWRGQ0l6OG5FMVlvZ2ZzWnJJQ2tBNUxNNzV6L1hpY0wvZEZW?=
=?utf-8?B?REowMDdpd2d0TkRZS2xpUnBoQURxV1hKNzBDMXpadkRQQmRVaElLMGV1VExu?=
=?utf-8?B?amJrc2tZMVQwbklkYnZ1eEZQbm40MEkvRUczdEJucnFHY0pZbEQ5ZVZSRXRE?=
=?utf-8?B?ckcya1dzN0hITTRJY2hZbndaYWlacFB4YzBsSHdaVUtCSHdzODJUNElhVk1R?=
=?utf-8?B?VXNQdTcyR2tmdXFIZVZkTWMwZk5EcVBQcnlsaVhLVktObGM2aC82cWxGblpv?=
=?utf-8?B?M1BRQ2l0V0dvL0Nva0E4TUNKK1NFUnJOTTR3OHpNcjdvRlYyQUxJT1U5bTdh?=
=?utf-8?B?N3krWnBub2o0cVNIamR5ZHg4VDlWNHhzcVpEcXYzRU5DbGxuTXNHYnRmTGhi?=
=?utf-8?B?ZzVFU1M4Nm9MZTJBbVFmalk0OTIrRElyVGJXUVBFVzloelVUbk51dnlSak9w?=
=?utf-8?B?QnZSUTA1NG0vVkZzcGpMTlZ4K0xOdWRnY3lTQjlnZzNhcnRxQmp6cE5TZ3N3?=
=?utf-8?Q?DmsfbyJ5ZUh3ZD+Fc4om/3I=3D?=
X-Microsoft-Antispam-Message-Info: xEm21E+WkUOyjKwBXYGcDuDo3VVs7jdP9FgR2WIrGuXjoWFW48bcTQRs9OuxVvUd2UyM0BfLYeS760kAP/bQheQzG3cMEurmPpk2fLxsp/TbPqGieAmWqv6R/RIzWllN1ymscJzBRACWMVNNr60pNkFxNXQntXN5l6GVI/2E0Sl+cJRb7wVqW0F11l1iAdjydMGY1erojwWLe7ON4t+3Ft/R9XBAtWgmCIDkU2h0vwqA4RLR6vM+rLs+MrqX65kV8mXk1gkPjKuXKW+K5WUmZmz/OUsss7GjKPpoLfc/b+ovCb1AEJ8vyFTebP9RvJl0QtBHnLT23Fyp1XMwiLPgUwZ8hMc8rRVvr6IodMkxeWg=
X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4896;
6:jHaXcxRf2PzuSMCMTS0f7spj0bj67SREsvdVdAt6Ufz0EU1DstgmVSTfhAygX58UixUDen7h31M41j3alp1si3zsqUJ79VkfvM/J6u8j4f+nIjioAgKVD3OHrULWKFN/p1tuLG3nqRUCZu+Aai02VLZjJQEL+cf3hdwH9e2gFYZ0KxlCo29/NijFQmRdT2sllMS8chYbGX/6VHXy2geebyUUrWUtlvyP0xtL5nqiWUJOatzP5Ho30hupJ6IDvibTWk2WFrmkpaTchmVw21AbtfgASnpDK4hqJvPWvMu3E37oFAMkTbm/luYL1RiePkyKQvlXzpd8T0KANQpR93z5LngMhyo3B0jME5O6N82uI7h7CAjaMMlw7Dpc0BfkCUOi1XlSSCHVvsUeje7J1a5KLJubf3ljUqdiIb1s8o2XbWGPejFi906X3/KVVEZema5WzRl9qGSAnyYmc6o8SSkvPw==;
5:fujhL8ig4y/sme60V6VnnFvLcJgyUKWrcdkIgdZQlsaSFGw0zHCje2dOjTZKZvt93CY9dqhV7+jgOg5wkc8G5sJr6sWJut6hCrxjQRVLsW8ESjVt+VK/JWbTIpopaZklwCPIpa52jCJTTUM2mtLSt/UNvrxu3IGsHwgR+4GgF1o=;
7:nQfwNiQFXSMWPbo7nzxHbCje74dEXn2vxMCQ+irfdEzo1qGJ+hIWMuoxrj+GBl5yieWthERmkLSnG2IBThbaR8e57s/3RcsYTwa3jCObEpr6q7MTCQIw2Ro9cW86emrnXa2MzWSEoT+NCJuh2b90h7ByM1hXYh2hHeywWYCaSmkbsaoDTkoA7mJIHNyBlLAmi/mXPmTZ2d6Ws24xYUlrPWenVHsje6BKqJv7A9Qt+gqfM+C84LAA88u/ZufpZ2SK
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2018 12:01:47.8969 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9332a53e-aa8e-4ac0-b191-08d61c9559c1
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4896
Subject: Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric
capabilities
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Sep 2018 12:01:52 -0000
> diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c b/drivers/crypto/octeontx/otx_cryptodev_ops.c
> index d25f9c1..cc0030e 100644
> --- a/drivers/crypto/octeontx/otx_cryptodev_ops.c
> +++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c
> @@ -10,9 +10,15 @@
> #include "cpt_pmd_logs.h"
>
> #include "otx_cryptodev.h"
> +#include "otx_cryptodev_capabilities.h"
> #include "otx_cryptodev_hw_access.h"
> #include "otx_cryptodev_ops.h"
>
> +static const struct rte_cryptodev_capabilities otx_capabilities[] = {
> + OTX_SYM_CAPABILITIES,
> + RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
> +};
> +
better to have otx_capabilities structure defined in the otx_cryptodev_capabilities.h
I don't see any value addition of creating a macro in one file using in a separate structure in another file
which doesn't have anything new in that structure. It would also give checkpatch error.
You can directly have a capability structure without the #define.
> /* Alarm routines */
>
> static void
>