From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F8DAA0548; Tue, 27 Apr 2021 05:00:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDDB540143; Tue, 27 Apr 2021 05:00:15 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id E1E754003E; Tue, 27 Apr 2021 05:00:13 +0200 (CEST) IronPort-SDR: GlOdHNjfwVbjPcm1zsdHk6T05iQFrdMSgjVKPKtVQcLWi0AvmMakRZjzNCRfoOwMjmAftXOows 5eeZMyq84Nuw== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="183576010" X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="183576010" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 20:00:12 -0700 IronPort-SDR: lOfQnv1c+Q1F13zB1ZlnYeqkMmrRayE8lrp78ZBCOgn3kOIh48/PxAJHkdxqTjR0m1hsNHeeZa IQ/wVHVnAw7A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="525944713" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 26 Apr 2021 20:00:12 -0700 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 26 Apr 2021 20:00:11 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 27 Apr 2021 11:00:09 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Tue, 27 Apr 2021 11:00:09 +0800 From: "Zhang, Qi Z" To: "Rong, Leyi" , "Zhang, AlvinX" , "Yang, Qiming" CC: "dev@dpdk.org" , "Zhang, AlvinX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode Thread-Index: AQHXObUds1pCezTxAEawVijQ34nxharHIW0AgACN6UA= Date: Tue, 27 Apr 2021 03:00:09 +0000 Message-ID: <0b35d04a6734456d9ce4319ca65473ed@intel.com> References: <20210425092639.1428-1-alvinx.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Rong, Leyi > Sent: 2021=1B$BG/=1B(B4=1B$B7n=1B(B27=1B$BF|=1B(B 10:32 > To: Zhang, AlvinX ; Zhang, Qi Z > ; Yang, Qiming > Cc: dev@dpdk.org; Zhang, AlvinX ; > stable@dpdk.org > Subject: RE: [dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Alvin Zhang > > Sent: Sunday, April 25, 2021 5:27 PM > > To: Zhang, Qi Z ; Yang, Qiming > > > > Cc: dev@dpdk.org; Zhang, AlvinX ; > > stable@dpdk.org > > Subject: [dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode > > > > In some cases, it seems that the txq mbuf vector release mode is > > enabled first, and then it is confirmed that the conditions for using > > the vector mode are not met. > > > > This patch puts the txq vector mode startup process after the > > condition detection. > > > > Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path") > > Cc: stable@dpdk.org > > > > Signed-off-by: Alvin Zhang > > --- > > drivers/net/ice/ice_rxtx.c | 16 +++++++++------- > > 1 file changed, 9 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c > > index > > 92fbbc1..49abcb2 100644 > > --- a/drivers/net/ice/ice_rxtx.c > > +++ b/drivers/net/ice/ice_rxtx.c > > @@ -3303,13 +3303,6 @@ > > if (tx_check_ret >=3D 0 && > > rte_vect_get_max_simd_bitwidth() >=3D RTE_VECT_SIMD_128) { > > ad->tx_vec_allowed =3D true; -for (i =3D 0; i < dev->data->nb_tx_queues= ; > > i++) { -txq =3D dev->data->tx_queues[i]; -if (txq && > > ice_txq_vec_setup(txq)) { > > -ad->tx_vec_allowed =3D false; > > -break; > > -} > > -} > > > > if (rte_vect_get_max_simd_bitwidth() >=3D > > RTE_VECT_SIMD_512 && > > rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) =3D=3D > > 1 && @@ -3329,6 +3322,15 @@ > > if (!use_avx512 && tx_check_ret =3D=3D > > ICE_VECTOR_OFFLOAD_PATH) > > ad->tx_vec_allowed =3D false; > > > > +if (ad->tx_vec_allowed) { > > +for (i =3D 0; i < dev->data->nb_tx_queues; i++) { txq =3D > > +dev->data->tx_queues[i]; if (txq && ice_txq_vec_setup(txq)) { > > +ad->tx_vec_allowed =3D false; > > +break; > > +} > > +} > > +} > > } else { > > ad->tx_vec_allowed =3D false; > > } > > -- > > 1.8.3.1 >=20 > Acked-by: Leyi Rong Applied to dpdk-next-net-intel. Thanks Qi