DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] vfio: remove unnecessary explicit type casting
@ 2020-09-16 12:41 wangyunjian
  2020-09-16 13:38 ` Burakov, Anatoly
  2020-10-05  8:13 ` David Marchand
  0 siblings, 2 replies; 4+ messages in thread
From: wangyunjian @ 2020-09-16 12:41 UTC (permalink / raw)
  To: dev; +Cc: anatoly.burakov, jerry.lilijun, xudingke, Yunjian Wang

From: Yunjian Wang <wangyunjian@huawei.com>

The variables 'vfio_res->nb_maps' and 'i' are of type int. The type
casting of 'vfio_res->nb_maps' is redundant and not required.

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
 drivers/bus/pci/linux/pci_vfio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/linux/pci_vfio.c
index c15ed3bad..85a51e3e2 100644
--- a/drivers/bus/pci/linux/pci_vfio.c
+++ b/drivers/bus/pci/linux/pci_vfio.c
@@ -750,7 +750,7 @@ pci_vfio_map_resource_primary(struct rte_pci_device *dev)
 		}
 	}
 
-	for (i = 0; i < (int) vfio_res->nb_maps; i++) {
+	for (i = 0; i < vfio_res->nb_maps; i++) {
 		struct vfio_region_info *reg = NULL;
 		void *bar_addr;
 
@@ -875,7 +875,7 @@ pci_vfio_map_resource_secondary(struct rte_pci_device *dev)
 	/* map BARs */
 	maps = vfio_res->maps;
 
-	for (i = 0; i < (int) vfio_res->nb_maps; i++) {
+	for (i = 0; i < vfio_res->nb_maps; i++) {
 		ret = pci_vfio_mmap_bar(vfio_dev_fd, vfio_res, i, MAP_FIXED);
 		if (ret < 0) {
 			RTE_LOG(ERR, EAL, "  %s mapping BAR%i failed: %s\n",
@@ -934,7 +934,7 @@ find_and_unmap_vfio_resource(struct mapped_pci_res_list *vfio_res_list,
 		pci_addr);
 
 	maps = vfio_res->maps;
-	for (i = 0; i < (int) vfio_res->nb_maps; i++) {
+	for (i = 0; i < vfio_res->nb_maps; i++) {
 
 		/*
 		 * We do not need to be aware of MSI-X table BAR mappings as
-- 
2.23.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] vfio: remove unnecessary explicit type casting
  2020-09-16 12:41 [dpdk-dev] [PATCH] vfio: remove unnecessary explicit type casting wangyunjian
@ 2020-09-16 13:38 ` Burakov, Anatoly
  2020-09-16 14:14   ` Burakov, Anatoly
  2020-10-05  8:13 ` David Marchand
  1 sibling, 1 reply; 4+ messages in thread
From: Burakov, Anatoly @ 2020-09-16 13:38 UTC (permalink / raw)
  To: wangyunjian, dev; +Cc: jerry.lilijun, xudingke

On 16-Sep-20 1:41 PM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> The variables 'vfio_res->nb_maps' and 'i' are of type int. The type
> casting of 'vfio_res->nb_maps' is redundant and not required.
> 
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---

I wonder if we should make vfio_res->nb_maps to be an unsigned int 
instead. I don't think we ever expect number of mappings to be negative...

-- 
Thanks,
Anatoly

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] vfio: remove unnecessary explicit type casting
  2020-09-16 13:38 ` Burakov, Anatoly
@ 2020-09-16 14:14   ` Burakov, Anatoly
  0 siblings, 0 replies; 4+ messages in thread
From: Burakov, Anatoly @ 2020-09-16 14:14 UTC (permalink / raw)
  To: wangyunjian, dev; +Cc: jerry.lilijun, xudingke

On 16-Sep-20 2:38 PM, Burakov, Anatoly wrote:
> On 16-Sep-20 1:41 PM, wangyunjian wrote:
>> From: Yunjian Wang <wangyunjian@huawei.com>
>>
>> The variables 'vfio_res->nb_maps' and 'i' are of type int. The type
>> casting of 'vfio_res->nb_maps' is redundant and not required.
>>
>> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>> ---
> 
> I wonder if we should make vfio_res->nb_maps to be an unsigned int 
> instead. I don't think we ever expect number of mappings to be negative...
> 

Just checked the code, this would be a big reword as there's lots of 
other places we do this, so for now i'm inclined to leave it be and 
remove the unnecessary casts instead. So,

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] vfio: remove unnecessary explicit type casting
  2020-09-16 12:41 [dpdk-dev] [PATCH] vfio: remove unnecessary explicit type casting wangyunjian
  2020-09-16 13:38 ` Burakov, Anatoly
@ 2020-10-05  8:13 ` David Marchand
  1 sibling, 0 replies; 4+ messages in thread
From: David Marchand @ 2020-10-05  8:13 UTC (permalink / raw)
  To: wangyunjian; +Cc: dev, Burakov, Anatoly, Lilijun (Jerry), xudingke

On Wed, Sep 16, 2020 at 2:42 PM wangyunjian <wangyunjian@huawei.com> wrote:
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> The variables 'vfio_res->nb_maps' and 'i' are of type int. The type
> casting of 'vfio_res->nb_maps' is redundant and not required.
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-10-05  8:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 12:41 [dpdk-dev] [PATCH] vfio: remove unnecessary explicit type casting wangyunjian
2020-09-16 13:38 ` Burakov, Anatoly
2020-09-16 14:14   ` Burakov, Anatoly
2020-10-05  8:13 ` David Marchand

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git