From: "Burakov, Anatoly" <anatoly.burakov@intel.com> To: Nithin Dabilpuram <ndabilpuram@marvell.com> Cc: jerinj@marvell.com, dev@dpdk.org, stable@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/3] vfio: fix DMA mapping granularity for type1 iova as va Date: Tue, 10 Nov 2020 14:22:45 +0000 Message-ID: <0b78852b-2647-4cfd-21fa-4a17142fdb78@intel.com> (raw) In-Reply-To: <89bd0363-7fbf-a1b0-4708-1511dd9cd81f@intel.com> On 10-Nov-20 2:04 PM, Burakov, Anatoly wrote: > On 05-Nov-20 9:04 AM, Nithin Dabilpuram wrote: >> Partial unmapping is not supported for VFIO IOMMU type1 >> by kernel. Though kernel gives return as zero, the unmapped size >> returned will not be same as expected. So check for >> returned unmap size and return error. >> >> For IOVA as PA, DMA mapping is already at memseg size >> granularity. Do the same even for IOVA as VA mode as >> DMA map/unmap triggered by heap allocations, >> maintain granularity of memseg page size so that heap >> expansion and contraction does not have this issue. >> >> For user requested DMA map/unmap disallow partial unmapping >> for VFIO type1. >> >> Fixes: 73a639085938 ("vfio: allow to map other memory regions") >> Cc: anatoly.burakov@intel.com >> Cc: stable@dpdk.org >> >> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com> >> --- > > Maybe i just didn't have enough coffee today, but i still don't see why > this "partial unmap" thing exists. Oh, right, this is for *user* mapped memory. Disregard this email. > > We are already mapping the addresses page-by-page, so surely "partial" > unmaps can't even exist in the first place? > -- Thanks, Anatoly
next prev parent reply other threads:[~2020-11-10 14:22 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-12 8:11 [dpdk-dev] [PATCH 0/2] fix issue with partial DMA unmap Nithin Dabilpuram 2020-10-12 8:11 ` [dpdk-dev] [PATCH 1/2] test: add test case to validate VFIO DMA map/unmap Nithin Dabilpuram 2020-10-14 14:39 ` Burakov, Anatoly 2020-10-15 9:54 ` [dpdk-dev] [EXT] " Nithin Dabilpuram 2020-10-12 8:11 ` [dpdk-dev] [PATCH 2/2] vfio: fix partial DMA unmapping for VFIO type1 Nithin Dabilpuram 2020-10-14 15:07 ` Burakov, Anatoly 2020-10-15 6:09 ` [dpdk-dev] [EXT] " Nithin Dabilpuram 2020-10-15 10:00 ` Burakov, Anatoly 2020-10-15 11:38 ` Nithin Dabilpuram 2020-10-15 11:50 ` Nithin Dabilpuram 2020-10-15 11:57 ` Nithin Dabilpuram 2020-10-15 15:10 ` Burakov, Anatoly 2020-10-16 7:10 ` Nithin Dabilpuram 2020-10-17 16:14 ` Burakov, Anatoly 2020-10-19 9:43 ` Nithin Dabilpuram 2020-10-22 12:13 ` Nithin Dabilpuram 2020-10-28 13:04 ` Burakov, Anatoly 2020-10-28 14:17 ` Nithin Dabilpuram 2020-10-28 16:07 ` Burakov, Anatoly 2020-10-28 16:31 ` Nithin Dabilpuram 2020-11-05 9:04 ` [dpdk-dev] [PATCH v2 0/3] fix issue with partial DMA unmap Nithin Dabilpuram 2020-11-05 9:04 ` [dpdk-dev] [PATCH v2 1/3] vfio: revert changes for map contiguous areas in one go Nithin Dabilpuram 2020-11-05 9:04 ` [dpdk-dev] [PATCH v2 2/3] vfio: fix DMA mapping granularity for type1 iova as va Nithin Dabilpuram 2020-11-10 14:04 ` Burakov, Anatoly 2020-11-10 14:22 ` Burakov, Anatoly [this message] 2020-11-10 14:17 ` Burakov, Anatoly 2020-11-11 5:08 ` Nithin Dabilpuram 2020-11-11 10:00 ` Burakov, Anatoly 2020-11-05 9:04 ` [dpdk-dev] [PATCH v2 3/3] test: add test case to validate VFIO DMA map/unmap Nithin Dabilpuram 2020-12-01 19:32 ` [dpdk-dev] [PATCH v3 0/4] fix issue with partial DMA unmap Nithin Dabilpuram 2020-12-01 19:32 ` [dpdk-dev] [PATCH v3 1/4] vfio: revert changes for map contiguous areas in one go Nithin Dabilpuram 2020-12-01 19:33 ` [dpdk-dev] [PATCH v3 2/4] vfio: fix DMA mapping granularity for type1 IOVA as VA Nithin Dabilpuram 2020-12-01 19:33 ` [dpdk-dev] [PATCH v3 3/4] test: add test case to validate VFIO DMA map/unmap Nithin Dabilpuram 2020-12-01 19:33 ` [dpdk-dev] [PATCH v3 4/4] test: change external memory test to use system page sz Nithin Dabilpuram 2020-12-01 23:23 ` David Christensen 2020-12-02 5:40 ` Nithin Dabilpuram 2020-12-02 5:46 ` [dpdk-dev] [PATCH v4 0/4] fix issue with partial DMA unmap Nithin Dabilpuram 2020-12-02 5:46 ` [dpdk-dev] [PATCH v4 1/4] vfio: revert changes for map contiguous areas in one go Nithin Dabilpuram 2020-12-02 18:36 ` David Christensen 2020-12-02 5:46 ` [dpdk-dev] [PATCH v4 2/4] vfio: fix DMA mapping granularity for type1 IOVA as VA Nithin Dabilpuram 2020-12-02 18:38 ` David Christensen 2020-12-02 5:46 ` [dpdk-dev] [PATCH v4 3/4] test: add test case to validate VFIO DMA map/unmap Nithin Dabilpuram 2020-12-02 19:23 ` David Christensen 2020-12-03 7:14 ` Nithin Dabilpuram 2020-12-14 8:24 ` Nithin Dabilpuram 2020-12-02 5:46 ` [dpdk-dev] [PATCH v4 4/4] test: change external memory test to use system page sz Nithin Dabilpuram 2020-12-14 8:19 ` [dpdk-dev] [PATCH v5 0/4] fix issue with partial DMA unmap Nithin Dabilpuram 2020-12-14 8:19 ` [dpdk-dev] [PATCH v5 1/4] vfio: revert changes for map contiguous areas in one go Nithin Dabilpuram 2020-12-14 8:19 ` [dpdk-dev] [PATCH v5 2/4] vfio: fix DMA mapping granularity for type1 IOVA as VA Nithin Dabilpuram 2020-12-14 8:19 ` [dpdk-dev] [PATCH v5 3/4] test: add test case to validate VFIO DMA map/unmap Nithin Dabilpuram 2020-12-14 8:19 ` [dpdk-dev] [PATCH v5 4/4] test: change external memory test to use system page sz Nithin Dabilpuram 2020-12-17 19:06 ` [dpdk-dev] [PATCH v6 0/4] fix issue with partial DMA unmap Nithin Dabilpuram 2020-12-17 19:06 ` [dpdk-dev] [PATCH v6 1/4] vfio: revert changes for map contiguous areas in one go Nithin Dabilpuram 2020-12-17 19:06 ` [dpdk-dev] [PATCH v6 2/4] vfio: fix DMA mapping granularity for type1 IOVA as VA Nithin Dabilpuram 2020-12-17 19:06 ` [dpdk-dev] [PATCH v6 3/4] test: add test case to validate VFIO DMA map/unmap Nithin Dabilpuram 2020-12-17 19:10 ` Nithin Dabilpuram 2021-01-05 19:33 ` David Christensen 2021-01-06 8:40 ` Nithin Dabilpuram 2021-01-06 21:20 ` David Christensen 2020-12-17 19:06 ` [dpdk-dev] [PATCH v6 4/4] test: change external memory test to use system page sz Nithin Dabilpuram 2020-12-23 5:13 ` [dpdk-dev] [PATCH v6 0/4] fix issue with partial DMA unmap Nithin Dabilpuram 2021-01-04 22:29 ` David Christensen 2021-01-12 17:39 ` [dpdk-dev] [PATCH v7 0/3] " Nithin Dabilpuram 2021-01-12 17:39 ` [dpdk-dev] [PATCH v7 1/3] vfio: revert changes for map contiguous areas in one go Nithin Dabilpuram 2021-01-12 17:39 ` [dpdk-dev] [PATCH v7 2/3] vfio: fix DMA mapping granularity for type1 IOVA as VA Nithin Dabilpuram 2021-01-12 17:39 ` [dpdk-dev] [PATCH v7 3/3] test: change external memory test to use system page sz Nithin Dabilpuram 2021-01-14 16:30 ` David Marchand 2021-01-15 6:57 ` Nithin Dabilpuram 2021-01-15 7:32 ` [dpdk-dev] [PATCH v8 0/3] fix issue with partial DMA unmap Nithin Dabilpuram 2021-01-15 7:32 ` [dpdk-dev] [PATCH v8 1/3] vfio: revert changes for map contiguous areas in one go Nithin Dabilpuram 2021-01-15 7:32 ` [dpdk-dev] [PATCH v8 2/3] vfio: fix DMA mapping granularity for type1 IOVA as VA Nithin Dabilpuram 2021-01-15 7:32 ` [dpdk-dev] [PATCH v8 3/3] test: change external memory test to use system page sz Nithin Dabilpuram
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0b78852b-2647-4cfd-21fa-4a17142fdb78@intel.com \ --to=anatoly.burakov@intel.com \ --cc=dev@dpdk.org \ --cc=jerinj@marvell.com \ --cc=ndabilpuram@marvell.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git