From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E49F72B8C for ; Thu, 9 Mar 2017 15:26:15 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2017 06:26:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,268,1486454400"; d="scan'208";a="1120469865" Received: from hharchan-mobl.gar.corp.intel.com (HELO [10.254.187.207]) ([10.254.187.207]) by fmsmga001.fm.intel.com with ESMTP; 09 Mar 2017 06:26:09 -0800 To: Pascal Mazon , keith.wiles@intel.com References: <1488904298-31395-6-git-send-email-pascal.mazon@6wind.com> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: <0b7941e9-c930-954e-d9ca-5b876e2a0038@intel.com> Date: Thu, 9 Mar 2017 14:26:08 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1488904298-31395-6-git-send-email-pascal.mazon@6wind.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 5/6] net/tap: add packet type management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 14:26:16 -0000 On 3/7/2017 4:31 PM, Pascal Mazon wrote: > Advertize RTE_PTYPE_UNKNOWN since tap does not report any packet type. > > Signed-off-by: Pascal Mazon > --- > doc/guides/nics/features/tap.ini | 1 + > drivers/net/tap/rte_eth_tap.c | 15 +++++++++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics/features/tap.ini > index 6aa11874e2bc..7f3f4d661dd7 100644 > --- a/doc/guides/nics/features/tap.ini > +++ b/doc/guides/nics/features/tap.ini > @@ -13,6 +13,7 @@ MTU update = Y > Multicast MAC filter = Y > Speed capabilities = Y > Unicast MAC filter = Y > +Packet type parsing = Y > Other kdrv = Y > ARMv7 = Y > ARMv8 = Y > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index d76f1dc83b03..edb5d2a82f12 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -36,6 +36,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -216,6 +217,8 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) > mbuf->data_len = len; > mbuf->pkt_len = len; > mbuf->port = rxq->in_port; > + mbuf->packet_type = rte_net_get_ptype(mbuf, NULL, > + RTE_PTYPE_ALL_MASK); Isn't PMD become inconsistent with this update. It reports RTE_PTYPE_UNKNOWN, but sets mbuf->packet_type with various ptype. Do we want software packet type parsing in PMD level? Any change some users may not interested with this data at all. > > /* account for the receive frame */ > bufs[num_rx++] = mbuf; > @@ -769,6 +772,17 @@ tap_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) > return 0; > } > > +static const uint32_t* > +tap_dev_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused) > +{ > + static const uint32_t ptypes[] = { > + RTE_PTYPE_UNKNOWN, > + > + }; > + > + return ptypes; > +} > + > static const struct eth_dev_ops ops = { > .dev_start = tap_dev_start, > .dev_stop = tap_dev_stop, > @@ -793,6 +807,7 @@ static const struct eth_dev_ops ops = { > .mtu_set = tap_mtu_set, > .stats_get = tap_stats_get, > .stats_reset = tap_stats_reset, > + .dev_supported_ptypes_get = tap_dev_supported_ptypes_get, > }; > > static int >