From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 734E4A04B1; Tue, 24 Nov 2020 14:02:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4FE97C936; Tue, 24 Nov 2020 14:02:11 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 02BE5C90E for ; Tue, 24 Nov 2020 14:02:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606222926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xTVlWQ8No6eXDSyuIPh+AVmqSePQ9jUg+i2V+rPASDU=; b=ScUqOE/MP8+Vzqigf2cganhw9iWiDs4VbptaREl+QBEA/AyVun9Fse7+fG859dg1fXju+4 ApEDTRsgbFAvgs1rlfkNzDQ742hDpHL5VvzQWu069QUn2GH6tkHOZSav2BarCFXhHrdtHL GWepLaf/6LG3iZdUcK5WPDWzA6ANrHA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-377-yeCMd0jmMd-sQlW7mZZCWg-1; Tue, 24 Nov 2020 08:02:04 -0500 X-MC-Unique: yeCMd0jmMd-sQlW7mZZCWg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 17ABA87953B; Tue, 24 Nov 2020 13:02:03 +0000 (UTC) Received: from [10.36.112.19] (ovpn-112-19.ams2.redhat.com [10.36.112.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 63F215C1A3; Tue, 24 Nov 2020 13:02:00 +0000 (UTC) To: Ferruh Yigit , Thomas Monjalon , "Wei Hu (Xavier)" Cc: "dev@dpdk.org" , "xavier.huwei@huawei.com" , Slava Ovsiienko , Luca Boccassi References: <20200818120254.72792-1-huwei013@chinasoftinc.com> <20200925124719.26001-4-huwei013@chinasoftinc.com> <3600731.79S79Y1HSu@thomas> From: Kevin Traynor Message-ID: <0bbd9f27-1d0d-2a6d-17f5-993603a0fdb6@redhat.com> Date: Tue, 24 Nov 2020 13:01:59 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 3/6] app/testpmd: remove restriction on txpkts set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 24/11/2020 12:23, Ferruh Yigit wrote: > On 11/24/2020 10:27 AM, Thomas Monjalon wrote: >> Is it OK to keep this regression? >> >> Ferruh, what do you suggest? >> > > I confirm the '--txpkts' parameter is broken now, I suggest submitting a defect > for it and continue with the regression. > > We have alternative for the parameter, "set txpkts " command. > The parameter was only working when hardcoded '--txd=N' parameter is provided, > the command is more dynamic and works however queue size is configured. > > We can fix the '--txpkts' in next release. > For LTS, I will revert from 18.11 branch as I don't want to add a regression on last 18.11 LTS release. +cc Luca for 19.11 >> >> 23/11/2020 12:50, Slava Ovsiienko: >>> Hi, Wei >>> >>> It was found this patch rejects the --txpkts command line settings. >>> set_tx_pkt_segments() is called before device started and >>> we have failure chain: >>> >>> set_tx_pkt_segments() >>> nb_segs_is_invalid() >>> get_tx_ring_size () >>> rte_eth_tx_queue_info_get() >>> >>> It causes --txpkts testpmd command line option is ignored. >>> >>> With best regards, Slava >>> >>>> -----Original Message----- >>>> From: dev On Behalf Of Wei Hu (Xavier) >>>> Sent: Friday, September 25, 2020 15:47 >>>> To: dev@dpdk.org >>>> Cc: xavier.huwei@huawei.com >>>> Subject: [dpdk-dev] [PATCH v4 3/6] app/testpmd: remove restriction on txpkts >>>> set >>>> >>>> From: Chengchang Tang >>>> >>>> Currently, if nb_txd is not set, the txpkts is not allowed to be set because the >>>> nb_txd is used to avoid the numer of segments exceed the Tx ring size and the >>>> default value of nb_txd is 0. And there is a bug that nb_txd is the global >>>> configuration for Tx ring size and the ring size could be changed by some >>>> command per queue. So these valid check is unreliable and introduced >>>> unnecessary constraints. >>>> >>>> This patch adds a valid check function to use the real Tx ring size to check the >>>> validity of txpkts. >>>> >>>> Fixes: af75078fece3 ("first public release") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Chengchang Tang >>>> Signed-off-by: Wei Hu (Xavier) >>>> --- >>>> v3 -> v4: >>>> add check 'rte_eth_rx_queue_info_get()' return value and >>>> if it is '-ENOSTUP' calculate the 'ring_size'. >>>> v3: initial version. >>>> --- >>>> app/test-pmd/config.c | 64 >>>> +++++++++++++++++++++++++++++++++++++++++++++++---- >>>> 1 file changed, 60 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index >>>> 6496d2f..8ebb927 100644 >>>> --- a/app/test-pmd/config.c >>>> +++ b/app/test-pmd/config.c >>>> @@ -1893,6 +1893,38 @@ tx_queue_id_is_invalid(queueid_t txq_id) } >>>> >>>> static int >>>> +get_tx_ring_size(portid_t port_id, queueid_t txq_id, uint16_t >>>> +*ring_size) { >>>> + struct rte_port *port = &ports[port_id]; >>>> + struct rte_eth_txq_info tx_qinfo; >>>> + int ret; >>>> + >>>> + ret = rte_eth_tx_queue_info_get(port_id, txq_id, &tx_qinfo); >>>> + if (ret == 0) { >>>> + *ring_size = tx_qinfo.nb_desc; >>>> + return ret; >>>> + } >>>> + >>>> + if (ret != -ENOTSUP) >>>> + return ret; >>>> + /* >>>> + * If the rte_eth_tx_queue_info_get is not support for this PMD, >>>> + * ring_size stored in testpmd will be used for validity verification. >>>> + * When configure the txq by rte_eth_tx_queue_setup with >>>> nb_tx_desc >>>> + * being 0, it will use a default value provided by PMDs to setup this >>>> + * txq. If the default value is 0, it will use the >>>> + * RTE_ETH_DEV_FALLBACK_TX_RINGSIZE to setup this txq. >>>> + */ >>>> + if (port->nb_tx_desc[txq_id]) >>>> + *ring_size = port->nb_tx_desc[txq_id]; >>>> + else if (port->dev_info.default_txportconf.ring_size) >>>> + *ring_size = port->dev_info.default_txportconf.ring_size; >>>> + else >>>> + *ring_size = RTE_ETH_DEV_FALLBACK_TX_RINGSIZE; >>>> + return 0; >>>> +} >>>> + >>>> +static int >>>> rx_desc_id_is_invalid(uint16_t rxdesc_id) { >>>> if (rxdesc_id < nb_rxd) >>>> @@ -2986,17 +3018,41 @@ show_tx_pkt_segments(void) >>>> printf("Split packet: %s\n", split); >>>> } >>>> >>>> +static bool >>>> +nb_segs_is_invalid(unsigned int nb_segs) { >>>> + uint16_t ring_size; >>>> + uint16_t queue_id; >>>> + uint16_t port_id; >>>> + int ret; >>>> + >>>> + RTE_ETH_FOREACH_DEV(port_id) { >>>> + for (queue_id = 0; queue_id < nb_txq; queue_id++) { >>>> + ret = get_tx_ring_size(port_id, queue_id, &ring_size); >>>> + >>>> + if (ret) >>>> + return true; >>>> + >>>> + if (ring_size < nb_segs) { >>>> + printf("nb segments per TX packets=%u >= " >>>> + "TX queue(%u) ring_size=%u - ignored\n", >>>> + nb_segs, queue_id, ring_size); >>>> + return true; >>>> + } >>>> + } >>>> + } >>>> + >>>> + return false; >>>> +} >>>> + >>>> void >>>> set_tx_pkt_segments(unsigned *seg_lengths, unsigned nb_segs) { >>>> uint16_t tx_pkt_len; >>>> unsigned i; >>>> >>>> - if (nb_segs >= (unsigned) nb_txd) { >>>> - printf("nb segments per TX packets=%u >= nb_txd=%u - >>>> ignored\n", >>>> - nb_segs, (unsigned int) nb_txd); >>>> + if (nb_segs_is_invalid(nb_segs)) >>>> return; >>>> - } >>>> >>>> /* >>>> * Check that each segment length is greater or equal than >>>> -- >>>> 2.9.5 >>> >>> >> >> >> >> >> >