From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34A89A04C8; Fri, 18 Sep 2020 19:53:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9ECA01DB05; Fri, 18 Sep 2020 19:53:37 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 671A51D517 for ; Fri, 18 Sep 2020 19:53:36 +0200 (CEST) IronPort-SDR: GrG8NlivrA2qPf2tA9pKqXlCySwLGrxfY5YIjD5BORDsUQfqHmdyxDxCOTBMnHjLs9oaYM1XF4 /sx18b3E2hpA== X-IronPort-AV: E=McAfee;i="6000,8403,9748"; a="157395775" X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="157395775" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 10:53:34 -0700 IronPort-SDR: HiPeR0RTqsaTRVnERjyITn/2IfqEJuv+yOY3u0e8NNqDLulSt8QW8Jc7GgNdQwysukjsl57lxH cDcl+FCeANyw== X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="484297362" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.248]) ([10.213.227.248]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 10:53:27 -0700 To: i.dyukov@samsung.com, dev@dpdk.org, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> <20200915190728.18143-9-i.dyukov@samsung.com> From: Ferruh Yigit Message-ID: <0bd39787-867c-67ba-1c85-c22a201d6d0c@intel.com> Date: Fri, 18 Sep 2020 18:53:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200915190728.18143-9-i.dyukov@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v11 08/24] examples/bbdev_app: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/15/2020 8:07 PM, Ivan Dyukov wrote: > Add usage of rte_eth_link_to_str function to example > applications > > Signed-off-by: Ivan Dyukov > --- > examples/bbdev_app/main.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c > index 68a46050c..fe9d8e0a5 100644 > --- a/examples/bbdev_app/main.c > +++ b/examples/bbdev_app/main.c > @@ -326,8 +326,10 @@ check_port_link_status(uint16_t port_id) > const char *dp = (link.link_duplex == > ETH_LINK_FULL_DUPLEX) ? > "full-duplex" : "half-duplex"; > - printf("\nPort %u Link Up - speed %u Mbps - %s\n", > - port_id, link.link_speed, dp); > + printf("\nPort %u Link Up - speed %s Mbps - %s\n", > + port_id, > + rte_eth_link_speed_to_str(link.link_speed), > + dp); Can drop " Mbps" part since 'rte_eth_link_speed_to_str()' returns string with it. If the the required changes are minor changes like this, I can update them while merging, let me comment on them first.