DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] vhost: add log print of socket path on adding connection
@ 2021-09-04 14:28 Gaoxiang Liu
  2021-09-06  5:35 ` Xia, Chenbo
  2021-09-07  0:51 ` [dpdk-dev] [PATCH v2] " Gaoxiang Liu
  0 siblings, 2 replies; 12+ messages in thread
From: Gaoxiang Liu @ 2021-09-04 14:28 UTC (permalink / raw)
  To: maxime.coquelin, chenbo.xia; +Cc: dev, liugaoxiang, Gaoxiang Liu, stable

Add log print of socket path in vhost_user_add_connection.
It's useful when adding a mass of socket connections,
because the information of every connection is more clearer.

Fixes: a277c7159876 ("vhost: refactor code structure")
Cc: stable@dpdk.org

Signed-off-by: Gaoxiang Liu <liugaoxiang@huawei.com>
---
 lib/vhost/socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
index d6f9414c4..c6548608a 100644
--- a/lib/vhost/socket.c
+++ b/lib/vhost/socket.c
@@ -243,7 +243,7 @@ vhost_user_add_connection(int fd, struct vhost_user_socket *vsocket)
 			dev->async_copy = 1;
 	}
 
-	VHOST_LOG_CONFIG(INFO, "new device, handle is %d\n", vid);
+	VHOST_LOG_CONFIG(INFO, "new device, handle is %d, path is %s\n", vid, vsocket->path);
 
 	if (vsocket->notify_ops->new_connection) {
 		ret = vsocket->notify_ops->new_connection(vid);
-- 
2.32.0



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH] vhost: add log print of socket path on adding connection
  2021-09-04 14:28 [dpdk-dev] [PATCH] vhost: add log print of socket path on adding connection Gaoxiang Liu
@ 2021-09-06  5:35 ` Xia, Chenbo
  2021-09-07  0:47   ` Gaoxiang Liu
  2021-09-07  0:51 ` [dpdk-dev] [PATCH v2] " Gaoxiang Liu
  1 sibling, 1 reply; 12+ messages in thread
From: Xia, Chenbo @ 2021-09-06  5:35 UTC (permalink / raw)
  To: Gaoxiang Liu, maxime.coquelin; +Cc: dev, liugaoxiang, stable

Hi Gaoxiang,

> -----Original Message-----
> From: Gaoxiang Liu <gaoxiangliu0@163.com>
> Sent: Saturday, September 4, 2021 10:28 PM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; liugaoxiang@huawei.com; Gaoxiang Liu <gaoxiangliu0@163.com>;
> stable@dpdk.org
> Subject: [PATCH] vhost: add log print of socket path on adding connection
> 
> Add log print of socket path in vhost_user_add_connection.
> It's useful when adding a mass of socket connections,
> because the information of every connection is more clearer.

More clearer -> clearer

> 
> Fixes: a277c7159876 ("vhost: refactor code structure")

I think it should be this commit:

8f972312b8f4 ("vhost: support vhost-user")

> Cc: stable@dpdk.org
> 
> Signed-off-by: Gaoxiang Liu <liugaoxiang@huawei.com>

Do you have issue sending with this email address? If not, please use
the same for one commit.

And please use 'Plain Text' when replying comments. I noticed you are
using HTML for other patches, which is not suggested.

Thanks,
Chenbo

> ---
>  lib/vhost/socket.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
> index d6f9414c4..c6548608a 100644
> --- a/lib/vhost/socket.c
> +++ b/lib/vhost/socket.c
> @@ -243,7 +243,7 @@ vhost_user_add_connection(int fd, struct vhost_user_socket
> *vsocket)
>  			dev->async_copy = 1;
>  	}
> 
> -	VHOST_LOG_CONFIG(INFO, "new device, handle is %d\n", vid);
> +	VHOST_LOG_CONFIG(INFO, "new device, handle is %d, path is %s\n", vid,
> vsocket->path);
> 
>  	if (vsocket->notify_ops->new_connection) {
>  		ret = vsocket->notify_ops->new_connection(vid);
> --
> 2.32.0
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH] vhost: add log print of socket path on adding connection
  2021-09-06  5:35 ` Xia, Chenbo
@ 2021-09-07  0:47   ` Gaoxiang Liu
  0 siblings, 0 replies; 12+ messages in thread
From: Gaoxiang Liu @ 2021-09-07  0:47 UTC (permalink / raw)
  To: Xia, Chenbo; +Cc: maxime.coquelin, dev, liugaoxiang, stable

Hi chenbo,
I will fix the issues in [PATCH v2].


Thanks.
Gaoxiang.

At 2021-09-06 13:35:23, "Xia, Chenbo" <chenbo.xia@intel.com> wrote:
>Hi Gaoxiang,
>
>> -----Original Message-----
>> From: Gaoxiang Liu <gaoxiangliu0@163.com>
>> Sent: Saturday, September 4, 2021 10:28 PM
>> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
>> Cc: dev@dpdk.org; liugaoxiang@huawei.com; Gaoxiang Liu <gaoxiangliu0@163.com>;
>> stable@dpdk.org
>> Subject: [PATCH] vhost: add log print of socket path on adding connection
>> 
>> Add log print of socket path in vhost_user_add_connection.
>> It's useful when adding a mass of socket connections,
>> because the information of every connection is more clearer.
>
>More clearer -> clearer
>
>> 
>> Fixes: a277c7159876 ("vhost: refactor code structure")
>
>I think it should be this commit:
>
>8f972312b8f4 ("vhost: support vhost-user")
>
>> Cc: stable@dpdk.org
>> 
>> Signed-off-by: Gaoxiang Liu <liugaoxiang@huawei.com>
>
>Do you have issue sending with this email address? If not, please use
>the same for one commit.
>
>And please use 'Plain Text' when replying comments. I noticed you are
>using HTML for other patches, which is not suggested.
>
>Thanks,
>Chenbo
>
>> ---
>>  lib/vhost/socket.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
>> index d6f9414c4..c6548608a 100644
>> --- a/lib/vhost/socket.c
>> +++ b/lib/vhost/socket.c
>> @@ -243,7 +243,7 @@ vhost_user_add_connection(int fd, struct vhost_user_socket
>> *vsocket)
>>  			dev->async_copy = 1;
>>  	}
>> 
>> -	VHOST_LOG_CONFIG(INFO, "new device, handle is %d\n", vid);
>> +	VHOST_LOG_CONFIG(INFO, "new device, handle is %d, path is %s\n", vid,
>> vsocket->path);
>> 
>>  	if (vsocket->notify_ops->new_connection) {
>>  		ret = vsocket->notify_ops->new_connection(vid);
>> --
>> 2.32.0
>> 
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [dpdk-dev] [PATCH v2] vhost: add log print of socket path on adding connection
  2021-09-04 14:28 [dpdk-dev] [PATCH] vhost: add log print of socket path on adding connection Gaoxiang Liu
  2021-09-06  5:35 ` Xia, Chenbo
@ 2021-09-07  0:51 ` Gaoxiang Liu
  2021-09-07  1:35   ` Xia, Chenbo
  2021-09-14 11:30   ` Maxime Coquelin
  1 sibling, 2 replies; 12+ messages in thread
From: Gaoxiang Liu @ 2021-09-07  0:51 UTC (permalink / raw)
  To: maxime.coquelin, chenbo.xia; +Cc: dev, liugaoxiang, Gaoxiang Liu, stable

Add log print of socket path in vhost_user_add_connection.
It's useful when adding a mass of socket connections,
because the information of every connection is clearer.

Fixes: 8f972312b8f4 ("vhost: support vhost-user")
Cc: stable@dpdk.org

Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
---
 lib/vhost/socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
index d6f9414c4..c6548608a 100644
--- a/lib/vhost/socket.c
+++ b/lib/vhost/socket.c
@@ -243,7 +243,7 @@ vhost_user_add_connection(int fd, struct vhost_user_socket *vsocket)
 			dev->async_copy = 1;
 	}
 
-	VHOST_LOG_CONFIG(INFO, "new device, handle is %d\n", vid);
+	VHOST_LOG_CONFIG(INFO, "new device, handle is %d, path is %s\n", vid, vsocket->path);
 
 	if (vsocket->notify_ops->new_connection) {
 		ret = vsocket->notify_ops->new_connection(vid);
-- 
2.32.0



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v2] vhost: add log print of socket path on adding connection
  2021-09-07  0:51 ` [dpdk-dev] [PATCH v2] " Gaoxiang Liu
@ 2021-09-07  1:35   ` Xia, Chenbo
  2021-09-14 11:30   ` Maxime Coquelin
  1 sibling, 0 replies; 12+ messages in thread
From: Xia, Chenbo @ 2021-09-07  1:35 UTC (permalink / raw)
  To: Gaoxiang Liu, maxime.coquelin; +Cc: dev, liugaoxiang, stable

> -----Original Message-----
> From: Gaoxiang Liu <gaoxiangliu0@163.com>
> Sent: Tuesday, September 7, 2021 8:51 AM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; liugaoxiang@huawei.com; Gaoxiang Liu <gaoxiangliu0@163.com>;
> stable@dpdk.org
> Subject: [PATCH v2] vhost: add log print of socket path on adding connection
> 
> Add log print of socket path in vhost_user_add_connection.
> It's useful when adding a mass of socket connections,
> because the information of every connection is clearer.
> 
> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
> ---
>  lib/vhost/socket.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
> index d6f9414c4..c6548608a 100644
> --- a/lib/vhost/socket.c
> +++ b/lib/vhost/socket.c
> @@ -243,7 +243,7 @@ vhost_user_add_connection(int fd, struct vhost_user_socket
> *vsocket)
>  			dev->async_copy = 1;
>  	}
> 
> -	VHOST_LOG_CONFIG(INFO, "new device, handle is %d\n", vid);
> +	VHOST_LOG_CONFIG(INFO, "new device, handle is %d, path is %s\n", vid,
> vsocket->path);
> 
>  	if (vsocket->notify_ops->new_connection) {
>  		ret = vsocket->notify_ops->new_connection(vid);
> --
> 2.32.0
> 

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v2] vhost: add log print of socket path on adding connection
  2021-09-07  0:51 ` [dpdk-dev] [PATCH v2] " Gaoxiang Liu
  2021-09-07  1:35   ` Xia, Chenbo
@ 2021-09-14 11:30   ` Maxime Coquelin
  2021-09-16 12:28     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
  1 sibling, 1 reply; 12+ messages in thread
From: Maxime Coquelin @ 2021-09-14 11:30 UTC (permalink / raw)
  To: Gaoxiang Liu, chenbo.xia; +Cc: dev, liugaoxiang, stable



On 9/7/21 2:51 AM, Gaoxiang Liu wrote:
> Add log print of socket path in vhost_user_add_connection.
> It's useful when adding a mass of socket connections,
> because the information of every connection is clearer.
> 
> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
> ---
>  lib/vhost/socket.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 


Applied to dpdk-next-virtio/main.

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: add log print of socket path on adding connection
  2021-09-14 11:30   ` Maxime Coquelin
@ 2021-09-16 12:28     ` Ferruh Yigit
  2021-09-16 12:33       ` Maxime Coquelin
  0 siblings, 1 reply; 12+ messages in thread
From: Ferruh Yigit @ 2021-09-16 12:28 UTC (permalink / raw)
  To: Maxime Coquelin, Gaoxiang Liu, chenbo.xia
  Cc: dev, liugaoxiang, stable, Thomas Monjalon

On 9/14/2021 12:30 PM, Maxime Coquelin wrote:
> 
> 
> On 9/7/21 2:51 AM, Gaoxiang Liu wrote:
>> Add log print of socket path in vhost_user_add_connection.
>> It's useful when adding a mass of socket connections,
>> because the information of every connection is clearer.
>>
>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
>> ---
>>  lib/vhost/socket.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> 
> Applied to dpdk-next-virtio/main.
> 


Hi Gaoxiang,

I can see you are in the git history as:
"Gaoxiang Liu <liugaoxiang@huawei.com>"

Since we are trying to keep unique identity in the git history, I will use the
one in the git history. Please let us know if that is problem.

And is there any specific reason to use two different emails?

Thanks,
ferruh

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: add log print of socket path on adding connection
  2021-09-16 12:28     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2021-09-16 12:33       ` Maxime Coquelin
  2021-09-16 12:37         ` Xia, Chenbo
  0 siblings, 1 reply; 12+ messages in thread
From: Maxime Coquelin @ 2021-09-16 12:33 UTC (permalink / raw)
  To: Ferruh Yigit, Gaoxiang Liu, chenbo.xia
  Cc: dev, liugaoxiang, stable, Thomas Monjalon



On 9/16/21 14:28, Ferruh Yigit wrote:
> On 9/14/2021 12:30 PM, Maxime Coquelin wrote:
>>
>>
>> On 9/7/21 2:51 AM, Gaoxiang Liu wrote:
>>> Add log print of socket path in vhost_user_add_connection.
>>> It's useful when adding a mass of socket connections,
>>> because the information of every connection is clearer.
>>>
>>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
>>> ---
>>>   lib/vhost/socket.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>
>>
>> Applied to dpdk-next-virtio/main.
>>
> 
> 
> Hi Gaoxiang,
> 
> I can see you are in the git history as:
> "Gaoxiang Liu <liugaoxiang@huawei.com>"
> 
> Since we are trying to keep unique identity in the git history, I will use the
> one in the git history. Please let us know if that is problem.

I fixed up the Author field in my pull request to match the SoB.
Did I miss something?

Thanks,
Maxime

> And is there any specific reason to use two different emails?


> Thanks,
> ferruh
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: add log print of socket path on adding connection
  2021-09-16 12:33       ` Maxime Coquelin
@ 2021-09-16 12:37         ` Xia, Chenbo
  2021-09-16 12:57           ` Ferruh Yigit
  0 siblings, 1 reply; 12+ messages in thread
From: Xia, Chenbo @ 2021-09-16 12:37 UTC (permalink / raw)
  To: Maxime Coquelin, Yigit, Ferruh, Gaoxiang Liu
  Cc: dev, liugaoxiang, stable, Thomas Monjalon

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Thursday, September 16, 2021 8:33 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Gaoxiang Liu
> <gaoxiangliu0@163.com>; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; liugaoxiang@huawei.com; stable@dpdk.org; Thomas Monjalon
> <thomas@monjalon.net>
> Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of socket path on
> adding connection
> 
> 
> 
> On 9/16/21 14:28, Ferruh Yigit wrote:
> > On 9/14/2021 12:30 PM, Maxime Coquelin wrote:
> >>
> >>
> >> On 9/7/21 2:51 AM, Gaoxiang Liu wrote:
> >>> Add log print of socket path in vhost_user_add_connection.
> >>> It's useful when adding a mass of socket connections,
> >>> because the information of every connection is clearer.
> >>>
> >>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
> >>> Cc: stable@dpdk.org
> >>>
> >>> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
> >>> ---
> >>>   lib/vhost/socket.c | 2 +-
> >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>
> >>
> >> Applied to dpdk-next-virtio/main.
> >>
> >
> >
> > Hi Gaoxiang,
> >
> > I can see you are in the git history as:
> > "Gaoxiang Liu <liugaoxiang@huawei.com>"
> >
> > Since we are trying to keep unique identity in the git history, I will use
> the
> > one in the git history. Please let us know if that is problem.
> 
> I fixed up the Author field in my pull request to match the SoB.
> Did I miss something?

History is Gaoxiang uses @163 email to send patches but signed-off with @huawei email,
So I told him to align and Maxime to fix when applying. Maybe it's my bad about not
being clear about which to use because it happens several times Gaoxiang uses two emails.

I notice people from Huawei sometimes use two emails for author and SOB tag.
So I have the same question :)

/Chenbo

> 
> Thanks,
> Maxime
> 
> > And is there any specific reason to use two different emails?
> 
> 
> > Thanks,
> > ferruh
> >


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: add log print of socket path on adding connection
  2021-09-16 12:37         ` Xia, Chenbo
@ 2021-09-16 12:57           ` Ferruh Yigit
  2021-09-16 13:16             ` Xia, Chenbo
  0 siblings, 1 reply; 12+ messages in thread
From: Ferruh Yigit @ 2021-09-16 12:57 UTC (permalink / raw)
  To: Xia, Chenbo, Maxime Coquelin, Gaoxiang Liu
  Cc: dev, liugaoxiang, stable, Thomas Monjalon

On 9/16/2021 1:37 PM, Xia, Chenbo wrote:
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Thursday, September 16, 2021 8:33 PM
>> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Gaoxiang Liu
>> <gaoxiangliu0@163.com>; Xia, Chenbo <chenbo.xia@intel.com>
>> Cc: dev@dpdk.org; liugaoxiang@huawei.com; stable@dpdk.org; Thomas Monjalon
>> <thomas@monjalon.net>
>> Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of socket path on
>> adding connection
>>
>>
>>
>> On 9/16/21 14:28, Ferruh Yigit wrote:
>>> On 9/14/2021 12:30 PM, Maxime Coquelin wrote:
>>>>
>>>>
>>>> On 9/7/21 2:51 AM, Gaoxiang Liu wrote:
>>>>> Add log print of socket path in vhost_user_add_connection.
>>>>> It's useful when adding a mass of socket connections,
>>>>> because the information of every connection is clearer.
>>>>>
>>>>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
>>>>> Cc: stable@dpdk.org
>>>>>
>>>>> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
>>>>> ---
>>>>>   lib/vhost/socket.c | 2 +-
>>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>
>>>>
>>>> Applied to dpdk-next-virtio/main.
>>>>
>>>
>>>
>>> Hi Gaoxiang,
>>>
>>> I can see you are in the git history as:
>>> "Gaoxiang Liu <liugaoxiang@huawei.com>"
>>>
>>> Since we are trying to keep unique identity in the git history, I will use
>> the
>>> one in the git history. Please let us know if that is problem.
>>
>> I fixed up the Author field in my pull request to match the SoB.
>> Did I miss something?
> 
> History is Gaoxiang uses @163 email to send patches but signed-off with @huawei email,
> So I told him to align and Maxime to fix when applying. Maybe it's my bad about not
> being clear about which to use because it happens several times Gaoxiang uses two emails.
> 

+1 to align SOB & author (I think checkpatch warns otherwise), but since in the
git there are commits from 'Gaoxiang Liu <liugaoxiang@huawei.com>', I think we
should align to that email address.

> I notice people from Huawei sometimes use two emails for author and SOB tag.
> So I have the same question :)
> 
> /Chenbo
> 
>>
>> Thanks,
>> Maxime
>>
>>> And is there any specific reason to use two different emails?
>>
>>
>>> Thanks,
>>> ferruh
>>>
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: add log print of socket path on adding connection
  2021-09-16 12:57           ` Ferruh Yigit
@ 2021-09-16 13:16             ` Xia, Chenbo
  2021-09-16 13:36               ` Gaoxiang Liu
  0 siblings, 1 reply; 12+ messages in thread
From: Xia, Chenbo @ 2021-09-16 13:16 UTC (permalink / raw)
  To: Yigit, Ferruh, Maxime Coquelin, Gaoxiang Liu
  Cc: dev, liugaoxiang, stable, Thomas Monjalon

> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Thursday, September 16, 2021 8:57 PM
> To: Xia, Chenbo <chenbo.xia@intel.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>; Gaoxiang Liu <gaoxiangliu0@163.com>
> Cc: dev@dpdk.org; liugaoxiang@huawei.com; stable@dpdk.org; Thomas Monjalon
> <thomas@monjalon.net>
> Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of socket path
> on adding connection
> 
> On 9/16/2021 1:37 PM, Xia, Chenbo wrote:
> >> -----Original Message-----
> >> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> >> Sent: Thursday, September 16, 2021 8:33 PM
> >> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Gaoxiang Liu
> >> <gaoxiangliu0@163.com>; Xia, Chenbo <chenbo.xia@intel.com>
> >> Cc: dev@dpdk.org; liugaoxiang@huawei.com; stable@dpdk.org; Thomas
> Monjalon
> >> <thomas@monjalon.net>
> >> Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of socket
> path on
> >> adding connection
> >>
> >>
> >>
> >> On 9/16/21 14:28, Ferruh Yigit wrote:
> >>> On 9/14/2021 12:30 PM, Maxime Coquelin wrote:
> >>>>
> >>>>
> >>>> On 9/7/21 2:51 AM, Gaoxiang Liu wrote:
> >>>>> Add log print of socket path in vhost_user_add_connection.
> >>>>> It's useful when adding a mass of socket connections,
> >>>>> because the information of every connection is clearer.
> >>>>>
> >>>>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
> >>>>> Cc: stable@dpdk.org
> >>>>>
> >>>>> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
> >>>>> ---
> >>>>>   lib/vhost/socket.c | 2 +-
> >>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>>
> >>>>
> >>>>
> >>>> Applied to dpdk-next-virtio/main.
> >>>>
> >>>
> >>>
> >>> Hi Gaoxiang,
> >>>
> >>> I can see you are in the git history as:
> >>> "Gaoxiang Liu <liugaoxiang@huawei.com>"
> >>>
> >>> Since we are trying to keep unique identity in the git history, I will
> use
> >> the
> >>> one in the git history. Please let us know if that is problem.
> >>
> >> I fixed up the Author field in my pull request to match the SoB.
> >> Did I miss something?
> >
> > History is Gaoxiang uses @163 email to send patches but signed-off with
> @huawei email,
> > So I told him to align and Maxime to fix when applying. Maybe it's my
> bad about not
> > being clear about which to use because it happens several times Gaoxiang
> uses two emails.
> >
> 
> +1 to align SOB & author (I think checkpatch warns otherwise), but since
> in the
> git there are commits from 'Gaoxiang Liu <liugaoxiang@huawei.com>', I
> think we
> should align to that email address.

That's fixed when applying IIRC. If Gaoxiang can only use @163 email to send patch,
maybe we should always align to another one...Or it's annoying to fix every time.

/Chenbo

> 
> > I notice people from Huawei sometimes use two emails for author and SOB
> tag.
> > So I have the same question :)
> >
> > /Chenbo
> >
> >>
> >> Thanks,
> >> Maxime
> >>
> >>> And is there any specific reason to use two different emails?
> >>
> >>
> >>> Thanks,
> >>> ferruh
> >>>
> >


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: add log print of socket path on adding connection
  2021-09-16 13:16             ` Xia, Chenbo
@ 2021-09-16 13:36               ` Gaoxiang Liu
  0 siblings, 0 replies; 12+ messages in thread
From: Gaoxiang Liu @ 2021-09-16 13:36 UTC (permalink / raw)
  To: Xia, Chenbo
  Cc: Yigit, Ferruh, Maxime Coquelin, dev, liugaoxiang, stable,
	Thomas Monjalon

Hi Chenbo,

    liugaoxiang@huawei.com and gaoxiangliu0@163.com both are my email addresses.
You can align to liugaoxiang@huawei.com or gaoxiangliu0@163.com when applying the patch.
    And the email address of  liugaoxiang@huawei.com now has only the permission to receive emails,
but not the permission to send emails, so I have to send patches with @163 email.


Thanks,
Gaoxiang




At 2021-09-16 21:16:11, "Xia, Chenbo" <chenbo.xia@intel.com> wrote:
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit@intel.com>
>> Sent: Thursday, September 16, 2021 8:57 PM
>> To: Xia, Chenbo <chenbo.xia@intel.com>; Maxime Coquelin
>> <maxime.coquelin@redhat.com>; Gaoxiang Liu <gaoxiangliu0@163.com>
>> Cc: dev@dpdk.org; liugaoxiang@huawei.com; stable@dpdk.org; Thomas Monjalon
>> <thomas@monjalon.net>
>> Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of socket path
>> on adding connection
>> 
>> On 9/16/2021 1:37 PM, Xia, Chenbo wrote:
>> >> -----Original Message-----
>> >> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> >> Sent: Thursday, September 16, 2021 8:33 PM
>> >> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Gaoxiang Liu
>> >> <gaoxiangliu0@163.com>; Xia, Chenbo <chenbo.xia@intel.com>
>> >> Cc: dev@dpdk.org; liugaoxiang@huawei.com; stable@dpdk.org; Thomas
>> Monjalon
>> >> <thomas@monjalon.net>
>> >> Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of socket
>> path on
>> >> adding connection
>> >>
>> >>
>> >>
>> >> On 9/16/21 14:28, Ferruh Yigit wrote:
>> >>> On 9/14/2021 12:30 PM, Maxime Coquelin wrote:
>> >>>>
>> >>>>
>> >>>> On 9/7/21 2:51 AM, Gaoxiang Liu wrote:
>> >>>>> Add log print of socket path in vhost_user_add_connection.
>> >>>>> It's useful when adding a mass of socket connections,
>> >>>>> because the information of every connection is clearer.
>> >>>>>
>> >>>>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
>> >>>>> Cc: stable@dpdk.org
>> >>>>>
>> >>>>> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
>> >>>>> ---
>> >>>>>   lib/vhost/socket.c | 2 +-
>> >>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> >>>>>
>> >>>>
>> >>>>
>> >>>> Applied to dpdk-next-virtio/main.
>> >>>>
>> >>>
>> >>>
>> >>> Hi Gaoxiang,
>> >>>
>> >>> I can see you are in the git history as:
>> >>> "Gaoxiang Liu <liugaoxiang@huawei.com>"
>> >>>
>> >>> Since we are trying to keep unique identity in the git history, I will
>> use
>> >> the
>> >>> one in the git history. Please let us know if that is problem.
>> >>
>> >> I fixed up the Author field in my pull request to match the SoB.
>> >> Did I miss something?
>> >
>> > History is Gaoxiang uses @163 email to send patches but signed-off with
>> @huawei email,
>> > So I told him to align and Maxime to fix when applying. Maybe it's my
>> bad about not
>> > being clear about which to use because it happens several times Gaoxiang
>> uses two emails.
>> >
>> 
>> +1 to align SOB & author (I think checkpatch warns otherwise), but since
>> in the
>> git there are commits from 'Gaoxiang Liu <liugaoxiang@huawei.com>', I
>> think we
>> should align to that email address.
>
>That's fixed when applying IIRC. If Gaoxiang can only use @163 email to send patch,
>maybe we should always align to another one...Or it's annoying to fix every time.
>
>/Chenbo
>
>> 
>> > I notice people from Huawei sometimes use two emails for author and SOB
>> tag.
>> > So I have the same question :)
>> >
>> > /Chenbo
>> >
>> >>
>> >> Thanks,
>> >> Maxime
>> >>
>> >>> And is there any specific reason to use two different emails?
>> >>
>> >>
>> >>> Thanks,
>> >>> ferruh
>> >>>
>> >
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-09-16 13:36 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-04 14:28 [dpdk-dev] [PATCH] vhost: add log print of socket path on adding connection Gaoxiang Liu
2021-09-06  5:35 ` Xia, Chenbo
2021-09-07  0:47   ` Gaoxiang Liu
2021-09-07  0:51 ` [dpdk-dev] [PATCH v2] " Gaoxiang Liu
2021-09-07  1:35   ` Xia, Chenbo
2021-09-14 11:30   ` Maxime Coquelin
2021-09-16 12:28     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-09-16 12:33       ` Maxime Coquelin
2021-09-16 12:37         ` Xia, Chenbo
2021-09-16 12:57           ` Ferruh Yigit
2021-09-16 13:16             ` Xia, Chenbo
2021-09-16 13:36               ` Gaoxiang Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).