From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 802501B12B for ; Fri, 5 Oct 2018 15:26:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2018 06:26:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,344,1534834800"; d="scan'208";a="78739964" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by orsmga007.jf.intel.com with ESMTP; 05 Oct 2018 06:26:49 -0700 To: Alejandro Lucero Cc: Thomas Monjalon , Andrew Rybchenko , dev , rasland@mellanox.com References: <1538047596-23954-1-git-send-email-alejandro.lucero@netronome.com> <256449070.EJcjglVyyx@xps> <5e62c6c8-0650-b1f9-6a98-d70f5f3a944b@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <0c1f4fbe-9e34-9c69-10c9-46f6d5df9ca2@intel.com> Date: Fri, 5 Oct 2018 14:26:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: add field for device data per process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 13:26:54 -0000 On 10/5/2018 2:17 PM, Alejandro Lucero wrote: > On Fri, Oct 5, 2018 at 2:01 PM Ferruh Yigit wrote: > >> On 10/3/2018 9:44 PM, Thomas Monjalon wrote: >>> + Cc more people >>> >>> 27/09/2018 13:26, Alejandro Lucero: >>>> Primary and secondary processes share a per-device private data. With >>>> current design it is not possible to have data per-device per-process. >>>> This is required for handling properly the CPP interface inside the NFP >>>> PMD with multiprocess support. >>>> >>>> There is also at least another PMD driver, tap, with similar >>>> requirements for per-process device data. >>> >>> Yes, it is required to fix tap PMD for multi-process usage. >>> >>> I am in favor of accepting this change in 18.11. >>> >>> [...] >>>> @@ -539,7 +539,13 @@ struct rte_eth_dev { >>>> eth_rx_burst_t rx_pkt_burst; /**< Pointer to PMD receive function. >> */ >>>> eth_tx_burst_t tx_pkt_burst; /**< Pointer to PMD transmit >> function. */ >>>> eth_tx_prep_t tx_pkt_prepare; /**< Pointer to PMD transmit prepare >> function. */ >>>> - struct rte_eth_dev_data *data; /**< Pointer to device data */ >>>> + /** >>>> + * Next two fields are per-device data but *data is shared between >>> >>> All fields in rte_eth_dev are per-device. >>> >>>> + * primary and secondary processes and *process_private is >> per-process >>>> + * private. >>>> + */ >>>> + struct rte_eth_dev_data *data; /**< Pointer to device data. */ >>>> + void *process_private; /**< Pointer to per-process device data. */ >>> >>> We could explain here that this memory is allocated by the PMD. >> >> Will there be new version? >> >> Are we agree on name? >> >> Is LIBABIVER increase should be done in this patch, or will there be other >> patch >> already doing it? >> > > I'm not familiar with LIBABIVER but just tell me to send it again with that > change if you consider that is the right thing to do. ABI breakage process: - Increase LIBABIVER in library Makefile/meson.build - Update lib in release notes "Shared Library Versions" section, with a "+" to to indicate change - Remove deprecation notice (seems not applies to this one) Thomas mentioned there is another patch breaking the ABI for ethdev, I wonder which patch will do the above process. > About the name, I will let other to tell. > > Thanks >