From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id B72403772 for ; Mon, 11 Mar 2019 16:57:16 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 5A39DB4007F; Mon, 11 Mar 2019 15:57:15 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 11 Mar 2019 15:57:09 +0000 To: David Marchand , CC: , , , References: <1550158972-21895-1-git-send-email-david.marchand@redhat.com> <1552318522-18777-1-git-send-email-david.marchand@redhat.com> <1552318522-18777-4-git-send-email-david.marchand@redhat.com> From: Andrew Rybchenko Message-ID: <0c3ebd81-fcd6-173b-4cb1-e748829e30d2@solarflare.com> Date: Mon, 11 Mar 2019 18:57:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1552318522-18777-4-git-send-email-david.marchand@redhat.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24482.004 X-TM-AS-Result: No-5.405100-8.000000-10 X-TMASE-MatchedRID: L8tZF6zWW2p2LasmHuCXMSa1MaKuob8PC/ExpXrHizzsymHp26m2OMbK +pu0ZYwRjmMVD2fpuVmriHtpOq/KoibZZYAQu9H5pvwZ9GmdwDN8s8pjIsOUBx//bz4/xYKAs5z FXti7BOGbH8Nat9yLtuGEuhchvL8o8lEDYmoBkrPbH8WaUL9qjJv8tNLRPUrWv8M96e6S1b0sWV dl3YcDsO3zSoJhBLBNecgYU4W31hPMWzPfoqOdFp06nVOMOuVpHAwy0XhreD35lA8aRaIEF6PFj JEFr+olA9Mriq0CDAgQVjqAOZ5cjSdET58jp62Sn1+VE+02RfLOY/htINZa4HZd8GQRVIt/jOZV FBYQ6k5k+dyOA9V6UwfanLcrFrrkHKRrfKKRZr0OmaI6TYb1gk3CaRdE9E74nqg/VrSZEiM= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.405100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24482.004 X-MDID: 1552319836-H4OYIpRpSn-9 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 3/4] app/testpmd: remove useless casts on statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 15:57:17 -0000 On 3/11/19 6:35 PM, David Marchand wrote: > Caught by code review while investigating the stats display code. > Switching all port and fwd engine statistics to uint64_t makes it > possible to drop all casts. > > Signed-off-by: David Marchand Patch summary is misleading here. The main change here is changing of counters bitwidth. 32-bit counters overflow pretty fast on 100G, so it is a good idea to fix it. Andrew.