From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 5A7CC2946
 for <dev@dpdk.org>; Thu, 13 Oct 2016 13:00:10 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga104.fm.intel.com with ESMTP; 13 Oct 2016 04:00:09 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,339,1473145200"; d="scan'208";a="1069883285"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.83])
 ([10.237.220.83])
 by fmsmga002.fm.intel.com with ESMTP; 13 Oct 2016 04:00:08 -0700
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, dev@dpdk.org
References: <1476085594-32325-1-git-send-email-wenzhuo.lu@intel.com>
 <1476253462-13000-1-git-send-email-wenzhuo.lu@intel.com>
 <1476253462-13000-3-git-send-email-wenzhuo.lu@intel.com>
Cc: Pablo de Lara <pablo.de.lara.guarch@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <0c6925b7-9475-c6c8-b1cb-50e41044f050@intel.com>
Date: Thu, 13 Oct 2016 12:00:07 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1476253462-13000-3-git-send-email-wenzhuo.lu@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: fix wrong flow director
 mask
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Oct 2016 11:00:10 -0000

Hi Wenzhuo,

On 10/12/2016 7:24 AM, Wenzhuo Lu wrote:
> In mac-vlan mode, MAC address mask is not supported by HW.
> The MAC address mask should not be set in mac-vlan mode.
> Remove this parameter from the CLI. Remove MAC address
> from mask print too.
> 
> Fixes: 53b2bb9b7ea7 ("app/testpmd: new flow director commands")
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> ---

I think it is good to require an ack from testpmd maintainer for this
patch. cc'ed Pablo.

Thanks,
ferruh