From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id CFC6F326F for ; Tue, 1 Nov 2016 15:17:53 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 01 Nov 2016 07:17:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,579,1473145200"; d="scan'208";a="780849040" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 01 Nov 2016 07:17:52 -0700 To: Mauricio Vasquez B , bruce.richardson@intel.com References: <1477972113-2600-1-git-send-email-mauricio.vasquez@polito.it> From: Ferruh Yigit Message-ID: <0c7bc9f5-decd-5fc1-6601-a457fee319dc@intel.com> Date: Tue, 1 Nov 2016 14:17:50 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1477972113-2600-1-git-send-email-mauricio.vasquez@polito.it> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] pmd_ring: fix coverity issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Nov 2016 14:17:54 -0000 Hi Mauricio, On 11/1/2016 3:48 AM, Mauricio Vasquez B wrote: > internals->data will never be NULL, so the check is not necessary. > > Fixes: d082c0395bf6 ("ring: fix memory leak when detaching") > Coverity issue: 137873 > > Signed-off-by: Mauricio Vasquez B > --- Thank you for the patch. But "fix coverity issue" is not very descriptive title on its own. Can you please describe what is really done in the patch, perhaps something like: "net/ring: remove unnecessary NULL check" ? Thanks, ferruh