From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7258A00C4; Fri, 5 Jun 2020 11:25:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 80A361D5DC; Fri, 5 Jun 2020 11:25:08 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 0CF621D5DA for ; Fri, 5 Jun 2020 11:25:06 +0200 (CEST) IronPort-SDR: ss7SYg3D8aV9OZMrDUj2URUUGnlhYht2kxJznM0slhKfd4DwerHfNfhAN5H+stiiQvWtyYTqR1 OW4C/WAOaQ3w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2020 02:25:06 -0700 IronPort-SDR: GenDHqpjLXyo/SUU5F+kfhzNzjKJG7X7vbBC808Jza64rTDJmGWchJ9zXdLMscXRyiqMUExalY f3P+wZ7wUAkw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,475,1583222400"; d="scan'208";a="273413905" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.24.115]) ([10.252.24.115]) by orsmga006.jf.intel.com with ESMTP; 05 Jun 2020 02:25:04 -0700 To: "Wei Hu (Xavier)" Cc: dev@dpdk.org References: <1591251737-64598-1-git-send-email-xavier.huwei@huawei.com> <66ad25cf-1cdb-c470-ae8a-260929ff6fab@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: <0c7c5502-def3-2cc7-85a6-f7588b28b758@intel.com> Date: Fri, 5 Jun 2020 10:25:04 +0100 MIME-Version: 1.0 In-Reply-To: <66ad25cf-1cdb-c470-ae8a-260929ff6fab@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix passing negative parameter to strerror X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/5/2020 3:57 AM, Wei Hu (Xavier) wrote: > > > On 2020/6/5 0:30, Ferruh Yigit wrote: >> On 6/4/2020 7:22 AM, Wei Hu (Xavier) wrote: >>> Currently, there are coverity defect warnings as blow: >>> Coverity issue: >>> In nic_stats_clear function: >>> CID 290021 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS) >>> 5. negative_returns: ret is passed to a parameter that cannot be >>> negative. >>> >>> CID 289974 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS) >>> 6. negative_returns: ret is passed to a parameter that cannot be >>> negative. >>> >>> In nic_xstats_clear function: >>> CID 289985 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS) >>> 5. negative_returns: ret is passed to a parameter that cannot be >>> negative. >>> >>> CID 289850 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS) >>> 6. negative_returns: ret is passed to a parameter that cannot be >>> negative. >> I guess these coverity IDs are from the internal coverity, because I can't find >> them in the public coverity. >> If it is internal, not sure about the benefit of documenting them in the commit >> log, since no one except huawei can access them. What do you think to remove all >> above reference? > Yes, these are internal covertiy defects information. Maybe we can remove > internal coverity CID xxxx and reserve the description of the defect in the > commit log. > > By the way, when we access the "View defects" on the page of the public > coverity > https://scan.coverity.com/projects/dpdk-data-plane-development-kit?tab=overview > > , The browser prompts HTTP ERROR 403. Can you please try a few times, I am also getting same error time to time but it works after some tr. And when it is successful, I have following URL, not sure if it works but you can try this too: https://scan4.coverity.com/reports.htm#v22369/p10075 >>> This patch fixes them by passing '-ret' to the function strerror() when ret >>> is negative. >>> >>> Fixes: af75078fece3 ("first public release") >>> Fixes: 9eb974221f44 ("app/testpmd: fix statistics after reset") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Wei Hu (Xavier) >>> --- >>> app/test-pmd/config.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c >>> index 5381207..356d0d2 100644 >>> --- a/app/test-pmd/config.c >>> +++ b/app/test-pmd/config.c >>> @@ -244,14 +244,14 @@ nic_stats_clear(portid_t port_id) >>> ret = rte_eth_stats_reset(port_id); >>> if (ret != 0) { >>> printf("%s: Error: failed to reset stats (port %u): %s", >>> - __func__, port_id, strerror(ret)); >>> + __func__, port_id, strerror(-ret)); >>> return; >>> } >>> >>> ret = rte_eth_stats_get(port_id, &ports[port_id].stats); >>> if (ret != 0) { >>> printf("%s: Error: failed to get stats (port %u): %s", >>> - __func__, port_id, strerror(ret)); >>> + __func__, port_id, strerror(-ret)); >> Although in practice this may be the case, the 'rte_eth_stats_get()' function >> documentation doesn't guarantee that return value will be negative, it says: >> >> " >> * @return >> * Zero if successful. Non-zero otherwise >> " >> >> To be accurate, what do you think to adding a negative check for 'ret' before >> doing '-ret'? > OK, we will add a negative check in V2. > > Thanks, Xavier >