From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 09919532E for ; Wed, 24 Aug 2016 09:42:19 +0200 (CEST) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8531E7304D; Wed, 24 Aug 2016 07:42:18 +0000 (UTC) Received: from [10.36.7.65] (vpn1-7-65.ams2.redhat.com [10.36.7.65]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7O7gGwW012798 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 24 Aug 2016 03:42:17 -0400 To: Yuanhan Liu , dev@dpdk.org References: <1471510123-4984-1-git-send-email-yuanhan.liu@linux.intel.com> <1471510123-4984-2-git-send-email-yuanhan.liu@linux.intel.com> From: Maxime Coquelin Message-ID: <0c88e6ea-bafe-8791-82ee-a67da7a5e4df@redhat.com> Date: Wed, 24 Aug 2016 09:42:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1471510123-4984-2-git-send-email-yuanhan.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 24 Aug 2016 07:42:18 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 1/7] vhost: remove vhost-cuse X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2016 07:42:19 -0000 On 08/18/2016 10:48 AM, Yuanhan Liu wrote: > remove vhost-cuse code, including the eventfd_link kernel module that > is for vhost-cuse only. > > The lib/virt/qemu-wrap.py is also removed, as it's mainly for vhost-cuse > usage. > > As we have one vhost implementation now, one vhost config option is > needed only. Thus, CONFIG_RTE_LIBRTE_VHOST_USER is removed. > > Signed-off-by: Yuanhan Liu > --- > config/common_base | 6 +- > lib/librte_vhost/Makefile | 13 +- > lib/librte_vhost/eventfd_link/Makefile | 41 --- > lib/librte_vhost/eventfd_link/eventfd_link.c | 277 ---------------- > lib/librte_vhost/eventfd_link/eventfd_link.h | 94 ------ > lib/librte_vhost/libvirt/qemu-wrap.py | 387 ----------------------- > lib/librte_vhost/vhost_cuse/eventfd_copy.c | 104 ------- > lib/librte_vhost/vhost_cuse/eventfd_copy.h | 45 --- > lib/librte_vhost/vhost_cuse/vhost-net-cdev.c | 431 ------------------------- > lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 433 -------------------------- > lib/librte_vhost/vhost_cuse/virtio-net-cdev.h | 56 ---- > mk/rte.app.mk | 3 - > 12 files changed, 4 insertions(+), 1886 deletions(-) > delete mode 100644 lib/librte_vhost/eventfd_link/Makefile > delete mode 100644 lib/librte_vhost/eventfd_link/eventfd_link.c > delete mode 100644 lib/librte_vhost/eventfd_link/eventfd_link.h > delete mode 100755 lib/librte_vhost/libvirt/qemu-wrap.py > delete mode 100644 lib/librte_vhost/vhost_cuse/eventfd_copy.c > delete mode 100644 lib/librte_vhost/vhost_cuse/eventfd_copy.h > delete mode 100644 lib/librte_vhost/vhost_cuse/vhost-net-cdev.c > delete mode 100644 lib/librte_vhost/vhost_cuse/virtio-net-cdev.c > delete mode 100644 lib/librte_vhost/vhost_cuse/virtio-net-cdev.h Looks good to me: Reviewed-by: Maxime Coquelin Thanks, Maxime