DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
To: Jerin Jacob <jerinjacobk@gmail.com>,
	Sunil Kumar Kori <skori@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
	Nikhil Rao <nikhil.rao@intel.com>,
	Pavan Nikhilesh <pbhagavatula@marvell.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Nipun Gupta <nipun.gupta@nxp.com>,
	"Van Haaren, Harry" <harry.van.haaren@intel.com>,
	Liang Ma <liang.j.ma@intel.com>, dpdk-dev <dev@dpdk.org>,
	Thomas Monjalon <thomas@monjalon.net>,
	David Marchand <david.marchand@redhat.com>,
	"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
	Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
	"Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	Akhil Goyal <gakhil@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v5 1/4] doc: add skeleton for eventdevs feature matrices
Date: Wed, 10 Nov 2021 09:42:15 +0100	[thread overview]
Message-ID: <0c9ce370-51af-9287-9780-eff9dc3b3bcb@ericsson.com> (raw)
In-Reply-To: <CALBAE1Pk=HQyCmNGSrd3zmYmA-C0pfS03ZZSUrL4+VN9jQcSUg@mail.gmail.com>

On 2021-11-09 11:11, Jerin Jacob wrote:
> On Fri, Oct 22, 2021 at 1:18 PM <skori@marvell.com> wrote:
>>
>> From: Sunil Kumar Kori <skori@marvell.com>
>>
>> Patch adds skeleton for feature matrices for event dev
>> and Rx/Tx adapters.
>>
>> Along with, .ini files are added for all supported PMDs.
>>
>> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> 
> 
> +  Tree maintainers and eventdev adapter maintainers
> 
> 1) Please rebase to dpdk-next-eventdev
> 2) Please update devtools/check-doc-vs-code.sh
> You can use search _CAP_ and != CAP_REQUIRES_ to detect the capability
> change or so.
> 3) Update the .ini for all the eventdev drivers, not just Marvell ones.
> 
>>
>>   # Maximum feature description string length
>> -feature_str_len = 30
>> +feature_str_len = 45
> 
> I hope this OK. I understand that without this it gives errors and
> feature-length is not enough
> 
>> diff --git a/doc/guides/eventdevs/features/default.ini b/doc/guides/eventdevs/features/default.ini
>> new file mode 100644
>> index 0000000000..d007d7a69e
>> --- /dev/null
>> +++ b/doc/guides/eventdevs/features/default.ini
>> @@ -0,0 +1,30 @@
>> +;
>> +; Features of a default eventdev driver.
>> +;
>> +; This file defines the features that are valid for inclusion in
>> +; the other driver files and also the order that they appear in
>> +; the features table in the documentation.
>> +;
>> +[Features]
>> +Event queue priority based scheduling =
>> +Event priority based scheduling       =
>> +Event device distributed scheduling   =
>> +Event device non sequential mode      =
>> +Event queue all types                 =
>> +Burst mode enqueue/dequeue            =
>> +Event port implicit release disable   =
>> +Runtime event queue/port linking      =
>> +Multi queue linking per port          =
> 
> 1) Please sync the doc order with flag definition order in header file[1]
> 2) You can remove RTE_EVENT_DEV_CAP_REQUIRES_MAINT from the
> list(*CAP_REQUIRES*) as this
> is limitation.
> 
> 

Maybe we should negate RTE_EVENT_DEV_CAP_REQUIRES_MAINT to make it fit 
better with the other capabilities? To be more in line with how the API 
has been adapted to cope with various eventdev hardware limitations 
(e.g., RTE_EVENT_DEV_CAP_CARRY_FLOW_ID).

RTE_EVENT_DEV_CAP_MAINTENANCE_FREE

All event devices/drivers would set this except DSW.

If this make sense and it's not too late to tweak the API, I can create 
a patch.

> [1]
> RTE_EVENT_DEV_CAP_QUEUE_QOS
> RTE_EVENT_DEV_CAP_EVENT_QOS
> RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED
> RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES
> RTE_EVENT_DEV_CAP_BURST_MODE
> RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE
> RTE_EVENT_DEV_CAP_NONSEQ_MODE
> RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK
> RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT
> RTE_EVENT_DEV_CAP_CARRY_FLOW_ID
> 
> 
> 
>> +
>> +;
>> +; Features of a default adapter.
>> +;
>> +[Adapter Features]
> 
> Please make this as [Eth Rx adapter Features]
> 
>> +Eth Rx/Tx adapter on internal port         =
> You can remove Eth Rx/Tx adapter as new subject has [Eth Rx adapter]
> 
>> +Multiple event queues per ethdev           =
>> +Override flow ID                           =
> 
> Missing RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR
> 
> 
> Add new section for Tx adapter
> and add
> RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT
> RTE_EVENT_ETH_TX_ADAPTER_CAP_EVENT_VECTOR
> 
> 
> Add new section for Crypto adapter
> 
>> +Crypto adapter new event enqueue           =
>> +Crypto adapter forwarded event enqueue     =
>> +Crypto queue pair mapping to event queue   =
>> +Crypto adapter session data store/retrieve =
> 
> 
> Add new section for timer adapter
> 
>> +Timer adapter support in H/W               =
> 
> Missing RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC
> 

  parent reply	other threads:[~2021-11-10  8:42 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 11:12 [dpdk-dev] [PATCH 1/3] doc: add skeleton for eventdevs feature metrices Sunil Kumar Kori
2019-11-07 11:12 ` [dpdk-dev] [PATCH 2/3] doc: update eventdev feature matrix for octeontx2 Sunil Kumar Kori
2019-11-07 11:12 ` [dpdk-dev] [PATCH 3/3] doc: update eventdev feature matrix for octeontx Sunil Kumar Kori
2019-11-15  7:38 ` [dpdk-dev] [PATCH 1/3] doc: add skeleton for eventdevs feature metrices Jerin Jacob
2019-11-21  7:44 ` [dpdk-dev] [PATCH v2 1/3] doc: add skeleton for eventdevs feature matrices Sunil Kumar Kori
2019-11-21  7:44   ` [dpdk-dev] [PATCH v2 2/3] doc: update eventdev feature matrix for octeontx2 Sunil Kumar Kori
2019-11-21  7:44   ` [dpdk-dev] [PATCH v2 3/3] doc: update eventdev feature matrix for octeontx Sunil Kumar Kori
2019-11-28 15:49   ` [dpdk-dev] [PATCH v2 1/3] doc: add skeleton for eventdevs feature matrices Thomas Monjalon
2019-12-03  6:27   ` [dpdk-dev] [PATCH v3 " Sunil Kumar Kori
2019-12-03  6:27     ` [dpdk-dev] [PATCH v3 2/3] doc: update eventdev feature matrix for octeontx2 Sunil Kumar Kori
2019-12-03  6:27     ` [dpdk-dev] [PATCH v3 3/3] doc: update eventdev feature matrix for octeontx Sunil Kumar Kori
2020-02-27  7:02     ` [dpdk-dev] [PATCH v4 1/3] doc: add skeleton for eventdevs feature matrices Sunil Kumar Kori
2020-02-27  7:03       ` [dpdk-dev] [PATCH v4 2/3] doc: update eventdev feature matrix for octeontx2 Sunil Kumar Kori
2020-02-27  7:03       ` [dpdk-dev] [PATCH v4 3/3] doc: update eventdev feature matrix for octeontx Sunil Kumar Kori
2021-10-22  7:48       ` [dpdk-dev] [PATCH v5 1/4] doc: add skeleton for eventdevs feature matrices skori
2021-10-22  7:48         ` [dpdk-dev] [PATCH v5 2/4] doc: update eventdev feature matrix for octeontx2 skori
2021-10-22  7:48         ` [dpdk-dev] [PATCH v5 3/4] doc: update eventdev feature matrix for octeontx skori
2021-10-22  7:48         ` [dpdk-dev] [PATCH v5 4/4] doc: update eventdev feature matrix for cnxk skori
2021-11-09 10:11         ` [dpdk-dev] [PATCH v5 1/4] doc: add skeleton for eventdevs feature matrices Jerin Jacob
2021-11-09 11:34           ` Thomas Monjalon
2021-11-11  6:40             ` [EXT] " Sunil Kumar Kori
2021-11-10  8:42           ` Mattias Rönnblom [this message]
2021-11-10  8:50             ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2021-11-10  9:29               ` [dpdk-dev] [PATCH] eventdev: negate maintenance capability flag Mattias Rönnblom
2021-11-10  9:55                 ` Van Haaren, Harry
2021-11-10 10:06                   ` [dpdk-dev] [PATCH v2] " Mattias Rönnblom
2021-11-10 10:07                   ` [dpdk-dev] [PATCH] " Mattias Rönnblom
2021-11-10 10:43                     ` Jerin Jacob
2021-11-10 11:32                       ` [dpdk-dev] [PATCH v3] " Mattias Rönnblom
2021-11-10 18:55                         ` Jerin Jacob
2021-11-10 11:14                   ` [dpdk-dev] [PATCH v2] eventdev: fix Rx adapter stalls on event device backpressure Mattias Rönnblom
2021-11-10 11:23                     ` Jayatheerthan, Jay
2021-11-10 18:56                       ` Jerin Jacob
2021-11-15 13:15         ` [PATCH v6 01/11] doc: add skeleton for eventdevs feature matrices skori
2021-11-15 13:15           ` [PATCH v6 02/11] doc: update eventdev feature matrix for octeontx skori
2021-11-15 13:15           ` [PATCH v6 03/11] doc: update eventdev feature matrix for octeontx2 skori
2021-11-15 13:15           ` [PATCH v6 04/11] doc: update eventdev feature matrix for cn9k skori
2021-11-15 13:15           ` [PATCH v6 05/11] doc: update eventdev feature matrix for cn10k skori
2021-11-15 13:15           ` [PATCH v6 06/11] doc: update eventdev feature matrix for dpaa skori
2021-11-15 13:15           ` [PATCH v6 07/11] doc: update eventdev feature matrix for dpaa2 skori
2021-11-15 13:15           ` [PATCH v6 08/11] doc: update eventdev feature matrix for SW skori
2021-11-15 13:15           ` [PATCH v6 09/11] doc: update eventdev feature matrix for opdl skori
2021-11-15 13:15           ` [PATCH v6 10/11] doc: update eventdev feature matrix for dsw skori
2021-11-15 13:15           ` [PATCH v6 11/11] devtools: check event device doc tables skori
2021-11-22  7:54           ` [PATCH v7 01/11] doc: add skeleton for eventdevs feature matrices skori
2021-11-22  7:54             ` [PATCH v7 02/11] doc: update eventdev feature matrix for octeontx skori
2021-11-22  7:54             ` [PATCH v7 03/11] doc: update eventdev feature matrix for octeontx2 skori
2021-11-22  7:54             ` [PATCH v7 04/11] doc: update eventdev feature matrix for cn9k skori
2021-11-22  7:54             ` [PATCH v7 05/11] doc: update eventdev feature matrix for cn10k skori
2021-11-22 18:25               ` Jerin Jacob
2021-11-22  7:54             ` [PATCH v7 06/11] doc: update eventdev feature matrix for dpaa skori
2021-11-22  7:54             ` [PATCH v7 07/11] doc: update eventdev feature matrix for dpaa2 skori
2021-11-22  7:54             ` [PATCH v7 08/11] doc: update eventdev feature matrix for SW skori
2021-11-22  7:54             ` [PATCH v7 09/11] doc: update eventdev feature matrix for opdl skori
2021-11-22  7:54             ` [PATCH v7 10/11] doc: update eventdev feature matrix for dsw skori
2021-11-22  7:54             ` [PATCH v7 11/11] devtools: check event device doc tables skori
2021-11-22 18:35               ` Jerin Jacob
2021-11-23 11:07             ` [PATCH v8 01/10] doc: add skeleton for eventdevs feature matrices skori
2021-11-23 11:07               ` [PATCH v8 02/10] doc: update eventdev feature matrix for octeontx skori
2021-11-23 11:07               ` [PATCH v8 03/10] doc: update eventdev feature matrix for octeontx2 skori
2021-11-23 11:07               ` [PATCH v8 04/10] doc: update eventdev feature matrix for cnxk skori
2021-11-23 11:07               ` [PATCH v8 05/10] doc: update eventdev feature matrix for dpaa skori
2021-11-23 11:07               ` [PATCH v8 06/10] doc: update eventdev feature matrix for dpaa2 skori
2021-11-23 11:07               ` [PATCH v8 07/10] doc: update eventdev feature matrix for SW skori
2021-11-23 11:07               ` [PATCH v8 08/10] doc: update eventdev feature matrix for opdl skori
2021-11-23 11:07               ` [PATCH v8 09/10] doc: update eventdev feature matrix for dsw skori
2021-11-23 11:07               ` [PATCH v8 10/10] devtools: check event device doc tables skori
2021-11-24 10:52                 ` Thomas Monjalon
2021-11-24 11:16                   ` [EXT] " Sunil Kumar Kori
2021-11-24 11:21                     ` Thomas Monjalon
2021-11-24 10:03               ` [PATCH v8 01/10] doc: add skeleton for eventdevs feature matrices Thomas Monjalon
2021-11-24 10:30                 ` [EXT] " Sunil Kumar Kori
2021-11-24 10:43                   ` Thomas Monjalon
2021-11-24 12:35                     ` Sunil Kumar Kori
2021-11-24 12:41                       ` Thomas Monjalon
2021-11-24 12:46                         ` Sunil Kumar Kori
2021-11-24 13:05                           ` Sunil Kumar Kori
2021-11-24 10:48               ` Thomas Monjalon
2021-11-24 11:12                 ` [EXT] " Sunil Kumar Kori
2021-11-24 12:14               ` [PATCH v1 1/1] doc: update eventdev feature matrix for dlb2 skori
2021-11-24 13:03               ` [PATCH v9 1/1] doc: add eventdevs feature matrices skori
2021-11-26 14:55                 ` Thomas Monjalon
2021-11-15 18:08         ` [dpdk-dev] [PATCH v5 1/4] doc: add skeleton for " Jerin Jacob
2021-11-23 16:44         ` Jerin Jacob
2021-11-24  8:06           ` Thomas Monjalon
2021-11-24  8:14             ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c9ce370-51af-9287-9780-eff9dc3b3bcb@ericsson.com \
    --to=mattias.ronnblom@ericsson.com \
    --cc=abhinandan.gujjar@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=ferruh.yigit@intel.com \
    --cc=gakhil@marvell.com \
    --cc=harry.van.haaren@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jay.jayatheerthan@intel.com \
    --cc=jerinj@marvell.com \
    --cc=jerinjacobk@gmail.com \
    --cc=liang.j.ma@intel.com \
    --cc=nikhil.rao@intel.com \
    --cc=nipun.gupta@nxp.com \
    --cc=pbhagavatula@marvell.com \
    --cc=skori@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).