From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2055B41D93; Mon, 27 Feb 2023 22:50:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 128B141140; Mon, 27 Feb 2023 22:50:17 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 95DEF40A7D for ; Mon, 27 Feb 2023 22:50:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nrrO2ZND1R4LExpohOqSJxMPsJKwWW5RI+zMZ+AOwXFjb+06GjGRoN0wjLnMi/c13yt96D0dPwBaxVEXzVx5em1XmzlGa7iH4CJquCiIpThd2EBBEFS1mtjIbsBDQw1ZvksMJgN3bQyOf3RrtjQIelrIcx9GcLFmJi4Cg0HtAAN3odtcrjV9oh7arHIjE/ow8mGh8nfqdexycNsuLxV+XYD/wfgG+qk7vxpQeonelEou/bu5qjIJEoQm8/HzmURusOx+ywFuEgh532lnEoVOLtjeqOfApDzto8Di4zzUVesZ4EqJQdKyDl+EbR0K1R9K3lQufoZGcqcGU/u8nSMsNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d+0wxr/Yb+b+DGuZo1riaXYRJiceac4nBtQ/1EX3ojM=; b=FheZI+FoDD+RikWpecfuBNnv4MZ+7NsMphdMCrB/S8NyA4ZXVBP8PjbobbCDcI1lMGS/cxaFeSis90vALSXezoq3kFojqwRlPepotpcvSovBzxyPfFexpGFSRq+TvF89ypTNgGPnHoktVh/Qdr9zB29BtC2i/Qiyi68eb9iB+GnoXu/pqj2HzZ9sQsXOlpWoxM9lovOtJFqVBcz19vzau8J83JmK1K681ML+Iz+akkLioUs/VaJWCPuFRqXHZoYxG9RMB6OSnGiHZ9QUDQXJIdpnGZ9J6S+eEdPvwL8g2pisVexP8OgsIjpNJF42GYydBSxq6KVetEMJlSJTSvuzpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d+0wxr/Yb+b+DGuZo1riaXYRJiceac4nBtQ/1EX3ojM=; b=IQbxcyk5f8Kj+8EXjpJxy/UmozRiCOH2h0hXTlYXESFfHqGtP3R+j7GaMGbJo8iWDIQ/36uMWczs9K0v0yZFVxF7hpZESCaA7Q2tqfRDaVKQLahcHX7mDIi2zuqcDH7lM6JXFGGsLB9ExdAUp0iZ/H3aoiQSySPRFY55BMiO0ck= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM8PR12MB5448.namprd12.prod.outlook.com (2603:10b6:8:27::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 21:50:14 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6134.029; Mon, 27 Feb 2023 21:50:14 +0000 Message-ID: <0ca019d8-19dc-2e5a-3910-7eaf12d9fb83@amd.com> Date: Mon, 27 Feb 2023 21:50:08 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Mingxia Liu , dev@dpdk.org, beilei.xing@intel.com, yuying.zhang@intel.com References: <20230213021956.2953088-1-mingxia.liu@intel.com> <20230216003010.3439881-1-mingxia.liu@intel.com> <20230216003010.3439881-13-mingxia.liu@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v7 12/21] net/cpfl: support RSS In-Reply-To: <20230216003010.3439881-13-mingxia.liu@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0416.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM8PR12MB5448:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f27fec8-0b82-438b-1503-08db190c9b37 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BHQii0SWR6IDDk2ycO+c9iQfLITkTtwC5XvWGVTKk5gFIlJ8/riQT2IrO9AO4+ass2tESjzPfCtEP1Ui6YRAG2iznsXwgWW5Ln4IyxbE2wnzCNnvyXUlT7/0hndR3HS31hig9qWqGXZYqroZyrHWg3tYo+NHfM1Z+vNTCoXJ8taPuHROKPQa2aWk7OU0A86XtJjcRFXI3P8+dM7LAvMH4vAlh0KsGbBpOPy2555Vq4rIh/ndLQ2L4WDL6We9zjoa5EgCKQAw02YykId6n5vvROUWePrYxkPn6i/j4pIk9HSHgpvU3NQrTJXKoJrkk4iz788IocHz8mpqcOsIR0gaeQpKYngT0JNstmkafbAXk/NEXm4LSRSpwcnLMDWQZ9GxlUaVViBwBO9Pryuw5+tyVk/PrDW/UDpEhp6m6utZlJEr/oV2XGFNU/vTLHO7WdK6lFfoQGpSnSp17XfCNPcziAElpuhP3R58eS7+oEpwOyRjjSMzcoUjJUjx/AgSkX1ojEtZJIbOFNFGzs/uaLv7Xt198epwGUXi7mnoMqXqSUt3UUgoVeyH/ZztScC59UV44KelpwQbV9bhhvgHWCRECTq+2eNs1gsCgRiAsV7IwUuE6dCXGQN6n9KPrrbB4As0RiYn5XKh69NHG99Qu3UojDk99SUDReeMt20Ybm68XeSm0+3WmkQsZRGH9eve5YOBIPmW8jABNL9OuqqKw0Bde86VHcozbGzfULQK9TyVSZE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(136003)(396003)(366004)(39860400002)(376002)(451199018)(36756003)(83380400001)(478600001)(6486002)(6666004)(2616005)(6506007)(26005)(186003)(6512007)(86362001)(8936002)(41300700001)(2906002)(31696002)(5660300002)(66556008)(4744005)(44832011)(66946007)(316002)(66476007)(8676002)(38100700002)(53546011)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1Jpa2ZHa0F1VHdiajZESklsMWE5aldubDRsVng2K0NheTR6cDFhODJUOTUr?= =?utf-8?B?dGxOUDJQNWtwWVBQWVJzY1RXTHQ3bDJCdHV6ODBWOEJVVmlCcDYrclFUN3pk?= =?utf-8?B?d3RXcHA3ejcySmRTelNWMXdOUURtc1Zna3oyS2pEOVRZS21BWkhQdlNibFVC?= =?utf-8?B?akpOYjdlM3NGenVobWYwNmh3OGRtUDV6cUUrUVdVZC9Eb284N2tYOW1QYThv?= =?utf-8?B?RTNBWDdjRHhYVnJjcElnSkNKb2R5U1A0eld4UFlYMmpPRjdjdmQxb0k3OWpt?= =?utf-8?B?UXNsZmVzbFN0ZVVlbnhHdnVkN2YrdTdmTVliUFE4VjdHcHE2WDdiTWhlaE9t?= =?utf-8?B?VU5rNERaK0NIUi9wUFMwRXVkM1Y0VXpiV0E0cWtjdFJUZ2ZDMFQxRWRXUElL?= =?utf-8?B?SnpXdlBBdjJ0cDZVYk5hampCM1BzblV2cUV2Q3lqd1NwUUZuU2JtL25jUGd6?= =?utf-8?B?VVMwRkE5WWZBbENmYnA3OXlWQkhXQWRZN2ZYTDZBdVRvM0FSOTRXY3lTN2lV?= =?utf-8?B?dEx1bUozZlgxWE90azl0cU0rOW56RGdLYmVhMlk1VWczeGVQT296eUowRUV5?= =?utf-8?B?WXRyZmNFTzQ0c1hmZGdJaDhVRW9ZWlkzQmY3aEtNZzhoTU0vV28yeVNsaVhr?= =?utf-8?B?OEVSd3NMYkF3K1hGMGFjL3FFQXlyNldJVmlSV0k3WDJRRUxCVzE1MmU5YlVO?= =?utf-8?B?OFAxUUN5MkZNRHd6eE9qTlRrM0RTWUV4U1lJTDNTY1RPLzJRb045Q3lGVlVl?= =?utf-8?B?aTIwODhid2piOXdPSy9IZk9sTUgzWEdxVVhnNkxoeWNnNFZxU2JFUm84b1Iw?= =?utf-8?B?K2dKdXV3Wnk4THoyUmg0TlRDUFcrMTBueXdtUUFzQmk5bEFVREp3Y1NGQUor?= =?utf-8?B?NU85NUZkQm5VK0o2MTVkZkxNUUh3UUI1YVhrVU5oZDJyV2xRVnVwV2J5MnNh?= =?utf-8?B?d3ZCZU5vcUlpMCtnbVVIMXhOa3JJWjdLaUlkRWNqTFNNekJsSXBiUnZJZS9m?= =?utf-8?B?ZnBobkZNc3NidWNaUi84aVVBcWRoWFpRUitRQVE4RzhSZzVwOGNJWlQvUUVT?= =?utf-8?B?VHF2U1RmcmttbnNPR1FHa1Rxb0lwQzlzVWU5NXZwdUxEM0NydUZNVm1SZzBL?= =?utf-8?B?NVVjb2JhR2hsYjFRRlE5VzRIc0o0TWFZSEZHeG01TkNNOVpUZkJMeTN6NnZp?= =?utf-8?B?NTR3bDhibXJSdFBLbklJeUlpMVNYemk2UW11eksweWQ2YUYzV0ZvVWYwZUQx?= =?utf-8?B?bmJtSUZZK1B5Um14dUZ3bUp5WU83eUhZNEpkeHZEdEhMd2M0bmdWeDhQZVl4?= =?utf-8?B?cWdYR0orN2lodUlxM0dBOWlWam9hUU1XSWRCNjJjSjEwS0FIdlUzQXFYd3B0?= =?utf-8?B?cWZhKzczdVdMbHMxeEZSaGRIOEJlMjF6QmFNVmR4R1hpQitVUXNsZDZaOGtB?= =?utf-8?B?ODdnZWVGUjF5S2lpclFPWnR4Y2R6UFhjbm9USFFZL0F0SUsvbGtTQmxDWWxi?= =?utf-8?B?S3lwWndvNnFWMnpNZ0ErSHk4TENEczBUai8vOEpjTm1rRFlQUUZ2NU9vVUVU?= =?utf-8?B?QTIxRG1tUzRyVjNqcjNGZjJnOFJpTFRCMWRqSVU3bUI5WkxsajZ3Z1BKZHBz?= =?utf-8?B?VXFqYmxIbzJlU1dBNHczRnZDaFZPQlVYSllWaXFqaExtbDhtMWpGM2FQZWFm?= =?utf-8?B?cjYxTFNlb1dyVnNRZFdRT3h1bFJwclAwcnl4UGZ3d0drV3J5UGJ1WExBeVVC?= =?utf-8?B?VGY4eFFOejErQ1pYdWxqOFJEb0RQSEU4dklEWUkwQW5CdHB0Ty8vbVRUVHpX?= =?utf-8?B?ZWpPQ1Jna1lwR3ViRHRCemFUM01teU04TVBBR0NQbkJCTkdkOTArMW9RYjgw?= =?utf-8?B?RGFMUzFvd1lvUFlNYkE4NEM2QXBNUHR2UnNkNzN0Q3JBc3hLUWUvSlp6M1VJ?= =?utf-8?B?OXFRbWlZTkowNVZweSs3cmFtbk5XYlNxcDB6S1lRNkJNRVNZZDdSYjdRS0NE?= =?utf-8?B?STdaVlB3NjBTS05HaXQvVUpXSGtTTS9id20zM0YvYkFSUzZLemZyckVVclJM?= =?utf-8?B?aS9iMHVpdDJGZEZvR1RCa2w0OGplNlphRXl3MlM4elBDRG9EZ2NBTmgwTU1w?= =?utf-8?Q?jIXLWPfmuXKkT+A+VC7rlp91c?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f27fec8-0b82-438b-1503-08db190c9b37 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 21:50:13.9936 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EBYdWlmTyjkrEhjgWBDKUJz+wwh8kfhpkoL+1vIkAaY2M7+6k+gnxETF2mkfaKpZ X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5448 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/16/2023 12:30 AM, Mingxia Liu wrote: > Add RSS support. > > Signed-off-by: Mingxia Liu <...> > static int > cpfl_dev_configure(struct rte_eth_dev *dev) > { > struct idpf_vport *vport = dev->data->dev_private; > struct rte_eth_conf *conf = &dev->data->dev_conf; > + struct idpf_adapter *adapter = vport->adapter; > + int ret; > > if (conf->link_speeds & RTE_ETH_LINK_SPEED_FIXED) { > PMD_INIT_LOG(ERR, "Setting link speed is not supported"); > @@ -205,6 +245,17 @@ cpfl_dev_configure(struct rte_eth_dev *dev) > return -ENOTSUP; > } > > + if (adapter->caps.rss_caps != 0 && dev->data->nb_rx_queues != 0) { > + ret = cpfl_init_rss(vport); > + if (ret != 0) { > + PMD_INIT_LOG(ERR, "Failed to init rss"); > + return ret; > + } > + } else { > + PMD_INIT_LOG(ERR, "RSS is not supported."); > + return -1; > + } Shouldn't driver take into account 'conf->rxmode->mq_mode' and 'conf->rx_adv_conf->rss_conf->*' ?