From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 519F2A046B for ; Tue, 23 Jul 2019 11:11:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B0FBD1BFC5; Tue, 23 Jul 2019 11:11:02 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 9E1991BF85 for ; Tue, 23 Jul 2019 11:11:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jul 2019 02:11:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,298,1559545200"; d="scan'208";a="174486475" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.83]) ([10.237.220.83]) by orsmga006.jf.intel.com with ESMTP; 23 Jul 2019 02:10:59 -0700 To: Thomas Monjalon Cc: dev@dpdk.org References: <20190718093432.14092-1-thomas@monjalon.net> <20190722165505.14745-1-thomas@monjalon.net> <1594287.eYpNOEoKs5@xps> From: "Burakov, Anatoly" Message-ID: <0cadf7e8-aa2e-21a1-25ba-5cac28f0493b@intel.com> Date: Tue, 23 Jul 2019 10:10:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1594287.eYpNOEoKs5@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal: warn on legacy memory allocation requirement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 22-Jul-19 6:03 PM, Thomas Monjalon wrote: > 22/07/2019 18:55, Thomas Monjalon: >> When using --no-huge mode, dynamic allocation is not supported. >> Because of this limitation, the option --legacy-mem is implied >> and -m may be needed to specify the amount of memory to allocate. >> Otherwise the default amount MEMSIZE_IF_NO_HUGE_PAGE will be allocated. >> >> Signed-off-by: Thomas Monjalon >> --- >> v2: >> - user-oriented message >> - trigger warning on any legacy mem option >> --- >> --- a/lib/librte_eal/common/eal_common_options.c >> +++ b/lib/librte_eal/common/eal_common_options.c >> + if (internal_cfg->legacy_mem && internal_cfg->memory == 0) { >> + RTE_LOG(NOTICE, EAL, "Selected memory layout is static, " >> + "allocation can be increased with the option -m\n"); > > Or better: > > "Static memory layout is selected," > "allocation can be increased with the option -m\n" > Allocation of what? :) Without context, the message makes little sense. How about: "Selected memory layout is static, amount of reserved memory can be adjusted with the option -m or --socket-mem". The slight issue there is, --socket-mem works with legacy mem, but not with no-huge. However, i think --socket-mem will produce its own error on attempt to use it with --no-huge, so i don't think it's a big deal. -- Thanks, Anatoly