From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8006A09FF; Wed, 6 Jan 2021 17:37:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D413140D64; Wed, 6 Jan 2021 17:37:21 +0100 (CET) Received: from qrelay146.mxroute.com (qrelay146.mxroute.com [172.82.139.146]) by mails.dpdk.org (Postfix) with ESMTP id 1B39740FA7 for ; Wed, 6 Jan 2021 17:37:20 +0100 (CET) Received: from filter003.mxroute.com ([168.235.111.26] 168-235-111-26.cloud.ramnode.com) (Authenticated sender: mN4UYu2MZsgR) by qrelay146.mxroute.com (ZoneMTA) with ESMTPA id 176d88f452f000a57c.002 for ; Wed, 06 Jan 2021 16:37:16 +0000 X-Zone-Loop: e044f6551082df1066d8feb6690f5f0fbd76f8fee5cc X-Originating-IP: [168.235.111.26] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter003.mxroute.com (Postfix) with ESMTPS id 5F67162B2A; Wed, 6 Jan 2021 16:37:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aregE1UgNVdbynblMsWOJygQb3jEUhV0okx2JQ8KnjE=; b=FhT/MkeEfDchuRuGuG3RhkIt9t KamdWijedhm3nsGULErlFPoQTk5e7zrsTMwSSRPeOhSfOdbB4RbonRDWJRQ9bcLp/XimZRjackzy2 ggdYHHJmHL2OP7lh2+gKC+9wWoGP/sk3SALc4txc4rvEvTLuQdNzy9Kg4I9gPDkLzF5UCazsDGQ1a SUpHT1Zj8q9cZc8MEsy3bbk2+Qln2YSnmDbTFw5Gnim0uTZPTYkswX1wCXcazIFtSAB6I7t4+f8OV l+Wsj+H33iyyW3QEoCpOEVovUR681dlUnUC8F59GS7cVcTRGCAe6hA+F7M76PctLxYbHLZyRgQ/94 tIgRCjcA==; To: Thomas Monjalon , Maxime Coquelin , David Marchand Cc: dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata References: <20201220211405.313012-1-maxime.coquelin@redhat.com> <20201220211405.313012-9-maxime.coquelin@redhat.com> <13089839.ugh3R6DZUH@thomas> From: "Kinsella, Ray" Message-ID: <0cb91285-5c66-94b2-638a-779f5e466bce@ashroe.eu> Date: Wed, 6 Jan 2021 16:37:12 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <13089839.ugh3R6DZUH@thomas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH 08/40] net/virtio: force IOVA as VA mode for Virtio-user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/01/2021 09:11, Thomas Monjalon wrote: > 06/01/2021 10:06, David Marchand: >> On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin >> wrote: >>> diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c >>> index 1f1f63a1a5..f4775ff141 100644 >>> --- a/drivers/net/virtio/virtio_user_ethdev.c >>> +++ b/drivers/net/virtio/virtio_user_ethdev.c >>> @@ -663,6 +663,17 @@ virtio_user_pmd_probe(struct rte_vdev_device *vdev) >>> char *mac_addr = NULL; >>> int ret = -1; >>> >>> + /* >>> + * ToDo 1: Implement detection mechanism at vdev bus level as PCI, but >>> + * it implies API breakage. >> >> Extending rte_vdev_driver to implement this detection would be an ABI breakage. >> This is a driver-only API (rte_vdev_driver is only used by the vdev >> bus and drivers afaics). >> >> Doing this is allowed as per my understanding of the ABI policy which >> guarantees ABI stability for applications. >> We do not guarantee this stability for OOT drivers. > > I agree. > As a reminder, the A in ABI stands for Application. > +1, as long as the binary interface remains the same, we are good.