From: "Sachin Saxena (OSS)" <sachin.saxena@oss.nxp.com>
To: rohit.raj@nxp.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] bus/fslmc: fix dpio close
Date: Thu, 6 Aug 2020 20:02:40 +0530 [thread overview]
Message-ID: <0cd84dc2-648a-62ed-a004-7bff35b864b2@oss.nxp.com> (raw)
In-Reply-To: <20200728162459.990-1-rohit.raj@nxp.com>
Acked-by: Sachin Saxena<sachin.saxena@oss.nxp.com>
On 28-Jul-20 9:54 PM, rohit.raj@nxp.com wrote:
> From: Rohit Raj <rohit.raj@nxp.com>
>
> The current state of the DPIO object should be checked
> before trying to close/disable the object.
>
> Fixes: 293c0ca94c36 ("bus/fslmc: support memory backed portals with QBMAN 5.0")
> Cc: stable@dpdk.org
>
> Signed-off-by: Rohit Raj <rohit.raj@nxp.com>
> ---
> drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c
> index 97be76116..b0055b164 100644
> --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c
> +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c
> @@ -528,8 +528,13 @@ dpaa2_create_dpio_device(int vdev_fd,
>
> err:
> if (dpio_dev->dpio) {
> - dpio_disable(dpio_dev->dpio, CMD_PRI_LOW, dpio_dev->token);
> - dpio_close(dpio_dev->dpio, CMD_PRI_LOW, dpio_dev->token);
> + if (dpio_dev->token) {
> + dpio_disable(dpio_dev->dpio, CMD_PRI_LOW,
> + dpio_dev->token);
> + dpio_close(dpio_dev->dpio, CMD_PRI_LOW,
> + dpio_dev->token);
> + }
> +
> rte_free(dpio_dev->eqresp);
> rte_free(dpio_dev->dpio);
> }
next prev parent reply other threads:[~2020-08-06 14:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 16:24 rohit.raj
2020-08-06 14:32 ` Sachin Saxena (OSS) [this message]
2020-10-06 8:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cd84dc2-648a-62ed-a004-7bff35b864b2@oss.nxp.com \
--to=sachin.saxena@oss.nxp.com \
--cc=dev@dpdk.org \
--cc=rohit.raj@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).