From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2A3DA0C41; Wed, 20 Oct 2021 00:05:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B0CD740687; Wed, 20 Oct 2021 00:05:49 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 34F0240142 for ; Wed, 20 Oct 2021 00:05:48 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="314842254" X-IronPort-AV: E=Sophos;i="5.87,164,1631602800"; d="scan'208";a="314842254" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 15:05:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,164,1631602800"; d="scan'208";a="720212253" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga005.fm.intel.com with ESMTP; 19 Oct 2021 15:05:47 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 15:05:46 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 19 Oct 2021 15:05:46 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.47) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 19 Oct 2021 15:05:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EunHKsB0DxbV6Qv9yq+dDJRa/EGxygYXaxTSATixfdto6oYGIwCmtVra6wKU7HU45y29TNnu14jJMa8zmsBF5j1nCaouHQed/F3zZa/5q+f/1f2y3hKX5f46DLxXrFHCuy/4eupGGdirvIuhfD2z/WA9UcKraf79BJElN9GcMaaPgHZsrXdvNTBIwkiHWAswt7MTM5x4tktOmVsxkDK7q7eAgPFI+PwPv1pCU/1CQ5A56w20McLx4Q7x5raYI85yhC3wUsS25Zrd4ql7gv5g4nTjK1Qo0Tl0I0EaPpm9+mksmOTW7jSQaGNpHmCIiHQ43QkP23v//oiArOXi2vvLqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RFJ0cnPAwnU0LGhijRjvbeUB5WsO3KsgSnsn2t2o4Sw=; b=NiIkQ1W9lNplE7ZoAyfzw0FTtp2/Vs356GRlK1L7cFvvkGZWjsVVO7i6UVSwFiPTdNIn+t5IKtsibLirHy6B1UoZx/5TG22Ko84s987yD8pZ4fNdTZKkk+Np4O15YGH/Seaz2KLJS6mPEN2myZNws6pmX2TadR1ogSFzLAUjGTKQgsGpVv/1XkwbyYjGpGLWoEIvIAIBDfujzrHg+C/I//+VzpmOPCXCDN4RsIUI2SDMHrFt9Xm4+W8MucVkJ5WQBrU21WOiq6Tpraxf+zY0uV8qnEL0Q8O7Gl8c74g/mb8dlZwerNIJS2q0T1IuV45wvQoWlRdfig0S/QZw5nbz6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RFJ0cnPAwnU0LGhijRjvbeUB5WsO3KsgSnsn2t2o4Sw=; b=Av3AWN9HKEyUtwwI5BLm842EC1VOPV96ox5abIszMi32NyrZrniLpfqYmtfbgr66dDnQqlw6fh8F3YPgv8zxNnhl0J3csA1e6ucejMyXHDTmhhYYQp2JuzKm0T3WVQcKDIc+3okB/r/Mq6HHhh/AFk3oMDjz2PCdo/H2rSuhzTk= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5926.namprd11.prod.outlook.com (2603:10b6:510:14d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Tue, 19 Oct 2021 22:05:45 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 22:05:45 +0000 Message-ID: <0ce43d7d-2d01-d332-1a22-1062a7ea489e@intel.com> Date: Tue, 19 Oct 2021 23:05:39 +0100 Content-Language: en-US To: Andrew Rybchenko CC: , Thomas Monjalon , Konstantin Ananyev References: <20211014083704.2542493-1-andrew.rybchenko@oktetlabs.ru> <6fede0ad-5858-9423-3e86-1170269d01b4@intel.com> <945d03fb-251b-eb75-f815-950754652b7b@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <945d03fb-251b-eb75-f815-950754652b7b@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6P195CA0013.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::23) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6P195CA0013.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Tue, 19 Oct 2021 22:05:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84b7cdc2-fa43-42f7-98b3-08d9934c9940 X-MS-TrafficTypeDiagnostic: PH0PR11MB5926: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NOoVYGSucobsHQ4CT3Gw96+3wKyyBJZJZFRZwFHQBPCN1t/fjcXRBOj05YM8Ll1O//SN9e9jWjxc3zyi2hMbyNnwyQK+7koLWYuQFL59BkEOEYR32rbu+U1hwnj7vU3xPHdeFK+gPwVm579Ox01cFBji/9jez/2v1pj+Rnn5sluiho50hdZp79xbJh5UzVMsaYjYZToUbl60fgOzNdP1URlJTxFB1uWTAwKkFKj1mmQhuk3/b4n4VWAhc6knDuadExyOU/Xt7E8G0VE5csxl2UZ+NZbYhpOYBStHHDskyktO/LzP3ZbJYVi+7y4nmyUkQKDI2dyeRAZgdEsq2fwmI7cGJx3VhuCAgP3HlxjGHGLJzC0kf3etNNsTSbz4NHkG8b/t3phPAQgFN8Jd9OieOyOO8Ksvv3rM/Gz+E6yPKE3LY6yNSD074Zqa2tbrDwWqHZGEzwBmgM/GsU+r4ljPhe//3FTt0iaJ5P4ff3AnyiWIjzmwAGmsTUpEqhSWmEPoD5ydSP5DiQZ383tphskUc0P1tzbLwPMuGGum3xfmwxWZSMC1zjCzVvqsnW+cWeYrstOUWVc/WIcY1m3RlnoWnBVzqN3Uzb9E8rfHj8uQqNgQlVjNJpOsTevnBal4fqWsnuuI5uWDBtXFDPHqsFxubA1F5LzReAOgPllL2LZXAvGQ8bU0PhydzgKnzbhTrDrOF2MjNt0+bqBMu5uiSmELHA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(107886003)(2906002)(36756003)(6666004)(38100700002)(6486002)(8676002)(66946007)(26005)(53546011)(54906003)(6916009)(31696002)(5660300002)(4326008)(86362001)(508600001)(83380400001)(8936002)(82960400001)(66556008)(186003)(316002)(44832011)(956004)(66476007)(31686004)(2616005)(16576012)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YlkrYXZCREFvTEhrM0F0WmJPM054Q3JhY1h5Mm41am9DMjJPY3NBRzdSVm1G?= =?utf-8?B?MERHT1RCakVVSDVwODhzYWlnTmtsbUt5VDRmV0dkNVVTeWVxUy8yNzNML2Rw?= =?utf-8?B?SVFiVHVZZEZEN1lQdFlvZlc1WUV6SnpsV3diQncrbzNFZ3UxQjdYdUdWQXVx?= =?utf-8?B?TVpaN2RjcU1JUWd4RXhOWWRaMVpHWkg3dkdud2VIZm9hWnJlZmRZVGtzSmIy?= =?utf-8?B?dU8xak9ITHRDUGRvM0pqSE9LQXpBQUhtWmZUaHVWSDEyZ0V6cmZkc1MrRHZ2?= =?utf-8?B?R3pKSlZVVEYyM1dCaWJMOVJTZTRRNjVWb1I0ME9uSjBhT2x5Z004eXVrTjZu?= =?utf-8?B?WFV4UE5qak44MlZ4L21jUzFXMGZ1Yjk0ZTVuSXVJRkxRcE1jOUNHZGl0WXdY?= =?utf-8?B?Tm1udTF1N3VxNmhGWEtYSVJTd3daRmpnaTd5NWJOWUpvVVpzTkxqRnBOSFpz?= =?utf-8?B?UHVOZExKWVZPeG5KTEtYUmRNVVl2WnRnWHhsSzh3VUlpWkNiVEpUcUsxVjJ5?= =?utf-8?B?aTJMZVRDR3lOcVVac2JnbzJUUjRDd292ODRreG1FQU1HRWkybUFjSEN1WWV6?= =?utf-8?B?TklHYnpwREkvRWNTS1lrSkdWVnM3bkEyeklQajkxRGVrQm5sMDhsQ1lra29n?= =?utf-8?B?cDVFRG94c1A2ZUpZN0E3ZUNhdVFmVXV1Zko0RjJnekhOSWVyN2ErY0pzcEpi?= =?utf-8?B?UXB1Q2E4UkxTYjhSYXZnVnpXcVJoSzJOTFQvODJMWUhrZXRPaXF6RWxyYWl5?= =?utf-8?B?R2xETjVIMFQ0MkdZQXdaUVZOZ3NROWdsbFRXT21uaTR3MHAwZTh2Umsyam12?= =?utf-8?B?Y3pnS21DWHc0NkdjOUJjY09tbnBFbUt0eFNlTnRXeGtiTUJGbGExdWNzQVhI?= =?utf-8?B?YXBybFJHbURvRDdPTElGc1FZdXBGZ1dtckNjR2ZGai9QK3lPUUFsTWpMZjRW?= =?utf-8?B?SDBpREx1TGRWM3VGdGZ1cU5LMURSSTV6a1k5b3hMUUMvTjQyTEZ0TjRzdmJD?= =?utf-8?B?aTRrWE1BcDlmYjA1RVNPT1pSTEJYaTFkNWR2MWlwT0hxNTZheUF4d1VnT1Rt?= =?utf-8?B?NFB6dEVXejdJNjVVRStSd2FTTzkvNUFuM1NnMUptWHhpTXQva3JpNzZSV0lq?= =?utf-8?B?Nkk3RFcrMTlBU3NiM05NSXk1aEkrLzZwWGc5U3BZK05yYjFQZkRxL2p3R2ZH?= =?utf-8?B?M0hSc2JTcG00SXVuVUxyeFVpaWg0d2NkR0VrRGRDK3g1QkVmYmpRNHlRTkkr?= =?utf-8?B?WDUvTW5rMENIcjltVnNjMlA4Nko2YWZJZmp5NmhrOW5xYlkxN3Nhc3Q3TWw1?= =?utf-8?B?OVczd0dZWlRuK1NUNXpDL1hscGZOM1g5NTZNcmJqaUlDMXR3V0dQUzdHT2RN?= =?utf-8?B?WWtzYnNVUURQaTk5ZnZTSktoTlg5eWxhQ20vRlp1anlTM2VieFNvZEtUeXRC?= =?utf-8?B?SFdrNjE5RlNIS2dONzFGNTNCU3Uzdk5nL0phMzlmU2Uza0JBMmVlWW8yQ053?= =?utf-8?B?NjhTWTRGWE9NaXZqZVNSeGVZMmFTTTZicEFwWmtvT29lNGFPY3BOVWhNSEZO?= =?utf-8?B?VUc4TjNqNnROS3ZLbmhKUTJxdDYwc1BVZFBUeEhpS2hMS0dTNHl2cUtQeWNn?= =?utf-8?B?SVkyR1BwMUJDUEpORlFMajNLZVIwK0Q0NGt6UGxMc1FTMFMwa0Z1czA2WHls?= =?utf-8?B?UlAzUVMrVnBvVEtWNEJUYTZnOGtPdWJJQlhSK3VOTmxEaTNTdjVmeE5qMTRJ?= =?utf-8?Q?jvz1kPZlsTW8kIWj1KUkvLQ0YC00rZ3zPR6p0pw?= X-MS-Exchange-CrossTenant-Network-Message-Id: 84b7cdc2-fa43-42f7-98b3-08d9934c9940 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 22:05:44.9880 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jJYbt/15D+OSN8EAkjxO+Lz7nrBS1cZzaRt69pKOQAYXCzoc83KuR0QvVHn/QmGwVYZ0sKhNjytx/Ynvc6DMwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5926 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 0/5] ethdev: cosmetic fixes for just moved structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/19/2021 7:07 PM, Andrew Rybchenko wrote: > On 10/19/21 2:55 PM, Ferruh Yigit wrote: >> On 10/14/2021 9:36 AM, Andrew Rybchenko wrote: >>> Sicne rte_eth_dev and rte_eth_dev_data structures are just moved >>> right now is a good chance to make a cleanup. >>> >>> No strong opinion, but I think it would be useful for the future. >>> >>> Make be at least some fixes from below could be accepted. >>> >>> Andrew Rybchenko (5): >>>    ethdev: avoid documentation in next lines >>>    ethdev: fix Rx/Tx spelling in just moved structures >>>    ethdev: remove reserved fields from internal structures >>>    ethdev: make device and data structures readable >>>    ethdev: remove full stop after short comments and references >>> >> >> Overall +1 to these changes, I think this release is the opportunity >> to have changes like this. >> >> But as far as I can see only new moved code updated in 'ethdev_driver.h', >> why not update whole 'ethdev_driver.h'? > > Simply don't want to complicate search by git blame because of cosmetic > changes. No strong opinion, but decided to go this way for now. Normally agree to NOT get cosmetic changes because the reason you mentioned, noise in the git history. But in this release we already shuffled things a bit, that is why I think it is good opportunity to get these kind of changes. Also there will be some inconsistencies in 'ethdev_driver.h' after your changes, like 'RX' -> 'Rx' change done in one patch, but half of the file still uses 'RX'. I also don't have strong opinion, but my preference is either fix all, or none. Lets get some more comments.