From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 406E942369; Wed, 11 Oct 2023 20:00:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C74C8400EF; Wed, 11 Oct 2023 20:00:12 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2072.outbound.protection.outlook.com [40.107.220.72]) by mails.dpdk.org (Postfix) with ESMTP id C371E400D7 for ; Wed, 11 Oct 2023 20:00:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RZ79r9LT3Lyo+BITejHZhOD1dFxUM3BJFrTIk0KKjILSapvRP2OpDLaOaoAfMBPG726ferT8CGX6qPEvfPkL67zZ+CPFX4tVjjNmhVeFsyJTqwTOjJDZCXQiKdLBKHjVGR0wKUatR6IYPDZE+6G83kC4sIDVfCvecMlx/RogsV7DQU52ksEJeG+NvAZp1VcpyNz7VFnjaQvjARhmJT173WKRiu/shRYKAA9Qne+Ot+B7udMrYQNrBtEuVk0X3OLTC+NYxNu3YyLUWiGAmUvp3KBk3Tdw43CgqXMKg5CnZaD0fBeVjPFRFsSQrDGA/wZOZ7isysXkY70eeXSXXtdlnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p1YvNoFuu/oR3Y9rX8whlC1PlMmRoeOpg6r00YPLknE=; b=BVfFficPROloB+YTEzuDM6iLSpdzzvQ5+5eVbaGKztECGZ+iGcd8Xb5S+dTHiGGpu/fls/PuMVSE6PO0qk2rEuImGe9ImCByQSxem8KMpaWMRAXUpfL/kppu2+44Iwco6dM5KmvtJSZdDebEMxH/Gbm+S4CE5orFdicGm1LAjG6+FU/QGmo2tGlqYTPX8whuwaNepeuY7iJQRlYxJQp1QEG+bRzb/49/6W9373OeQHGaHOzulfDtLonrG4t7KvBbKKV5zuZk8de53IjcQs/o/hJatqa0CX1eBN8sz+J/GLp6tSM7Zj88OWrLGPYbj2VBV37iLD44QLBZWOJvr745Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p1YvNoFuu/oR3Y9rX8whlC1PlMmRoeOpg6r00YPLknE=; b=fy05wQ7XgBNwUY2SmcMS0BpP9GlaTkqRAGOujC+0Cfh/oWy9LzfiHz1xO6AIG/6iIU/A9iaCTgt5oHSK4zoSNLt+78mf+N3CPv/cIizZMb16PKk0mAk4PvggHa2a7p1s5rl2oR7mTAIVuFbo2/BjrYHkgifx/UygM6O34ux+X7s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4328.namprd12.prod.outlook.com (2603:10b6:610:a6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Wed, 11 Oct 2023 18:00:08 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6863.032; Wed, 11 Oct 2023 18:00:08 +0000 Message-ID: <0cf0a446-54ce-4bee-8ba6-c00ded26d923@amd.com> Date: Wed, 11 Oct 2023 19:00:02 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 26/40] net/mvpp2: check RSS hash algorithms Content-Language: en-US To: Jie Hai , dev@dpdk.org, Liron Himi Cc: lihuisong@huawei.com, fengchengwen@huawei.com, liudongdong3@huawei.com References: <20230908080030.3837515-1-haijie1@huawei.com> <20231011092805.693171-1-haijie1@huawei.com> <20231011092805.693171-27-haijie1@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20231011092805.693171-27-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0092.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::32) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4328:EE_ X-MS-Office365-Filtering-Correlation-Id: 177eec02-a5f1-4f1f-725b-08dbca83e7cf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +6StO8Ks3X1HH8IzR8AXIITLHhbTEhgQj3E29gERmrdmF/CxfCJ7oErzdVuo/ZusyKWC08K0fcYgCa9Gys3f/lYBLJ3hlVzQVrqhqclh/dh5dJTOWxo2gX8VpteALNzuWQZe2R9phd8iFezbZRoulNssuNQr8QO6JwzxE+d8+f1RNj4e/XbAHXGLgfZgFigErSwLVe6vhRcfOOG3OjgPkRD7E1fXguQ37z9jneOKSzR6GNR1Jou5qbZr8UeRmBV5lQaTYd+/Rda2vuRu8dd9kAVEujsc8IrZ7keQIAt+tA5LbAYWGTkDMTCn3u9DZNS55DPRWhBgc5Mjqa/yxm5XDMuMkNOkrUmKjDXj//Np8fLl/1E8r/QF7/Vm5uy7YOk+JvL0yA8mpccBFk6XUVbOUWJtZtGszpO64Q43nl5+W3xC5tWiHgppaxqYJC7tkxKvB3PrC7koqMqNHiN8sa89vQW90kUJZNmqi27iwYdPZjJ8ZQ6/F10SD2I1XJ5M7GBJJYXOCq1rlC6Pt5YpNKAJtAt3LgZK6wuPeXpWd3n7RE5wejVENpNb2utCkVRKrseYJMuorCFIiHGt6cxDgbXR9E9Q48ewtOm8+N351CGcrCQI1AjvNNq+lXb3Ql/yKIn6LMrbW2Zhp/Qs7MqWa7oKJA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(396003)(136003)(39860400002)(366004)(230922051799003)(186009)(451199024)(64100799003)(1800799009)(31696002)(38100700002)(86362001)(36756003)(31686004)(6512007)(41300700001)(6486002)(4744005)(8676002)(478600001)(5660300002)(8936002)(2906002)(44832011)(66946007)(6666004)(6506007)(4326008)(2616005)(66556008)(110136005)(316002)(66476007)(53546011)(83380400001)(26005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TU1xWVRuUksyc1hOb2gwMFJQMzF6WWVocVRxekhsdHRmQ1NZTkxwcDFEaDM2?= =?utf-8?B?dXg5aVZOSjlaSTJjZFFrR0VkWHNsbjV3RjlScVZlc3NkMGMzbFFVc0JVWEpP?= =?utf-8?B?VHRVMWFtY3Zhd0svNGFSak04dDVwalZpZU4xRG95RUlDbkh5bmJYUmtWWGtz?= =?utf-8?B?SHhJWS96dzJCQ2xGZzhXRm9FQW9ldi9mQW9EVGhFLzdqbXlCQXI2a3dJaDQ4?= =?utf-8?B?WnkwVWNNemJSdzVEak1DTFFXSlFxTXdyb2sxNVczaUprdlZ6ZXdxUGw3OTF5?= =?utf-8?B?MER0cnp1VEVKS1E4TzA1ejh2VWVQRVBoUXJZeVdBbGJYYTZYMTRYTVZqa1Az?= =?utf-8?B?UDFNc3JmVlZjRHR6UFNVeU1vdDVqdVZWb1RqWWFtczJlWXdudmYydmxydGxH?= =?utf-8?B?VzFQZkdHYVRCTjlIMzkzT0drZGs2dlh3ZGFVYWY0TVhpTFBQUm9SdjFidTJ0?= =?utf-8?B?Y2R5ZTYwM1FYaTBQR2FaSm5jYlcrNWFZK2dJZnpTMnd1N2lrWkpYNG5hdVUw?= =?utf-8?B?VU9SMmNqY0dtUnBIWm1aNkxvSlIrS3Voa28vMm5mek1GNnNuR0YxVEZQeEls?= =?utf-8?B?aVdaQytPdmlobUZhUXBBazRONHVROTdMcDZHYklYb2VaMk9GVXZMUkl6M1Vm?= =?utf-8?B?QmxqQzNPME9XUjFjQ1Y5eWlVODlYdzE2RDFIUGZOTzJvYUtwVGk3OEtGN3ls?= =?utf-8?B?bTNWTkIvVHRaUmVBT1hjb0pxTThUUVBFRUlxRkRkdm1INnIwelpyVUN6MFlj?= =?utf-8?B?Tzc5RStya2JtbWpCMVpjNEJTYVdRZEZ0L0hEcUZDSDdOc0k1U1FreTMwZ0NU?= =?utf-8?B?UEFLTXNmbXJIMHpxemd4d1UwTHlIQi91K1AwQTBVS1RmaXovUEJ4Mlc2TjI1?= =?utf-8?B?T0tqdTE1YWNLbGFSdjVGdUJhRE9aZGJ0dE90a3lOdDQ1aFh1b2FobEVKamx2?= =?utf-8?B?UENtT3c2WFJiTXE1TUV1UGc5T1Q5THh6ZW1Vd0JYcWR2RmtmYzErMlU3eGdw?= =?utf-8?B?cURqM3gwN0t2dVpmUjJ1cG10NnV3OFhHWnd6V2RCbmQrblZnOGJoa2x2Rk1h?= =?utf-8?B?a2pKcnNIZVRCSFFYRDl6amZucytxYU1ZL0x2TS9zZnJ4RFBiR3VhUmYvR3Ew?= =?utf-8?B?eGRqUDBkS2tDNFZpOWsvSjNxQzAzMzl3bFFqaGNFalVKcU43TmxvM3NvZ3pR?= =?utf-8?B?Q2dObUppZTMwUHFmNzBXc001VnBib3RnWFdNV2w1UHcrZmFIYWdmUVh5MlBy?= =?utf-8?B?WGc1NDBvL3ZmQmF1b0FUMW0xQmEyZE5TRjN6NWw1Zk1hcHFqUVVheG05WDVu?= =?utf-8?B?ZHp1MGdnTGlIRklIdjZSV3RjVXhLMHk4MUpVVk1XejFnQ0QyTzNWa3hwR0J4?= =?utf-8?B?NWEvTmRyZGsrdnhjQkhXVGNSdTRWbXhwbDdmNEVhU2dzQW1EZHZhQWZ6aGVC?= =?utf-8?B?RS9hYlU3TG4rSDdvenJ0d3QrQXRKMFFrSEYrMEtzRWd0TDA4NUoyZktvM2ZG?= =?utf-8?B?Z25Fd05BYUEzOHpIbWV4NjhxSXNscUtiVTd2UGY0SHZxQVVlZW1OQmIwUWtl?= =?utf-8?B?QmdVRi85YjJhZ1h0MCt1QjJyQnlDdWpwazdjOHJMb2p2akJCaUdDbUxyUjZY?= =?utf-8?B?YXpSVVNIajRER3NLdk9RazBPbm01VDNMaUo5RS9YRklpOHZHZHFzeEFMQklI?= =?utf-8?B?T3ozTUYxSW9YdTVWd3JyUTRaTmJocFEwbENmVkJSWGtXMktSVU0wSE1GWGNw?= =?utf-8?B?bmFXVkE3VzhseG96NTBGZXNEam51SDZ3andmekdTQUNKTGlIWURHbXdUV29y?= =?utf-8?B?VXA4VVhvVW1DcWRZWnYxV0hKYlFpRXBNaVE4NmxhcGxaWEtQcEpLRy9BOWh6?= =?utf-8?B?Y0J6c2JiMDh1T2pxWDRpaWN0bmQ1R2pnTTBtTSt5enVZV1hFN3hDSW9NaWgz?= =?utf-8?B?eEt0ZnBGaHV3NFJwQmpsdzBLR2ZUbWxHcHU0d0tCN1M1amRFYkpaTkN1Z3JO?= =?utf-8?B?YWxaUzkwWmg5K1BDMzFMcnlOMmQ2eE5SblhBOXcrSFcycmlndTVuemN3dGZL?= =?utf-8?B?OThTS1lVUmdNYnU2UHlzRFNSUGJKL25CZ2JZMkN0QnBoL08xTmJydTN2NVpw?= =?utf-8?Q?boyGgxwR9VuWQO+tyEHF5WO1t?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 177eec02-a5f1-4f1f-725b-08dbca83e7cf X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 18:00:08.3983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iDh1O3k/NqJmRY1/rxC1cQgEt2E1I54rL5E1hvzRA1TziYYtyfGAZF74H42O3HGu X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4328 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/11/2023 10:27 AM, Jie Hai wrote: > A new field 'algorithm' has been added to rss_conf, check it > in case of ignoring unsupported values. > > Signed-off-by: Jie Hai > --- > drivers/net/mvpp2/mrvl_ethdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c > index 359a5d1df7ab..817153af2ef1 100644 > --- a/drivers/net/mvpp2/mrvl_ethdev.c > +++ b/drivers/net/mvpp2/mrvl_ethdev.c > @@ -440,6 +440,9 @@ mrvl_configure_rss(struct mrvl_priv *priv, struct rte_eth_rss_conf *rss_conf) > if (rss_conf->rss_key) > MRVL_LOG(WARNING, "Changing hash key is not supported"); > > + if (rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT) > + return -EINVAL; > + > if (rss_conf->rss_hf == 0) { > priv->ppio_params.inqs_params.hash_type = PP2_PPIO_HASH_T_NONE; > } else if (rss_conf->rss_hf & RTE_ETH_RSS_IPV4) { what about updating 'mrvl_dev_configure()' ?