From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FAA5457FF; Tue, 20 Aug 2024 11:56:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BFB0A4026C; Tue, 20 Aug 2024 11:56:32 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 2D51E400D6 for ; Tue, 20 Aug 2024 11:56:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724147791; x=1755683791; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=86ZwAu4VTpCLYDH8jK+yp/TxRaL5PlTzFUzRunzywbc=; b=Bjj3tDVL5QA8xJmKt1q4cf82Y9T6I++/Py3YOv8zbF7kcviA34oxpQfA MgwWLiS7mutr0aY04EPeQnR1oJ40zYJKYEO2Vcyhv+TpXAcVltLr26WVG q0hPneBLREtMVSdPbj2TzD5o50XDj7jZ2/WWWJe8eTFxh9EhKwlcBy2fy tuBsicLubCW9wlxY+K+3XMqMU6KKfGiglKIsbw7CY1eSLD0Pp6Mc4YRLj UQGRid8amqWNV4XDNLlt/F4vOQlM84L8SiL1c6RLT6lrST33+g3RFyIit s36L6MNtrGTsKk359SNNU/VB1PLVXctAd0yyaHXVGX7T+7OO/U900s3vD Q==; X-CSE-ConnectionGUID: BnRzTXqkSiqAdPJ8c8Sjag== X-CSE-MsgGUID: 6TWXJov6TVKbI7xoT/OdsQ== X-IronPort-AV: E=McAfee;i="6700,10204,11169"; a="26186045" X-IronPort-AV: E=Sophos;i="6.10,161,1719903600"; d="scan'208";a="26186045" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2024 02:56:30 -0700 X-CSE-ConnectionGUID: pFC1VmSSQ1mAUI6STdMDcA== X-CSE-MsgGUID: lGAgjnI4TVi3hu+3u3uJ5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,161,1719903600"; d="scan'208";a="60370802" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Aug 2024 02:56:29 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 20 Aug 2024 02:56:28 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 20 Aug 2024 02:56:28 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 20 Aug 2024 02:56:28 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 20 Aug 2024 02:56:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CCQeu2ftb93i4Sopg588Fj3FPo424GJbY01PpoAW+6PJtyIVp6g1keYdhR0L/PD2epJ8IjVnW/LWcIoJvYPR8JM7lxTwKWm5T1Fo5t165+gOuC5GyCb5hMk4invADpKMrbyqZvDcKVZjoRSSmvxfP9XskVVlFppBEJ0S2Upds4nt0derMVj8Hf3HdjRD9DbMS1yBK4nJyr58e54/75HeSMeff/vDF9/mCv/hdyACQYmN6zz+apgBXSA0a8SSVFk/IDQTPZhDymqUCRi3Ub/dyfc4AEBjs47+c+JMnBgSZmNpMJeITWwXmMbO0VyjNkto4NsjYGMZhwS/u/eT577icA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zKlXc9UiF+rmfrKshq5QS2W7xY+RYzRaK2bQaf4vTT4=; b=x8YhvLo7wulcXB1WYk3O5qRxE+D2ZIQWjkeFiydjuXpytPU5jVr9+DXMQQwNxUstM5ehkW4I13UR6jre7zpA+ugbN0jK0FbiB5QbDclXQDDszYJxhz0/QNj+ROT54dkHJWON8aW9njqhwISRXoGjJoozemesy4tOSmtFa3+mTwJnILeIH4Zo7rnweAmZdTtEs+dOzchfyQ2/W2Er4igOpTcrFUDZocAmgaFY1M7131+VegyKSfr2RSUshCyMo/V4+Omi05uyh+P86R93nLVIdxgyCE5rks9C5wWT6vymJ4V959eEzGVjTIoKOE3HMvmzJ+BRJUWei3m+l6lMeh/4zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by PH8PR11MB6778.namprd11.prod.outlook.com (2603:10b6:510:1c9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.19; Tue, 20 Aug 2024 09:56:26 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%7]) with mapi id 15.20.7897.014; Tue, 20 Aug 2024 09:56:25 +0000 Message-ID: <0cf4d078-5721-4b27-8960-f449bcd26d26@intel.com> Date: Tue, 20 Aug 2024 11:56:18 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] usertools/dpdk-devbind: print NUMA node To: Robin Jarry , CC: References: <7dd3a055-d2ce-4dd9-b9df-ae95e69d4417@intel.com> Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0243.eurprd04.prod.outlook.com (2603:10a6:10:28e::8) To PH7PR11MB6498.namprd11.prod.outlook.com (2603:10b6:510:1f1::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|PH8PR11MB6778:EE_ X-MS-Office365-Filtering-Correlation-Id: 78d1ac3a-ae0d-459f-4197-08dcc0fe5a43 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?T2t3L1lPTnpUS2gxRkpHcHUwTjlJaWRMN1JUNnpzdWhPN0VHd1NZT3lFZGI0?= =?utf-8?B?VmM2WXJTakZvK2RkemZ1a0x4b0tGNldiZXZjdG50STIxWGlIUllTZDdtRllC?= =?utf-8?B?cGQrS3FHdGNpeXJybVF0YTQvb1paYVQ2UG9Sb2VTRXpIdHJuQi9RenJsa3pK?= =?utf-8?B?YWlIenB6OFRGLzZWMDMvU3lLYzJWNU1hTUJMcitFV0FIRlBJSDhPczErSTZy?= =?utf-8?B?eXhXVHBGb3hqSzROcFNkQVlpSjVMQmc4cGRjSURaMktBa2Rqc0Z0Z2JHVW1P?= =?utf-8?B?dXNiOWEvY2tkdGVEVjFxRVAySE43TmJ1eFZSdzBhbFVQcjZ2ekFMY1BjMGlV?= =?utf-8?B?clg5SzJvOHEwdzdUeTlWa3gvVzlTOTM0RVExc2RRNmNKTXY5RmtjRXkxeE1k?= =?utf-8?B?Tm9iYmZIdXErY1VWSXV3THhzc0piSW9iZzJxdisyWlZMaytHR2Y2WENZbXJL?= =?utf-8?B?L0xJdnIxeEpkLy9USnFHZHhWMG9EandWUUJYQitxd0ZlSy8rMVdZSUV0M2dG?= =?utf-8?B?V3dCZmdRczJlbEZZOHh3N0w1djlWaW5VREF1bnNJd3RmUW95Snp5MU1YcFNq?= =?utf-8?B?STVjTExOdVVER0xBU2s4NGVRd1VQdHg3NjJlRndTNFVBelhqT244WmNRaW01?= =?utf-8?B?RnQ0eVVQTmtXRTlBd3pKeU16Q1FsaEhGMklESk1aejhkWlFUYnJXQThSYVRu?= =?utf-8?B?dlBKZ2h0MGxYK3RFMllxK3dOMW0xZG9vU2M3Yjdza0ZWYWo3RWpobFhGN2xk?= =?utf-8?B?TzdKRzZITXVRaFN3UXYwb2doeU41SkRFZkJ0NllDYk15Y0tBK1hGd3gyR1hy?= =?utf-8?B?SVVUdmxadU1iRVd1WCtaVU5iQm9aNGFrYWc4b0FxQXRVd0Q2WG0zZUF1Z29L?= =?utf-8?B?UVdiUjMvcDczT1NjNDR5SHdWbnJPSHA5Tm4wZ1dUSXZ6cXJsQUIyR013SWxv?= =?utf-8?B?Snd6YzVVdlppT1Bxa0gwRzNDdjVESGNjaTA1ZUl6blBRUkgwb1krZklJd200?= =?utf-8?B?WDlMVHdFZEhhaHRVWEJYSUFFKzFaVEo0MFhpekNYTnpYY1dGQUR0UDFweG56?= =?utf-8?B?ZnVVSFlranBycjJQdjI0aUJoc1JIN0gva3IrMVY1eVZWQzJKVThmR1kwN3Uw?= =?utf-8?B?NWgyc3lmN2pNQytzUVVkUERyVkxZYURvZlVEUzBMSlBCMFRSVVhuSkxsT20y?= =?utf-8?B?ODIwbjU1SklGN0FOLzhBdGtvR09MbUw5d1o5REU4VDFqWERWUHVac1BIMjNG?= =?utf-8?B?cVdvZ2F3NDlWRTZwQkFUVkZHZEJVdzhKUWZTOFNSVlhkNExuTTI1MnhBdmsy?= =?utf-8?B?dmJkWk82amgvU3gzZDF1VmtKVmNmMmN0dG9QZ0tlUHFOTklXazZZWGd6QkVn?= =?utf-8?B?Q1VMR2hWQW9ONisxQnpJbEV2RU1uY3Z5R1NXVXB3cC9IZ0pFQTcxWHNSNGRu?= =?utf-8?B?ME0yTkJ5QTE4UGQrOGpuQmszaXdObnFVdDBlZzNObVVJQzFZVFVWQ1BnU2ND?= =?utf-8?B?Y3YrNVNnYkxkN1BINCtKc253WVdTa0NodGVHNmlmR1NNT0ZENHMwQkcxdVJw?= =?utf-8?B?TTVzWWxDbHJaaTZXT2hlaDVvdVdpbC9qbGw2UXgzUjF2KzVrd3RZbnVYV0py?= =?utf-8?B?YmUzZGlIN21SWE1DdFdtdldFa25LYWE3bWp4ZjZCbUhCOVpDL3kwcEQ4bmVV?= =?utf-8?B?QzRiaWdwRlFBT1U0SDNzdEJvUWZSSjV5NHRZZnloZWY3cGJjWVJWL2FmOERv?= =?utf-8?B?SFhuTVlNdng5bkE1TWpTOFZzLzNoYTNjRGNBZDNxVE54eFRVWlptdFNYVjdk?= =?utf-8?B?TFpSN254ZWFSU1VKNGdBQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXZScUhwemsyTUZrdTdlTnYzZ20yS29OV0hiZFlmRFVMNzJaZGhoeFJ6aldt?= =?utf-8?B?RFBOMHlkdXlDNS9UTXZGWXdDZHRBZDVSdndXczRNdVNTQkxhVGxJTjgxYmxU?= =?utf-8?B?U3lDL2FKWDhFWWhHKzFmbDdjWXRvckNBVFdwY01QTlZ6Wm0rc25RSUJyL3JV?= =?utf-8?B?anlQeHBJQzc2eU14VVBLRHZBcCtYTmFySzFHRmF5anNvUXFIZ3hzWGFaRElp?= =?utf-8?B?ZjNlZ1h6SUh2Zko5SVRJZXVqWnNNTFhHV0dZR2Q2a3hxTC9pSm5maHIvVk1K?= =?utf-8?B?VzdHWGh3dXRGMDJMK3M1RDIzaWJoRWgwUjR3VDZBeWEyblBTZnBoaWZ1MXRI?= =?utf-8?B?elBoWHVBTzlWZHd1UjI3bmE5aERYU3JrTHZNODBDS0MxcXZaR0F4TlNqOEpF?= =?utf-8?B?NlJtZS9STFhQeTliUjQ4NE45cmdQMXl0VnYxdHpmSWpua3Q2MnE3SStmWjR3?= =?utf-8?B?RitnSGhGLzVhZ1R3N2pIVTA1cVd2ak9abW92bFlUZnphR05MYUVZL2xHVXds?= =?utf-8?B?dDFiMlNJR0w5ekZlU1JlS2lDeDhETk5YdmNrQllYSkp3U0JxSTJMNTNZMU5F?= =?utf-8?B?WkNsc0h2c3FkY0lpcEttK1kwbWdNUTZ5cmJXdHNOY1BUWU5IbzRvSnNwL3d5?= =?utf-8?B?aHNzUHhQcThCNzFZaVUwMzJXRkxMdXNlMnlrU1dLL0lXcEJ6SUVxS0Rnc3kw?= =?utf-8?B?d3gvUndWbzBMSUNtcVZsVnhXUXlzekc5WEJJLzBiRnhJVkFqTkdYUlkzcUR5?= =?utf-8?B?b3ZSRGtZN0tnTXhNUDVucHc2b296TkR3SlVZUk9ablBRSllmTUFpMHNLbmpi?= =?utf-8?B?OTAxcFFqRnhTdmJSSFJ4OThnaFkweEJ1OURRSHE2dUI1bDFrYW5TM3V4b1ZT?= =?utf-8?B?UzEzTmpxYlRtZDE4cmtYNDJWU0dsTE9xMWdwVTNadEFLaUVLTU0yTTFIYnF3?= =?utf-8?B?d0E0TnU4VXJ5YjcySDdFM2VNVXBESzZzZDlzMWhKaEY0TTNBNzcvK1loSHk4?= =?utf-8?B?c2w2bWNUbWVHb2RnZ0o1aURyQmdzUlROYndwU0NHSGxCSXBaM0FKd2RzL2Rl?= =?utf-8?B?R2lnYkVXcWg0VWFGNFFpc2xSTWFEa3ZDVkdGYUhwRTVtMTFIOHdTZGp2eXI2?= =?utf-8?B?NlRXV0J5bzlEaDc1ZjNnQnJPa04yS2tXcklyUUZPYUxEc2tEeEt1amRXSENO?= =?utf-8?B?TXBIU1R6aWhySWpUMlRBdDRSQVJVRmsyUERVSVBqWEN1OFd2bnhMcWlTVVly?= =?utf-8?B?YlV0NVJvRjQrbmlxYlNzanFwNUN2VzlwRHVoL3RqVXVOeVlOdWM5VGQ2N0lr?= =?utf-8?B?S1ByTE8zZTI1dVN6VGlpQjJ5OUhycUYrTllGcHRnVWhiUGFqQUFac0VYaUZm?= =?utf-8?B?TklaNU5ySVJRZjZJWEU3L3hSRlg3SEVTVmVPN3Q3OEp6STZkTVp3eFJsVWxx?= =?utf-8?B?TEhSZ25NU0ZXbjhJTktwNVNPMjRZNXZ5RTVwb1psVWNNSndQVThjUEg5cFpo?= =?utf-8?B?cVpjVkE3b0dtTjR3Q0VkUDhMTHR4eHZKbFdEcjk4aVZOUkdsUmhSREErcXRl?= =?utf-8?B?ZkZnUjB4ZUR1Q1NDVWliV1R3ZTFDSVlwaVE5cFdjdXFubjdIVUFqWlFyUElk?= =?utf-8?B?VW1NQklwS3FaZm9hRmZRWDhXZU1IQ3JsakFOSUEzUkJkWjBCMXBtTkVsN1hi?= =?utf-8?B?QWNRYm00RDE3dHNtaWFxK1U2TUlSa2FXZ1N4ODdNbVBIUmRFdWlQaFNLL25a?= =?utf-8?B?Vm9NVVlHYWxRTlVPNm5FeHltSVNZcWN3c3JWREFwaTUxOXZiaDhXRTg4MDhn?= =?utf-8?B?SU80MjJRT25OaGhhcjRmbnRFZFB0R0MvU01QOXJtUHl0VHFNRE5ESVg2MGR3?= =?utf-8?B?V2xtWUp2M0lMME0xNmlhdW9sTTFyelNiTC9FeEp1RmZ1RUlaYkczalFCT2dK?= =?utf-8?B?YVpVdDBSLzVHM01FVUVBR255ZUFWTS9kR1BoZ1RySVBQZEFIbzhrbXYzT0lV?= =?utf-8?B?cjNYQ2cwY0lQbXByVDZrVjZOaDBaTU9veXoyM2JBd3BSU2RlNG9VZTZOOE9v?= =?utf-8?B?aWJSTXB6VDlzUzU0YnYyZzVDSHd1RFZ6akxGaXBRZWlQSFZHTnMzaG5naWlm?= =?utf-8?B?VjZSeGZ3VWw1NkZCV2ZTc2dqUTRJWWJZVjUvOW43QTRVZkkwNVkwSGRGekUw?= =?utf-8?B?cUE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 78d1ac3a-ae0d-459f-4197-08dcc0fe5a43 X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6498.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2024 09:56:25.8436 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CCX+fyj+XJa4P4mStUh3V6EnIwIK1OnrnVL5oddtmdA7va5PAV9HKRSaz+CUUIPKfblWkxyQeD9RTk6qMco4MP405vdn2PqOAG9kqjxoodU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6778 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/2024 11:49 AM, Robin Jarry wrote: > Burakov, Anatoly, Aug 20, 2024 at 11:40: >> I have heard about driverctl for a long time in context of devbind, >> and I quickly tried it out just now, and IMO while the *functionality* >> is there, the usability of devbind is IMO far more friendly: >> >> - it filters by device types that are of interest to us (driverctl >> just lists all pci devices) >> - it prints out user-friendly names, not just PCI addresses >> - it lists loaded drivers, but not alternatives etc. like devbind does >> - I didn't test this, but I suspect it would allow overriding driver >> for an active NIC >> - after my changes, devbind displays NUMA socket, driverctl doesn't :) > > Yes, that's fair. devbind is more a dev oriented tool. driverctl is > really focused on reproducible and persistent driver override (it has a > systemd service that will force a rebind of pci devices on reboot). Actually, I should correct myself (and yourself) somewhat. This is not obvious from help message (I found it through reading the REAME) but driverctl *does* allow listing PCI devices by type, but only one type (e.g. list all network devices), but not multiple (e.g. list network and mempool devices), and as far as I can tell it does not support some of the device classes that we're interested in, so we will have to use the entire PCI device list and then filter it. It does also print out device names (adding "verbose" option does it). And it also *does* allow to bind/unbind drivers without persistence - --nosave option does that. Still, all of the other points apply: devbind is much more useful for DPDK developers as it provides information relevant to us right out of the box. > >> What we maybe can do for e.g. next release (currently I do have better >> things to do if I can help it), is to make devbind a wrapper around >> driverctl? This way, we can still keep the usability bells and >> whistles we have, but drop the driver overriding code and leave it to >> driverctl? It seems like that would be a good compromise, with the >> only downside being that we'll depend on driverctl being installed. > > Honestly, I don't think the dependency would be a good idea. Also, > driverctl does not have any option to make a driver override temporary. > It will persist after reboot which is not what devbind does. > See above, this is actually not true: driverctl can override a driver without persistence. -- Thanks, Anatoly