From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 66803A0C61;
	Fri,  5 Nov 2021 10:28:46 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2CDBA40E5A;
	Fri,  5 Nov 2021 10:28:46 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 93BB140DDA
 for <dev@dpdk.org>; Fri,  5 Nov 2021 10:28:45 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 2B0897F57F;
 Fri,  5 Nov 2021 12:28:45 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 2B0897F57F
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1636104525;
 bh=FYXYqnIhV9yr+5lhT7TZisqxortzVK933z6PhuV9b/o=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=PQPyeThIGR/UbZgmTEAQGjkYOput5pGWgQYiILnuNh46Zr24T+HVksVJPuuZZ9y9H
 jdtvsOvDj/K99qfZAMz7ZUH7vNqybvRQbzNKqVHjMKVMW2QEbo7rDS5F3r0+6dF7dV
 sIc+GQIDOaoMu1RArVNXbREPpvqe/XJBbyQbGC8s=
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Vijay Srivastava <vijay.srivastava@xilinx.com>, dev@dpdk.org,
 Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: maxime.coquelin@redhat.com, chenbo.xia@intel.com,
 Vijay Kumar Srivastava <vsrivast@xilinx.com>
References: <20210706164418.32615-1-vsrivast@xilinx.com>
 <20211103135754.17411-1-vsrivast@xilinx.com>
 <20211103135754.17411-2-vsrivast@xilinx.com>
 <5aae6385-6310-7692-913e-bb4d93ad390d@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <0d00a43b-33c7-8c46-6930-3f33b360bebb@oktetlabs.ru>
Date: Fri, 5 Nov 2021 12:28:44 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <5aae6385-6310-7692-913e-bb4d93ad390d@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 01/10] vdpa/sfc: introduce Xilinx vDPA
 driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/5/21 12:13 PM, Ferruh Yigit wrote:
> On 11/3/2021 1:57 PM, Vijay Srivastava wrote:
>> diff --git a/drivers/vdpa/sfc/sfc_vdpa.c b/drivers/vdpa/sfc/sfc_vdpa.c
>> new file mode 100644
>> index 0000000..f087944
>> --- /dev/null
>> +++ b/drivers/vdpa/sfc/sfc_vdpa.c
>> @@ -0,0 +1,282 @@
>> +/* SPDX-License-Identifier: BSD-3-Clause
>> + *
>> + * Copyright(c) 2020-2021 Xilinx, Inc.
>> + */
>> +
> 
> Only sfc has that blank line between SPDX tag and Copyright,
> is it intentional?

As far as I remember it is not intentional. Just coincident
and may be definitely fixed in vdpa/sfc.

> 
> +Hemant, not sure if we enforce any specific syntax?
> 
> 
> If there is no specific reason, I think better to have common syntax,
> that helps to scripts etc..
> It may be noise to update existing code, but we can fix it in
> new code.

+1