From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45DC842C40; Tue, 6 Jun 2023 16:46:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9AFA40697; Tue, 6 Jun 2023 16:46:07 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 1BCAF40223 for ; Tue, 6 Jun 2023 16:46:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jYDV3C/S2Yp2FQJPaMFH3W0iuHv+IqTW4QueGxZ/mHHZVM+WTgkHYe5MTToBeHwExQVyuqmbwl7a5JYWoswf+HwN4B2ZZ9m/zCwny0iXPf7B7kJliIr2oN3KeHIiQg/B7e8IuFJtUFsAtEDkKpuoZtFWL04lYeT4+93BwCjGvloP0jUxVxRi97hB71wv2MKkvk6EenMgRsEvedFRhh0oEef5g4ONePMbE1+cGSoNSbGA4O7hpmcguIM8fUjq4R6ckchFtRevrtmFPCtAKybNRS8Um54zXsNY4uOs4NRU5YauTkftcI/KugZxyt2jCWcDRhoZAOUCnk1lTflNLUbbDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ueG8RNv9BBVM57rWJ8ZepytsSe37DsglhilS5zCgb08=; b=btuLFDNJDvk0KXm3lRpxok817MjAxmMN9yKPvNr8C+9yHEZMsr6yHSVFx/5AP3gAZoBUS6b9aex2BQ5TCehpgpPBEwkh6olSKMjy8W5ouCtIy5CGZI0hndNRtVhu+vaJfHuCtUbUos89FQv+xDIHTrDVUVNb3c/766nAVRKnbaciv9H3SCaMqDG9/d4g4D9zaM0nZkW1xHFifjl/dJM6n2o6CpBF4YFJ3DuVDGNHYdZi2IzLNihIpfA237+D0Qn6bMiTVN3/E4AkFDg1VTArzyEraXDA6PEznUe5CMmoGmVcRWdU2wYJ8PJWUYEIV7BIi7UoTpNaK3wZvoJKeLb/Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ueG8RNv9BBVM57rWJ8ZepytsSe37DsglhilS5zCgb08=; b=JgWewhx5Ewwil5j9XXBONNQ9i8CT/HTIlA0l+t8eeUDMLU7bgwLK8hE3kymTDn58/9TIgIjfFauS5z2IcTf2o88/XVMxOY+8rHz8OBtPTLjcf6cBQuBmUdtBlE8ZyfD9QNqIeWOsliOSe83iq4Agpm380YY//hyoTW2hXaEPFVA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN0PR12MB6127.namprd12.prod.outlook.com (2603:10b6:208:3c5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Tue, 6 Jun 2023 14:46:04 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::cf07:30f7:a92a:c53b]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::cf07:30f7:a92a:c53b%4]) with mapi id 15.20.6455.030; Tue, 6 Jun 2023 14:46:03 +0000 Message-ID: <0d06a197-0df4-b4f4-1b1e-98419269d6bb@amd.com> Date: Tue, 6 Jun 2023 15:45:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v3] app/test-pmd: fix not polling all queues without deferred starting Content-Language: en-US To: Jie Hai , Aman Singh , Yuying Zhang , Anatoly Burakov , Dmitry Kozlyuk , Matan Azrad Cc: dev@dpdk.org, liudongdong3@huawei.com References: <20230508031046.34346-1-haijie1@huawei.com> <20230529022649.51425-1-haijie1@huawei.com> From: Ferruh Yigit In-Reply-To: <20230529022649.51425-1-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0137.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::29) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN0PR12MB6127:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b1237e0-b8c7-4cbe-d54d-08db669cc0af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EMI55eD3JzVBh1IsE4fBufWhFry2dammWIbkMe26bSfIwDy1Hb6XQ8Zxbx5rRoaGGJQEmaacYBVJoFetyO3dOW5h26+XIGfKrUzh05xwRdQL7QR96+vhH73Hrlkzup9glq2XWOfkv0rm5tNXrCxQa8NWc3Wiqz+mfDPpV1UFzBVhdhy1XSYrCsmRf8/9Jb50CkfbW6HBL9X8rXAwrNkQS7vUbBbw1rg56IV5VRNl+ZSUUTkWy3N+eRYG04O5evIeNXCfrqg5y73x0+5w27bjdRZSLlYG7rpw+bQm0uyP+yXZWAtqq3TOvIlN3sU2s36kFyrB6FGW8dO5kK8LAZ4pFxDLdtdd2GDlo4PtHdlDYfQBRnGLuq+A8m87uVm7ls7QZrvXsDMD52HbA0v8369PGzFW+1m2GJKfl9hIZZh7Q1ldC84pUPOM78tjV2uQu5XG/h3uVM9bHq1Wnz2jupT70CFjwb3VLbefiLOaqhgwFRXS/A1II3wj4WkDmKjj9RN9Z7OucwRwdVjav5QkGp9OEDibbyO0iglAQAGBqr5E3zvWQAUyp4feHQpeOxjUVQN5xmx5WCThLtOx2ng6/fl/xs8VUEnH3PqkG1vDCPHGLpwIeMvh9NjQzCiUl8XkjUlI/JWCndlFiVLWxmBI1UWkMw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(39860400002)(396003)(136003)(346002)(366004)(451199021)(2906002)(83380400001)(2616005)(86362001)(36756003)(31696002)(38100700002)(6486002)(41300700001)(6666004)(5660300002)(316002)(8936002)(8676002)(110136005)(478600001)(66556008)(66946007)(66476007)(31686004)(4326008)(6512007)(53546011)(6506007)(26005)(186003)(44832011)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEkza3VtQllualhQd2Y2VXh0YitYU0JKYzIxN216alk0MmhxUzF4K3I2RUNI?= =?utf-8?B?cktSdlAvbkhncGxldWdCbGUvOWpkakdSQTQ1NzJjNlQ1NDRXSitQUXBzYVRK?= =?utf-8?B?WkxDRVFNa1lFOWZyb012T0dDV25WMjFNNGtBbDlTRDVvUkpGOXQ5aWZyNDU4?= =?utf-8?B?ZDJDOUp5NlRZZllMZVRSY0hicmFWdnZNYUdSc1l5eFo3L21UQlNuNkZCMjdx?= =?utf-8?B?T2F2eVB5TURDMGcyWDNiamJPbTRlTmYrTUU4ZjhIMU9RMUF4Z0dzSFdMT0hV?= =?utf-8?B?cVA3SCtMaU9hZlFubnZwL2ZQN1pkK3EwaUg4UHhRYVgxbWVZOU5WOHoyRFZJ?= =?utf-8?B?T1hJdHJkQTBZQ2h5TVJuMWZ6YnlTb3ZmK3NmcWEvd2RncU1JNWhlbnRmNVBO?= =?utf-8?B?dnJZSVJrOXlhZit5dFdtWlNZY0FEaW1TUEp3MktuRi9BNTBSNjY1Y01hTHY3?= =?utf-8?B?QTJqd1B4TTZzdGt4MU81eFd3aTc2bTN1MDFTa1UzVXJDclNMai9Ea2xuVTNG?= =?utf-8?B?Sldqbk1DdEg4WGp6M2E2Y20xTkJ3b0tmMTZ1ZFE0djlWM3JCam5oZHllbTRz?= =?utf-8?B?bFFuQTdpRmJIaTJhOHNZeVZ3Z1dvT2x3K1JVaE01RFk0cjVKNXNuR3NmdnNL?= =?utf-8?B?Uk5qa1YxTVFWOTMyMXVITDJ6RGNrMCtFalJWZXlDbTNZWUd3SXc5cGtnNU96?= =?utf-8?B?SU5ZSEhoQTBreWZZZ1JJQTBzK2RMZHVoNjBoQ29GemhjQ29ydVFlUFZCdUdv?= =?utf-8?B?VG9VYTlJVFJIMDBGdHNCdjI0V094RnIyMXlzSDd1ckVaWUl4cW5mTzdXclVX?= =?utf-8?B?RnBCaURGMzBlSlN2bGJ6YVB1bXRwNTdjclZzU3RvQVVvNmJ6T2szZm5jcHZI?= =?utf-8?B?SnFYNWRnV0VJVXo4QkgrSGtTV21ucjZHTUh6VE5hUXVoTWJjY1JHTTRnYm5x?= =?utf-8?B?U1hDRWlEVktrOVVEM2c3RXBEaGR2NWRDVGlmR0VoYzZGTXRMQ0FSSGFjcktV?= =?utf-8?B?QkZEYXRBMGtDTXAwQVpQSzdxemZqTURVaDNIUTN2QllRWFhiU3ViOUlPRHZX?= =?utf-8?B?WWJlSSs3alBqcnZrdGxYRFRIa3l1S1pVVXdNU2g3bFQxWmZUYjdGQUtxSzJR?= =?utf-8?B?S3VkN2FUQmlTYjhydWJYMGJ1OW5hNXNGMXRaYkxsbUFDVHBONXA1aE9pdE9F?= =?utf-8?B?Ny9FZzFqOEZxaGhkbzNuTHB1UGsxM0ZXcnRmamZDcXpFT0JPTXJueGZ4Vkg0?= =?utf-8?B?MmZZa1dvWi9sb2pydUdYTUxTL0pFQ01tRHdkWW0wN043TDFmbzRsVTZ1OGFT?= =?utf-8?B?TGZraDZOVjhmMmloNll4SGdzekhlaWVycG1BQWJMM0h1ekk0QURzYk8venR0?= =?utf-8?B?SmV3REZvZ2U2amxqR3JsNVV0VlBvS0FTcUxHbndaTnJhWUlQeFQwOURMVkcr?= =?utf-8?B?eWNVUzVtYnR4aWY5cUtLTmEzanZhUlZ6SzNEeGlRNGcvenBWc0tiYW93S25U?= =?utf-8?B?MFhlR3ZEczhOZ0YxOWR1OXR5WWU1dEtPdVU1elZXd2dwMG9qK3RBTUY3RUlm?= =?utf-8?B?eFRLM0VybkJaVXlaRHJURjA0dXh2aEthOW5iQ0MvQzFEb2Uza2hoUTZ5bElo?= =?utf-8?B?Z0xzT00vV283cVJtSHJvd3hDVm05ZGRNQkhZM3c5K01NVmtuSk1OUVM2TFFo?= =?utf-8?B?dlVvK0U0Q0RydDJSSzNYanJqOUNGVkcweE84MGRQcm1BcTJSTDU5UEIyTVEr?= =?utf-8?B?cEp0czkwNUYyQlc2MHBYVVZPb2ZRMVlZWk5ZUnoyUGpQUTFqUDZwUmszM0Vm?= =?utf-8?B?eHlGOVR5Uk1BZVZZTXZhbTdqMnI2a2NKQkVsYnEyNUF0OVJMWWR3cFAxV0li?= =?utf-8?B?bmMrRksyeWRpVWwyWGM4Zm95V1REampvb1dBK0xwcHZOOEhxanplcndFNTN0?= =?utf-8?B?RGxQclhBMDlxTXJkS0Q2a2ZZV1loNHlVTzg5M05UL3FKTjJ1MTcvWm8vYzBr?= =?utf-8?B?ZDlVa2xKR01kc3hsWU5vcnlvd0hLc1ROOVkwZys1N2FkeGEzaE9HWUhFcnYw?= =?utf-8?B?YVhlSDdnZzJpbHRFSmxqVDFMaUVzLysyQlJpa1dkbURJOVhYUjRraWNLdkJv?= =?utf-8?Q?lzaFWYhjKRTeSa0NHZ2Ig3iNf?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b1237e0-b8c7-4cbe-d54d-08db669cc0af X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 14:46:03.8395 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qepAXTvRJ0fVrPKp7XTMqeCLq/oc1bUeW6M8523aJib7vJaR86vC9xPNVmzj0KhU X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6127 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/29/2023 3:26 AM, Jie Hai wrote: > > Each stream has a read-only "disabled" field that control if this > stream should be used to forward. This field depends on states > of Rx/Tx queues, please see > commit 3c4426db54fc ("app/testpmd: do not poll stopped queues"). > > Currently, the testpmd and DPDK frameworks maintain queue state > separately. That of the primary process of testpmd are set by > deferred_start in the queue configuration. And that of the > framework(dev->data->rx_queue_state or dev->data->tx_queue_state) > is set when the driver enables/disables the queue, and it is > shared between the primary/secondary process. > > If the deferred_start is set, the queue is disabled and the > corresponding queue state in the framework changes to stopped. > However, the queue state in the framework does not only come from > this. If the primary/secondary process stops a queue, the related > queue state will change, too. However, the primary process of > testpmd does not know the change brought by this operation. > Therefore, setting the queue state in the primary testpmd by only > the deferred_start is unsafe. > > For example, Rx/Tx queues who are stopped before the operations of > stopping and starting port cannot forward packets after these > operations on primary process. > > Therefore, the primary process should getting the queue state from > of the framework as the secondary process does, please see commit > e065c9aa3e05 ("app/testpmd: fix secondary process packet forwarding"). > > Fixes: 3c4426db54fc ("app/testpmd: do not poll stopped queues") > Cc: stable@dpdk.org > > Signed-off-by: Jie Hai > --- > v1->v2: > 1. Fix misspelled word 'deferred'. > 2. Fix incorrect format of reference to commits. > > v2->v3 > 1. Fix incorrect format of reference to commits. Hi Jie, Problem is not clear for me. Can you please describe more what is not working?