From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A80D4A04DD; Wed, 21 Oct 2020 07:38:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E969DAA25; Wed, 21 Oct 2020 07:38:32 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 81A6DAA21 for ; Wed, 21 Oct 2020 07:38:31 +0200 (CEST) IronPort-SDR: IlJ/DzUKr5QwNHlYGYFtp65X16Hd/Uc3JGPTue6Vc4bLKrYAM3RvOMjz/+TsDCVEVGTHjI9JyQ Tepbf1DvrvAQ== X-IronPort-AV: E=McAfee;i="6000,8403,9780"; a="146610961" X-IronPort-AV: E=Sophos;i="5.77,400,1596524400"; d="scan'208";a="146610961" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 22:38:29 -0700 IronPort-SDR: XFZ/X9XqYXz0zzEFBaye2MMVS58OSWGj1XQMqTobmh7B0rGVjfgv7EMN60NOgJcuPaOWUIaAld Xe4b/aZcgqIw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,400,1596524400"; d="scan'208";a="392618094" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga001.jf.intel.com with ESMTP; 20 Oct 2020 22:38:28 -0700 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 20 Oct 2020 22:38:27 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 21 Oct 2020 13:38:25 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Wed, 21 Oct 2020 13:38:25 +0800 From: "Guo, Jia" To: Andrew Rybchenko CC: "dev@dpdk.org" , "Lu, Wenzhuo" , "Xing, Beilei" , "Iremonger, Bernard" , Ray Kinsella , Neil Horman , Ajit Khaparde , "Somnath Kotur" , "Guo, Jia" , "Ziyang Xuan" , Xiaoyun Wang , Guoyang Zhou , Rasesh Mody , Shahed Shaikh , Andrew Rybchenko , Thomas Monjalon , "Yigit, Ferruh" Thread-Topic: [PATCH 03/14] ethdev: remove legacy EtherType filter type support Thread-Index: AQHWpVhQfEAwg6WTJEK8kYVUkyGA4KmhARSAgACLP1A= Date: Wed, 21 Oct 2020 05:38:25 +0000 Message-ID: <0d1111bea4a045bfa57c558151f8d158@intel.com> References: <1603030152-13451-1-git-send-email-arybchenko@solarflare.com> <1603030152-13451-4-git-send-email-arybchenko@solarflare.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 03/14] ethdev: remove legacy EtherType filter type support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Andrew Rybchenko > Sent: Sunday, October 18, 2020 10:09 PM > To: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; Ray Kinsella ; Neil > Horman ; Ajit Khaparde > ; Somnath Kotur > ; Guo, Jia ; Wang, > Haiyue ; Ziyang Xuan > ; Xiaoyun Wang > ; Guoyang Zhou > ; Rasesh Mody ; > Shahed Shaikh ; Andrew Rybchenko > ; Thomas Monjalon > ; Yigit, Ferruh > Cc: dev@dpdk.org > Subject: [PATCH 03/14] ethdev: remove legacy EtherType filter type suppor= t >=20 > RTE flow API should be used for filtering. >=20 > Move corresponding definitions to ethdev internal driver API since it is = used > by drivers internally. > Preserve RTE_ETH_FILTER_ETHERTYPE because of it as well. >=20 > Signed-off-by: Andrew Rybchenko > --- > app/test-pmd/cmdline.c | 115 ------------------- > doc/guides/rel_notes/deprecation.rst | 2 +- > drivers/net/bnxt/bnxt_ethdev.c | 157 -------------------------- > drivers/net/e1000/igb_ethdev.c | 85 -------------- > drivers/net/hinic/hinic_pmd_ethdev.h | 1 + > drivers/net/i40e/i40e_ethdev.c | 45 -------- > drivers/net/ixgbe/ixgbe_ethdev.c | 85 -------------- > drivers/net/qede/qede_filter.c | 1 - > drivers/net/sfc/sfc_ethdev.c | 3 - > lib/librte_ethdev/rte_eth_ctrl.h | 19 ---- > lib/librte_ethdev/rte_ethdev_driver.h | 23 ++++ > 11 files changed, 25 insertions(+), 511 deletions(-) >=20 <...> > #define RTE_FLEX_FILTER_MAXLEN128/**< bytes to use in flex filter. */ > #define RTE_FLEX_FILTER_MASK_SIZE\ > (RTE_ALIGN(RTE_FLEX_FILTER_MAXLEN, CHAR_BIT) / CHAR_BIT) diff --git > a/lib/librte_ethdev/rte_ethdev_driver.h > b/lib/librte_ethdev/rte_ethdev_driver.h > index c63b9f7eb7..67a83dacc7 100644 > --- a/lib/librte_ethdev/rte_ethdev_driver.h > +++ b/lib/librte_ethdev/rte_ethdev_driver.h > @@ -1342,6 +1342,29 @@ int > rte_eth_hairpin_queue_peer_unbind(uint16_t cur_port, uint16_t > cur_queue, > uint32_t direction); >=20 > + > +/* s/*/** > + * Legacy ethdev API used internally by drivers. > + */ > + I am not sure if this doc is need? > +/** > + * Define all structures for Ethertype Filter type. > + */ > + > +#define RTE_ETHTYPE_FLAGS_MAC 0x0001 /**< If set, compare mac */ > +#define RTE_ETHTYPE_FLAGS_DROP 0x0002 /**< If set, drop packet when > match */ > + > +/** > + * A structure used to define the ethertype filter entry > + * to support RTE_ETH_FILTER_ETHERTYPE data representation. > + */ > +struct rte_eth_ethertype_filter { > +struct rte_ether_addr mac_addr; /**< Mac address to match. */ > +uint16_t ether_type; /**< Ether type to match */ > +uint16_t flags; /**< Flags from RTE_ETHTYPE_FLAGS_* */ > +uint16_t queue; /**< Queue assigned to when match*/ > +}; > + > #ifdef __cplusplus > } > #endif > -- > 2.17.1 >=20