From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Ding, Xuan" <xuan.ding@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
"Hu, Jiayu" <jiayu.hu@intel.com>,
"Jiang, Cheng1" <cheng1.jiang@intel.com>,
"Pai G, Sunil" <sunil.pai.g@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [PATCH] vhost: add runtime locking check in unsafe APIs
Date: Tue, 10 May 2022 11:09:13 +0200 [thread overview]
Message-ID: <0d1e560c-1430-31b5-95f6-91778d6cb6e7@redhat.com> (raw)
In-Reply-To: <BN9PR11MB55135934584585A3F43F92DCE7C99@BN9PR11MB5513.namprd11.prod.outlook.com>
On 5/10/22 11:00, Ding, Xuan wrote:
> Hi Maxime,
>
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Tuesday, May 10, 2022 4:25 PM
>> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; Ding, Xuan
>> <xuan.ding@intel.com>; Hu, Jiayu <jiayu.hu@intel.com>; Jiang, Cheng1
>> <cheng1.jiang@intel.com>; Pai G, Sunil <sunil.pai.g@intel.com>;
>> david.marchand@redhat.com
>> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Subject: [PATCH] vhost: add runtime locking check in unsafe APIs
>>
>> This patch adds runtime checks in unsafe Vhost async APIs, to ensure the
>> access lock is taken.
>>
>> The detection won't work every time, as another thread could take the lock,
>> but it would help to detect misuse of these unsafe API.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>> lib/vhost/vhost.c | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c index
>> df0bb9d043..39cbeb415c 100644
>> --- a/lib/vhost/vhost.c
>> +++ b/lib/vhost/vhost.c
>> @@ -1732,6 +1732,12 @@
>> rte_vhost_async_channel_register_thread_unsafe(int vid, uint16_t queue_id)
>> if (unlikely(vq == NULL || !dev->async_copy))
>> return -1;
>>
>> + if (unlikely(!rte_spinlock_is_locked(&vq->access_lock))) {
>> + VHOST_LOG_CONFIG(ERR, "(%s) %s() called without access
>> lock taken.\n",
>> + dev->ifname, __func__);
>> + return -1;
>> + }
>> +
>> return async_channel_register(vid, queue_id); }
>>
>> @@ -1796,6 +1802,12 @@
>> rte_vhost_async_channel_unregister_thread_unsafe(int vid, uint16_t
>> queue_id)
>> if (vq == NULL)
>> return -1;
>>
>> + if (unlikely(!rte_spinlock_is_locked(&vq->access_lock))) {
>> + VHOST_LOG_CONFIG(ERR, "(%s) %s() called without access
>> lock taken.\n",
>> + dev->ifname, __func__);
>> + return -1;
>> + }
>> +
>> if (!vq->async)
>> return 0;
>>
>> @@ -1925,6 +1937,12 @@ rte_vhost_async_get_inflight_thread_unsafe(int
>> vid, uint16_t queue_id)
>> if (vq == NULL)
>> return ret;
>>
>> + if (unlikely(!rte_spinlock_is_locked(&vq->access_lock))) {
>> + VHOST_LOG_CONFIG(ERR, "(%s) %s() called without access
>> lock taken.\n",
>> + dev->ifname, __func__);
>> + return -1;
>> + }
>> +
>> if (!vq->async)
>> return ret;
>
> Just to confirm, is the rte_vhost_clear_queue_thread_unsafe() API missed the check?
I missed it, I thought they were all in vhost.c.
I'll send a v2.
Regards,
Maxime
> Thanks,
> Xuan
>
>>
>> --
>> 2.35.1
>
next prev parent reply other threads:[~2022-05-10 9:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 8:25 Maxime Coquelin
2022-05-10 9:00 ` Ding, Xuan
2022-05-10 9:09 ` Maxime Coquelin [this message]
2022-05-10 9:00 ` Hu, Jiayu
2022-05-10 9:14 ` Maxime Coquelin
2022-05-11 1:51 ` Hu, Jiayu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d1e560c-1430-31b5-95f6-91778d6cb6e7@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=sunil.pai.g@intel.com \
--cc=xuan.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).