From: Ferruh Yigit <ferruh.yigit@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH 0/3] net definitions fixes
Date: Wed, 23 Oct 2019 14:19:28 +0100 [thread overview]
Message-ID: <0d22b844-f53f-e91e-19e4-9137f2f4c883@intel.com> (raw)
In-Reply-To: <CAJFAV8xUZgnRfpUVXuxs5w92U1KO+dKwfgbu16tuJOd67yp9eA@mail.gmail.com>
On 10/23/2019 2:00 PM, David Marchand wrote:
> On Wed, Oct 23, 2019 at 2:57 PM David Marchand
> <david.marchand@redhat.com> wrote:
>>
>> On Wed, Oct 23, 2019 at 2:12 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>
>>> On 10/23/2019 9:51 AM, David Marchand wrote:
>>>> Small patchset with fixes after inspecting the librte_net.
>>>> I copied stable@dpdk.org in the 2nd patch for information only.
>>>>
>>>
>>> Overall lgtm. And this release seems the one to make these changes, and we
>>> already break the API for net library on this release BUT should we update the
>>> ABIVER for net library?
>>
>> This patchset breaks API by renaming structures/defines and remove
>> some constant defines.
>> ABI should be the same ?
>
> But I suppose adding some words in the release notes can't be wrong.
>
You are right, there is not point on increasing ABIVER since only API is
changing, +1 to document change in release notes. (also for previous rte_esp change)
Thanks,
next prev parent reply other threads:[~2019-10-23 13:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 8:51 David Marchand
2019-10-23 8:51 ` [dpdk-dev] [PATCH 1/3] net: add missing rte prefix on PPPoE defines David Marchand
2019-10-23 8:51 ` [dpdk-dev] [PATCH 2/3] net: add rte prefix to MPLS structure David Marchand
2019-10-23 8:51 ` [dpdk-dev] [PATCH 3/3] net: hide internal CRC defines David Marchand
2019-10-23 12:12 ` [dpdk-dev] [PATCH 0/3] net definitions fixes Ferruh Yigit
2019-10-23 12:57 ` David Marchand
2019-10-23 13:00 ` David Marchand
2019-10-23 13:19 ` Ferruh Yigit [this message]
2019-10-23 13:39 ` [dpdk-dev] [PATCH v2 0/4] " David Marchand
2019-10-23 13:39 ` [dpdk-dev] [PATCH v2 1/4] doc: add note on prefixing ESP tail structure David Marchand
2019-10-23 13:39 ` [dpdk-dev] [PATCH v2 2/4] net: add missing rte prefix on PPPoE defines David Marchand
2019-10-23 13:40 ` [dpdk-dev] [PATCH v2 3/4] net: add rte prefix to MPLS structure David Marchand
2019-10-23 13:40 ` [dpdk-dev] [PATCH v2 4/4] net: hide internal CRC defines David Marchand
2019-10-23 20:03 ` [dpdk-dev] [PATCH v2 0/4] net definitions fixes Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d22b844-f53f-e91e-19e4-9137f2f4c883@intel.com \
--to=ferruh.yigit@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).