From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0054.outbound.protection.outlook.com [104.47.38.54]) by dpdk.org (Postfix) with ESMTP id 6B1A7683E for ; Mon, 17 Sep 2018 14:28:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q8toj07Z5tSD3+gb/GxtjyxxY+wcquKrbi4LOUoDFso=; b=b+YFFZGXKytcawkmQoogPg1PEO8ayQ1UuNXeaL0Getwu05380a7Ua3o2sjO8hW8CTeQwkAuNwLlg1YtgY+fXkQiCS7BD4OXk1NlnhToBBNWLD/jTwUCpw5+UjKsFiJJtDdJ8L2N8XwgtB0QscWc3Z2GZnzB8LUF0sYq0zem57ZU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from [10.88.100.222] (115.113.156.2) by SN6PR07MB4911.namprd07.prod.outlook.com (2603:10b6:805:3c::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.15; Mon, 17 Sep 2018 12:28:22 +0000 To: Thomas Monjalon , Anoob Joseph Cc: Akhil Goyal , Pablo de Lara , Jerin Jacob , Narayana Prasad , dev@dpdk.org, Ankur Dwivedi , Murthy NSSR , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj , ferruh.yigit@intel.com, john.mcnamara@intel.com References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <1536033560-21541-6-git-send-email-ajoseph@caviumnetworks.com> <1686325.VlSG2WtMdx@xps> From: "Joseph, Anoob" Message-ID: <0d24273a-de9d-e9fa-9b99-5dcba3ebfea8@caviumnetworks.com> Date: Mon, 17 Sep 2018 17:59:15 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1686325.VlSG2WtMdx@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: PN1PR0101CA0064.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:d::26) To SN6PR07MB4911.namprd07.prod.outlook.com (2603:10b6:805:3c::29) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c0b42e5c-211b-47a3-5042-08d61c99118c X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB4911; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4911; 3:LbaXvs7nD5HeJE8cb5oiPqmy3llh07bI+objfpIMN7jnFBudUACQPCJhxDoHXlbtQfPPl9ymzNWOEiT75M3RiLLmKWd7CgNs8s5IvEIcqUZIVxvO4Ui/YaUIbTXLl5ytb6s8I1DY2U3JiDCzs1rhiGDBEnncvY5jxH/gP/iklGvKjLhhLyQQAbCawfAZ1VBgR3DJrUxUsqC24Ey8KqLKA/Ef2aEMgEFdFH0Q5nOtMJLW0VuUHquL1WeBHrQZ1j0B; 25:sfibRJVHQ4Y8mfRfkcntumDZ9l6J3Rf7Vm+D9x/lzDlUMlQtYV7RzREyqHAoSqFeqHT9KWlPbLbp91QI4HOAFxaMMtqsiGKzcVdR3DHRqco7GlwopdIMjh2U3eIqv64u0c82yvyWp+CmZleJHzNI5o6fzyvhtx1A3zINrNFUr2CXD4MSA9aE2zz58Suld6YqFTu9xSxoa0TKspES4hhOo1d1+tJwSzIHVn9H49vJzbD7KPx/iHoUYrpMURRm/gPL59HsENZEd4IDvLFuiY+q8otiOYy8iFhRrkgmj85x+j6yzFhWIYbEqSf4Z+SfcJYqwGWWQl1dc/hFJRW/GwagvA==; 31:0eqTAl40NiuMmkLRwOrMCtUCm8DRnHZFKpdIVSR2mnGPs+aGlwy42OVUbiiF5NZ0n+qPMI7Kp6jKDYnclfYvqjyDG8OYBR3RORrsob1aaGvk0+n+kJ9ttbFyR7Rmp+NT6+oVY5r/7c1HyZRBfZVlj/z0kMM+gzoRWngA5fEUJPsU0wd8yeYsUQeP4dOrrfsIx3Bexy06JIFGxgpApVTGUGx22xQwiu9fXkKzRqII1k4= X-MS-TrafficTypeDiagnostic: SN6PR07MB4911: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4911; 20:ZJIX0mOVw59GwibtlGGBoR2ZJLKJ9r1qwGnrQdO1b8KuyzXID+ewIKW1MjbJLuqpWVhjldiF87/0bS/xiujQBXbTxcKhOzPpIQXhVn1AplrH+afvw+b973gt2ocgDeSbwlfnH8CqkUCh/gsbI+1SP96/VWKvGaJwqoQo+668ZHe5fBj8p4l4a8LlBeF5m46irr3CKvpnC2keA8jFOW13ScxGLu6w/vK3VeHAuQel1J+Px0JD9QwDcG7w4+tBauB1pAQ+KjGW6KFprsu6gLzZpTa/5oeADxhEQrddZpuX7uOg4x+Huzjp3/2vv8uzWRK83fGqEk2z5gTeorECvE4bbyfWp0XtUd+VEnFWDQt/RDt3PG8uHnw5Zre1D+l4f/Y7iavAkKqlFavuZu8TEYRHgoqs7Z3dXuO4Ly1N7f9ESbG/o6Na+Coajn+cJA1CZKDjTgsL4VFJ/nLBWuvTk8kwIzGRPtctEO2PfzGmZIWRziWRaEYji2HiAm7AsopFflASwItBHjT0ml1anA35Z6DmhTAbybv52a03QkllB2JUZRQoTzNzinUSyAjASVq+Gun7fj+d/iNsmUc4ZOxYWo92aLinuiqI+nydoc/+axsnoRo=; 4:pe08sB+V75oaVk0x+ThnFzStcTDX9jDNZhV2kwafCMCPGnsC1m1htiLt8NhY18XJXCL9YOdN6u+jvqJx/xKRBflYRw+jHS7Kooa01wcjyQxhP47SfIAak1E+q1NaGshpgDFYg6sct5na7iI51ZYgc4Q9m9OYDSnrc4u5kubWq8R90fQAalll/Szh7sQiEATK3XqIyOA8rbOXNJtzwPGNNxGpk/dFiSsbK4rIu4yjIxd8hWZuk08W1MsI/i7pcmHzI1M5ub5sTUd6uyDXu6D02Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(52105095)(93006095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123560045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(201708071742011)(7699050); SRVR:SN6PR07MB4911; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB4911; X-Forefront-PRVS: 0798146F16 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(376002)(39860400002)(366004)(396003)(346002)(136003)(189003)(199004)(16526019)(5660300001)(186003)(316002)(31686004)(110136005)(16576012)(58126008)(54906003)(4326008)(76176011)(2486003)(52146003)(23676004)(52116002)(14444005)(8676002)(6666003)(6636002)(47776003)(65956001)(67846002)(65806001)(66066001)(77096007)(6246003)(65826007)(26005)(50466002)(97736004)(7736002)(64126003)(105586002)(106356001)(305945005)(3260700006)(25786009)(2906002)(31696002)(486006)(3846002)(6116002)(53936002)(446003)(53546011)(476003)(2616005)(229853002)(11346002)(81166006)(956004)(6486002)(36756003)(230700001)(55236004)(478600001)(81156014)(72206003)(68736007)(8936002)(93886005)(386003)(42882007); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4911; H:[10.88.100.222]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjZQUjA3TUI0OTExOzIzOnoyamxtNWYzWlE0am40bmFMcC8wVTU3U1V3?= =?utf-8?B?Ylc3ZC9kdC9NOTdJTG93MGFCT2tmRGFleWVUMkxib0xHVUVNeHk3a2poRCtW?= =?utf-8?B?aFhqdGpVa1QxT0F5c0VzRklCR3ZVQk5NVFlFcVBWMDBwWE1KMiszMkxjaFhv?= =?utf-8?B?aHZSY1VydXgybmFPdDdpcnppMmtydE0wREw1R080dnFERThLa0RuTEpneTNx?= =?utf-8?B?eVkzQVlaelM1ZzhGUFBjZy9ra0NpWEZDVG9UL2NwcWtFZ3YzMUNZc1FGYzV3?= =?utf-8?B?VFBDc3FwWDZSNzhPdFFiTm5QY0x6bmZ5RlBCRldrbzEvVmRuU0N6dzNtRldx?= =?utf-8?B?bkxzOVNyZW5GdUtDSnJoUWtZUEF2WHJ2RkEyN0dUOCtHMWxXdVYxUnJ5b0g2?= =?utf-8?B?ZS9vM3g1QnNYQjZVaERZaFNub09XK1JleUcrQVFxVVh1TGc4NlM5enhoM0dY?= =?utf-8?B?ZEluWnJKTjloajdxc1A5ODlGNml5b1F5c2xadUl4WUpYOUdaeDVMbHFLSDFm?= =?utf-8?B?dm8yQmMxc0ZVZVJzY0c1K1JLbVB4VW84dTYrN0VFZzBYTEIrNitUN1BnRVQx?= =?utf-8?B?WEM1c2Raa2xuNkJva2hWUE1GbStXcFAxRGowUG1IVmg5aCs2N3FrY1R6NkIr?= =?utf-8?B?dlpFT0pmR1pUUC91RVVmcEE0amlOR3IvWGNkc251NThOMzdPZ2ttblprZjhh?= =?utf-8?B?MXdoOFpOd3pjT1BZRW1OdVV2ZFY4N0F2Yi9TL2QrcjNOYTVmRGhhckplNWxL?= =?utf-8?B?OTRWaWljaTNORFpUdEQ5Zm82NGVHbE5qaFJKWFRKbG1MOUIwWGIwMG51REJh?= =?utf-8?B?aXNhWDRmUTVZc013WS9senowTEF6UmpDdllWK3BQZ04rdlY0aU5pc3ZtK2FZ?= =?utf-8?B?S0hadDZrT1daZDRtUU5IVVZ6S29UOHlBQkQ5ejZzWUhuUlk2STZHemhzdzIz?= =?utf-8?B?VUdWVitQOHkydHZHTTFEdHJHa1NudHNxK2laTytGd20wUEtRM3p0TXB0YjBK?= =?utf-8?B?cSszU201cUtYZTlmZC9IcXBOR28zL3BGTW11K1N0bUxxRTFndjJSM1hRMHNx?= =?utf-8?B?OXRkNVFXTUdVUmFGWFVpQ0JXZkpKU3NkbzFvd2NsZkM3Mlg1eW1Td1dPWWJ3?= =?utf-8?B?LzhJeE1VZzZkbU14SUNPcVA1U3ZHcVN5T3VCRG81WXY4OG1NTzQ5N2U0eEFL?= =?utf-8?B?S3Z5MStsYmwyYjMvTldGZ2xUZnNqRE52dDVsR1RnemduMFBWTWpLMloyZzBn?= =?utf-8?B?UzNiZGh1MGpaN2gxVDVnMjFBa1ExdWk3TWF4dHIxeUZVZnhMelpPckpic01r?= =?utf-8?B?Y2lvZVBqNE9ZQjZZd0U2a0pqYlRtVHRyWk53ZnVnRTR3OHBZcjNUdHdjcnd6?= =?utf-8?B?Q3c1U0E0SHJoNlI2K0hIczlqaExhRVRKVFRRbWthTmdUdXFTTlF3MnN2aUc3?= =?utf-8?B?dnI4NitEZWdNam83RjJkOWFhbmxUVjhwU2lNTDlicksvb3JhU09RQ0xjWFNU?= =?utf-8?B?YVFQczJ3ZzhxdzdRRzBsOExOYlhaY0EwOWcyT1ZHWjd1MjhPNnBtL1JsTE8x?= =?utf-8?B?RXFZSnBxU1FEYjhwTEcwdnpzYVNLR0hzclZMVEoxTnBZangxbU9EOVV5T0JF?= =?utf-8?B?UytEOWp4Y204ZWYvVXRoTHdnL2Vlblo2OXEyN3lxYk5EOEEyd21SUmoxUzlK?= =?utf-8?B?dXUwVGcxNGtUNTZYNEl0UjdlWkpwdVlsY21JaGRnQ3BGaGpPZ1pOSmFXais4?= =?utf-8?B?Rm1wdWxOakFBcUtJVHVMem1ReVQ4KzlJeFNLcys1U2lPVlhCdnJ1dWFFMklY?= =?utf-8?B?VzBMYzFkL1dwY0hMTTl0OW1KUnJEVElBL3BTUGlUdVkxeFI2NkZaNVhjR0Ey?= =?utf-8?B?VlN0OU9hYTREMGlxKytXUGRNUEFTYXkrT2xTQStrZU9jY2wzS0FRb1ptWlVV?= =?utf-8?B?M1VocmhXSGZibXVDb1hqV2diVUZBV1gzcThqYjc1dndPTkIzWEk1UWY5dVFP?= =?utf-8?B?ZmxrR2tZNVZyNHRQZWZGb3FaY2xDOFordEo4eXNBNlhtOUpCMlNTMkNyY3BC?= =?utf-8?B?MHhqWEJQcy9qMUdieU1OanFtZHdvQmR3aHlkaHZ3ZmhzcCtLamMxZUNYdjdn?= =?utf-8?Q?8/PpsohqKUyVEKUVvMvIS0c=3D?= X-Microsoft-Antispam-Message-Info: Lktpf6lk09xLvNi1ZSoB+xddWQbA8z+pOlOE5kV8sDecGqHvT4rkgJGjNrHi8xGrnk2LgRlJNC7NgN97BT80SPiKuz92BfkiFOMll+ByrKeB9yONzNtt+tFbPCCWfTxmWV+DWETywg6CVBcEFMdSOKSXxJanoduIP1N7bsulcg8XYfTxml/Fm3kn0DXXDGfE1tmQFTEliJT2m3Wm4KZvdU1/OFmQAXQnmj5rKubEyo8U3dBPcjTzE2vbkmdjxecBIeoGgjC7Fnv/KDIE4yWcRvzJvtk3C2Ewqi55f+PNqTw2lTU+fAAeQQMuwwJSixLY4GkKqkh8kvQoMKsNLAOtENbSf0ibvEEV6YEktjM14s4= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4911; 6:3fBomO75GzXZQTGvST60U6AyG1MMSUVYBbkp9VPsv53eDyaKFFrNolmH3dQrG3FssT9PWfjYH3gZR9XOPW5eOyecQE2yeVXviKhfOXGS7zHC3cReKKMx62QzAxO9kdntlnyr7aG+PtdMLNQHlY5L/Hr7DqJIf7S27m2OJHF6iWbvRffbcrK1/TtFdmLNOswvXpbrTdpp/T3s2kCDklBWLYTSNmmPC5pa+5M8Kuw8E61ex+fKQr7SuiWXIIqf5mh2+mz+5Ogin7rWQ6Dm1t/sDAcFqYTGX+c0bjwtwMi4b3iPtRTHff5WMZ16w5nSv50g4RSJd7Mfm/9vYft7C8qc4pZiq1pEmG8hTLbxIwxqwMkbQcSYCuw6UofaGDwuC8DQmBaXvuhfDlfn1MAC8fFv5Os2iuT2nB+eufUlqzdSKyhsmZMQh/cs+NIxmz8U0pXYZ8m/wQN6fk67XCU592U2fg==; 5:kScf0C81/Zqq03qVz6XbQdeeLgYAAYEd5cydIMFbTPLE+LZX55NuDQWCfvJfgBRU2IojdfSPM3ELpNEc+23nFiIWvJSdwhMWzxw3a87u45mV8QsTYemx0t1NwBUTaxW1aD6sA/gLdoOdO/Qs74x3qKCwgBeYZKPzZI4eS9FP9+I=; 7:DUSDKQaiN4foxjT4QKTnI7WkiXmg5BdqrjD+H2K1Orxw40UqB/MxImIdtK/CH2RORC8/mvAK6IrPViElvUbEmU0AZUeeYVNvjVcfbZpxUe1FibbJHdIaFeWCOTvvFo9lj1JQVn20pHQ5mLpM3fSmf2+mmj9C0IyZEq+1PWI5AeC/ktyI9nF7mMNasH4ibvhyXSau8C+0PoQNqC5tE/BNfkCmaxv4FK4AacdtCBKscn4+wTM0iXcCq3yuzD5r4AdG SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2018 12:28:22.4204 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0b42e5c-211b-47a3-5042-08d61c99118c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4911 Subject: Re: [dpdk-dev] [PATCH v2 05/33] common/cpt: add common code for init routine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 12:28:28 -0000 Hi Thomas, On 17-09-2018 17:16, Thomas Monjalon wrote: > External Email > > 17/09/2018 12:45, Akhil Goyal: >> On 9/4/2018 9:28 AM, Anoob Joseph wrote: >>> +struct pending_queue { >>> + uint16_t enq_tail; >>> + uint16_t deq_head; >>> + uint16_t soft_qlen; >>> + /**< Software expected queue length */ >>> + uint16_t p_doorbell; >>> + struct rid *rid_queue; >>> + /**< Array of pending requests */ >>> + uint64_t pending_count; >>> + /**< Pending requests count */ >>> +}; >> better to add comment for each element of structure. >> Also remove extra tab for comments(here and any other place if any.) > I don't understand this trend in the community about doing comments > _after_ the item _and_ not on the same line. > The default style should be commenting _before_. > And if you feel it is better to have the comment on the same line, > then you can comment _after_, but on the same line. Will fix it. Saw comments after the item being used frequently and thought that was the convention. Thanks Anoob