From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D90247D12; Mon, 31 Jul 2017 19:09:15 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2017 10:09:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,304,1498546800"; d="scan'208";a="113969787" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by orsmga004.jf.intel.com with ESMTP; 31 Jul 2017 10:09:13 -0700 To: Matan Azrad , Adrien Mazarguil Cc: dev@dpdk.org, stable@dpdk.org References: <1501511429-32079-1-git-send-email-matan@mellanox.com> From: Ferruh Yigit Message-ID: <0d3fe41c-f75e-aa15-fe2b-83059d29cbab@intel.com> Date: Mon, 31 Jul 2017 18:09:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1501511429-32079-1-git-send-email-matan@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx4: fix probe failure report X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 17:09:16 -0000 On 7/31/2017 3:30 PM, Matan Azrad wrote: > The corrupted code doesn't return error when probe function > fails due to error in device mac address getting. > By this way, the probe function may return success even if the > ETH dev is not allocated. > > Hence, the probe caller, for example failsafe PMD, fails when it > tries to get ETH dev after the device was plugged out while mlx4 > was probing it. > > The fix adds error report to the probe caller when priv_get_mac fails > and in all other failure options which are missing it. > > By this way, it prevents the unexpected behavior to miss ETH device > after the device was probed successfully. > > Fixes: 7fae69eeff13 ("mlx4: new poll mode driver") > Fixes: 001a520e419f ("net/mlx4: add port parameter") > Fixes: 7b0661539229 ("mlx4: check if port is configured for ethernet") > Fixes: fec3608673e6 ("mlx4: query netdevice to get initial MAC address") > Cc: stable@dpdk.org > > Signed-off-by: Matan Azrad > Acked-by: Adrien Mazarguil Applied to dpdk-next-net/master, thanks.