From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0085.outbound.protection.outlook.com [104.47.34.85]) by dpdk.org (Postfix) with ESMTP id 1C9C511D4 for ; Tue, 29 Aug 2017 15:20:05 +0200 (CEST) Received: from BN6PR03CA0020.namprd03.prod.outlook.com (10.168.230.158) by CY4PR03MB3320.namprd03.prod.outlook.com (10.171.247.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.9; Tue, 29 Aug 2017 13:20:04 +0000 Received: from BN1AFFO11FD044.protection.gbl (2a01:111:f400:7c10::124) by BN6PR03CA0020.outlook.office365.com (2603:10b6:404:23::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.9 via Frontend Transport; Tue, 29 Aug 2017 13:20:04 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD044.mail.protection.outlook.com (10.58.52.191) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1341.15 via Frontend Transport; Tue, 29 Aug 2017 13:20:03 +0000 Received: from [10.232.134.49] (B35197-11.ap.freescale.net [10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v7TDK0Bx030016; Tue, 29 Aug 2017 06:20:01 -0700 To: Radu Nicolau , CC: "hemant.agrawal@nxp.com" , Declan Doherty , Boris Pismenny References: <1503673046-30651-1-git-send-email-radu.nicolau@intel.com> <1503673046-30651-4-git-send-email-radu.nicolau@intel.com> <30b3fe2f-3668-ffa7-e3a4-a19cb28c5fdf@nxp.com> <5b7452db-e06b-bfa2-fdd6-5a0aaf1e21f7@intel.com> From: Akhil Goyal Message-ID: <0d41b5cf-ef02-37ce-d05f-8c3fdf20d1d3@nxp.com> Date: Tue, 29 Aug 2017 18:49:59 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <5b7452db-e06b-bfa2-fdd6-5a0aaf1e21f7@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131484864037458300; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(39860400002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(189002)(377454003)(24454002)(199003)(93886005)(54356999)(76176999)(2950100002)(77096006)(2906002)(2870700001)(229853002)(50986999)(36756003)(8936002)(83506001)(53546010)(8656003)(8676002)(65826007)(5660300001)(81156014)(50466002)(85426001)(81166006)(97736004)(4001350100001)(86362001)(498600001)(31696002)(23676002)(105606002)(65806001)(65956001)(47776003)(68736007)(106466001)(31686004)(53936002)(54906002)(305945005)(626005)(64126003)(33646002)(104016004)(189998001)(6246003)(356003)(4326008)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB3320; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD044; 1:LMnmbcJ/bqiuZa2HeNvtzqTqL1jtzWueACFFm2smKG40DS6PUS5sm8eq/7ApXntVlEW0wYHgcsTZv/n9p04LaloMxrsyQYSm97UK+RzUuEqRTatEblOypS2l20oa5Cdw X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 898c1371-59f2-4b0b-b01a-08d4eee0a8bf X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY4PR03MB3320; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB3320; 3:FMwe1/3PMlWWu+VjnT3/9z7g4JJyeHsF0p+m3Guo9vk18hUTqh/hNQiTxsY+wg3bImiKHV1STAFqQnlmd3psNx2sNhzf4SpqD8aSzDeAL/eiIBPZKw/amWOyYLnFnlvrQrgJ7AjjIVMGqWbFdkfenm0AlKQSCueOwHB24Kzg1oQS60pa4UFw0kvBvjtKxOXd1O60a95tXYEO9OTTLwXhn1mLvOdf1Cb5XZbrCAjNnj6Ro5m8tBlXzATdWpGoNy+aVuIJ1s6MsPKMJZNXWW2JLviElHSbN+iez5bgtUkgLBMWjFQkbHEi7dM2tYPpncgjqRWH8MHbe42God9/pnwK55OCwEBKiJ3HuiErS027bz8=; 25:ANcfFfGeUWB8lyzmwvQeYMVthY21ZSx+x1oAnXjMSiLILQa0ESuadqqJE7HYnco+PiKJ4fZiDh5FmrwrjB8xzIeeB8cbV5K+Q4hRMkaxCKFW4ioglE1kTotHfwxjqQm//RaW7dvuoeBaOscd+G8AW5GckU5TzujqnUeR5rgRTk/P9tGFIX7HP9HUPsxgXq+L05frUvLEpYsfoc4yDjsg9uZpeO+Hh8zfTALzCI1y0jjD47aGKDeRExmHuDfBWRAmXB55XHYKBCv77o4WiGPvakRr7yaBm4gYPnMiARBohrhp6gh2w/hD/+/mn/to6NlpiJySolXV7L5o7c7HR64ZXg== X-MS-TrafficTypeDiagnostic: CY4PR03MB3320: X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB3320; 31:v6kglZCyriaLAs03UjXDOzf8BjrNZncW3JShbE0Q/dJSELYrN3bSWW99f5XQG3iSBri7Pq/SU/DEBOy98bX+qwcFfZQ/is4kSTVX/7TIcQbjBFhisuHzi5IMbF8KLuaCltyX9a5h4RNJBYnQJF83oAdpVUzP+5OUq8r6HKMOSeZ3FII4KXZtZHHHfKWdHMmu4Rga2w0LLyCFRvcd9dWax8/fG327Haf38VXlErOX0gc=; 4:5Rv0M5ZYE+j5sWCZkw1Rz/BwM0dgT0jxw+u/MPEwrzabVPYlPYC2Wqibc9ZjNPZFmOkUB7ee0IwxwUtSQiEd0fSF7PFu7/LRftyot9R4vUVnNHg6KDH7s9OV0SjastFdzBEQBJFBuq+vhnHzMeM4xosQU5HdEr6HJij+tp9BpAeacBpTL0Vjh0F3xz5kfmrHAT+sEw6vDkgwHAEC4LCjTCB1qNSt1XtRU5Sc3/1R/LIKjzBjbnLTQ/+zE9xkzYcPntUr5Tce7C3Do9/mO2NFgyg+mmIo/2b+qx+HA80aX6c= X-Exchange-Antispam-Report-Test: UriScan:(192374486261705); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(13016025)(13018025)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6096035)(20161123559100)(20161123561025)(20161123565025)(20161123563025)(20161123556025)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR03MB3320; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR03MB3320; X-Forefront-PRVS: 0414DF926F X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjAzTUIzMzIwOzIzOlc5WkdpcE1LejB5MmhZRytlZXZibmljUUVQ?= =?utf-8?B?cVFzTEd6aXdiQUtZRklqSFAyS21wbmZIRVlDdlVCZTZ1MUJoRmFKRWd6V2Nu?= =?utf-8?B?Y255YkN4RjdUdHByeWliYlBFN1RqT3NDRHRBUzBTNi9sclVxbGt0ZzZTUVJn?= =?utf-8?B?MUtuNTkwbjArM2FiUTBqVklJamRKZE9FaU9mdDVwL1JEZzliK2hlQnQwUEtH?= =?utf-8?B?WnQ1T2hNRWJ2ZXJYYTg5U1hGenQvWWp3MVNVTTROL0d3RDlHMjE2NG4xdFVj?= =?utf-8?B?eTJib1lpcG9aMFVhTlVybFpmdW90bFlycWtSQWJDNCsrSDJHQWtBc1h5Y0p0?= =?utf-8?B?OW5mUzJDai90RU5iRVk4aHpkTkwvZmZacE9DR2FpWWYrWC9Xajk4SXNHMEVq?= =?utf-8?B?bnNtbFZVVGhiSEsxazd4Um5yVVgyMlhVNzQvYVByQUl2ZkhaZDZ0YVVQWWZD?= =?utf-8?B?OVpQT2szOGhiL3VmQ0tDam5uN013NmNJZUFFZGZlSXpTZmQ1S2FHaHN4V3FE?= =?utf-8?B?elBmS3FuTkw3YWxGSFdmQkIzVC9RdVVNMjg2MTF4MUI5cUtTNEs5WHdUUTZ3?= =?utf-8?B?MmVQTFdnUklEb29SWXVnTEY2VXUyUTFPUlZUd2xDWktlY1paS2FlOHE0aXd5?= =?utf-8?B?TkVMemJzVmg1NWUwTVdMZzREczdqYjNsa2VidUhOYUx1UDBETjZXeEtaWDlN?= =?utf-8?B?cTVkNWhCVkQzdjRKdCtRVVRSSG92Q053RW9FRFpHdlBzcmRWUUZjQW1EOURm?= =?utf-8?B?ZTUvaGduYklxdktsdzE3dmRtcWQ0K0hEQmRERmJxYkxjTmIveDZ3UUd3emJI?= =?utf-8?B?aG10VnA1aUJhdVg3UThMTFNvY2RMNDFESXdDMmU1ZHlScFJES2F3YmQ0dzcy?= =?utf-8?B?TXh3Y1R3S1VoL09HSHZwdEtYeWlFNmdBY05Dbml0RGI1azdjRE9zMlFCUWpT?= =?utf-8?B?eldlODVEWE9pSnRGQUpXbFpUMGpUWnRnRXJNT0hoZDFvTlFPNVNUZHNXdXVB?= =?utf-8?B?ejlyb1RIMXZld0dlMlQwSGkyWGE0OTF5SzVXdUtHdU5MdXVBTjh0TXdjdTBO?= =?utf-8?B?eUFEdU1JSUxaMkRuRm9qSlZjMkNJZ3ZXNklGa1Nwb1RnZXVEWTQ3R1BsUEY2?= =?utf-8?B?amVtME5HNVdBckdmZU9uL2YxYUlhdDR2eGd4bW01OEFhWXQ0SjRkUnNvZGJU?= =?utf-8?B?czhlM3h5MGRVaVpBYXNtT1pRd0FJWWh3eGdPUURmTDFlRkxSWHBISDRxTGZn?= =?utf-8?B?MHlzbkVsQnA2Wk9tejl0VFFVdVNkZTJrckZqYWYwZCtCT0FrNUFsYkNtQzBp?= =?utf-8?B?Ni80dTN1OWFQb3BleXlMZE8vOUs5QVBjUk5yQU5QRExGWEFyYW1FNnVMZVpD?= =?utf-8?B?L1pFM3ZBN044Q081ZThQc210VUFGSlhsM3kzcXo2ZVJGSC8xYzFWR3A4cTBh?= =?utf-8?B?dDh0RGdoUkZCYy9aS3lLNWJoQnJHL0pwSDVWajZ1TmMvWTlYYTdGa3NWdkhG?= =?utf-8?B?Y2NMcUtiT25HL0ZkUmdwTjRqNDBpSkR5RzZ2bFFCNEZzRG95MDVBZGR2emxV?= =?utf-8?B?Z2k0WDJDZThrN1J6bks1bnNYcmZ0M3NpTjhKU2txUGx1NUFPMGhlSnlmaC96?= =?utf-8?B?Ny8rNUxMU1BEWm9FM2NxWlRnU1RFVkp5cHJrNXNOTU00ZzRKTE1lZ3lXV3Vq?= =?utf-8?B?bTBFYVdtYUMrWElLM1F3a1dGZUdORGtPdFVGeGp3Mkl3cFJtdjFUaUd0NE5s?= =?utf-8?B?R3ZYejlzVWFaeDhzOTZ3OVZ5dXgvSTljM3JRS2hmbmMwZDlGeGo1MnNhYWcx?= =?utf-8?B?L1VXM0hTOGxLUjhqb2haTEdDNmltV3NXT1ZtMWJNZ05JNk9JOUVJMHNBTW5X?= =?utf-8?Q?BiEsAniuFifQmMfYn3oKJi87AiGUuB5a?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB3320; 6:EzBXEOZ/VDkjDIxfwrU9/zfPjUT5px45PhpokUFMr7C/IOFcuuQDtr7yUdUdzl6046sZlicgVGOLKlzScQ+Vylf/ZCLo7gS/jAL0i1dAR5P0wV7Iu8m7tLZ/XDL/2vF8FjSI3YgWxjZk6EO5wi75c8qvArUge4qQNqtaYukcbyiTx2f5dIRZ/AfsTG7Wm9SYrVh/XSSQQHgUAARlsxg2P/e7vxRdYCGwvbAwwKuPk0jdepHmcGSV+BfmE4Q4npMA/kdv2l00u5YLNpLO0jBsbiKfk5V3WhP1zK+pHP5/h+k2MbnIwfgcysgz75YkrFUYQeYTbVaD/Y9NN2zFF6kRIw==; 5:6XxdmCZt5OykyqPcOuZIRKQy20gI+/jmWNm6QzBxgiV1B0fpnhuwSPFHt38+H3QbqJ/ZtFb65GeBco22udkI4Eu2BJPvslW8o1Ot7hjlLdlHdyWii9Uofi+nst/jTtAYwQb0mfTQZM9m9YlbdwPXBg==; 24:OQ1gUTOkkatJyOg+hv7T6HOnUXNx4Rp1mu+wx5cymQmWN6Wu7QUVLPU/tvxLmpuYTvbfS/5quDb9Ei+kNEzZ2a5GmmTVIpmpSdk6TPA5glY=; 7:fzo1tK7bWPGtnJ9ZunNoB+0SIqaR6X8z1sC8z1TiCjGaOumR0Tocf977fJZb09EhWzz1BH1GHUd7z89h+/jesLuPolnoOmc+k/LjoQCotQaiPYY2mZdyNgCPAcZk3BUoMyZSWQ8t6JfD3wzX7R/1PBigXS5umF1j05mX71HQhTIOxl6DO7iN6HTAD6P9MTy1DbN1cmLt96/yvVW/L/MSbn+MIYVt0v1MSGmqRDSUa9w= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2017 13:20:03.5274 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3320 Subject: Re: [dpdk-dev] [RFC PATCH 3/5] rte_security: updates and enabled security operations for ethdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 13:20:06 -0000 Hi Radu, On 8/29/2017 6:43 PM, Radu Nicolau wrote: >>> @@ -70,9 +70,9 @@ struct rte_security_ipsec_tunnel_param { >>>           } ipv4; /**< IPv4 header parameters */ >>>             struct { >>> -            struct in6_addr *src_addr; >>> +            struct in6_addr src_addr; >>>               /**< IPv6 source address */ >>> -            struct in6_addr *dst_addr; >>> +            struct in6_addr dst_addr; >>>               /**< IPv6 destination address */ >>>               uint8_t dscp; >>>               /**< IPv6 Differentiated Services Code Point */ >>> @@ -171,6 +171,12 @@ struct rte_security_ipsec_xform { >>>           uint8_t *data;  /**< pointer to key data */ >>>           size_t length;   /**< key length in bytes */ >>>       } auth_key; >>> +    enum rte_crypto_aead_algorithm aead_alg; >>> +    /**< AEAD Algorithm */ >>> +    struct { >>> +        uint8_t *data;  /**< pointer to key data */ >>> +        size_t length;   /**< key length in bytes */ >>> +    } aead_key; >> I believe it would be better to use a union here. >> union { >>     struct { >>         enum rte_crypto_cipher_algorithm cipher_alg; >>             /**< Cipher Algorithm */ >>             struct { >>                     uint8_t *data;  /**< pointer to key data */ >>                     size_t length;   /**< key length in bytes */ >>             } cipher_key; >>             enum rte_crypto_auth_algorithm auth_alg; >>             /**< Authentication Algorithm */ >>             struct { >>                     uint8_t *data;  /**< pointer to key data */ >>                     size_t length;   /**< key length in bytes */ >>             } auth_key; >>     }; >>     struct { >>         enum rte_crypto_aead_algorithm aead_alg; >>         /**< AEAD Algorithm */ >>         struct { >>             uint8_t *data;  /**< pointer to key data */ >>             size_t length;   /**< key length in bytes */ >>         } aead_key; >>     }; >> }; > Probably the best way will be to have a chain of transforms, I will > follow up in the next patchset. Will it be chain of crypto xforms? If yes, then we may not be needing the fields like iv and digest length and op will need to assigned twice.