From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 580AB5955 for ; Thu, 18 Aug 2016 10:29:15 +0200 (CEST) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C492EC04B31A; Thu, 18 Aug 2016 08:29:14 +0000 (UTC) Received: from [10.36.4.244] (vpn1-4-244.ams2.redhat.com [10.36.4.244]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7I8TC2B024881 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 18 Aug 2016 04:29:13 -0400 To: Yuanhan Liu References: <1471364079-116217-1-git-send-email-jiayu.hu@intel.com> <1471364079-116217-2-git-send-email-jiayu.hu@intel.com> <2675f217-e6e7-c3a0-9d34-c87b068bef3c@redhat.com> <20160818083545.GW30752@yliu-dev.sh.intel.com> Cc: Jiayu Hu , dev@dpdk.org From: Maxime Coquelin Message-ID: <0d5b9c0d-ffed-e977-5d8e-d88d8d55d1d2@redhat.com> Date: Thu, 18 Aug 2016 10:29:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160818083545.GW30752@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 18 Aug 2016 08:29:14 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 1/2] examples/vhost: rename dev-basename X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2016 08:29:15 -0000 On 08/18/2016 10:35 AM, Yuanhan Liu wrote: > On Thu, Aug 18, 2016 at 10:22:38AM +0200, Maxime Coquelin wrote: >> Hi Jiayu, >> >> On 08/16/2016 06:14 PM, Jiayu Hu wrote: >>> In examples/vhost, "dev-basename" is a program option, which is to set >>> the vhost-net socket used by vhost-user, or the character device used >>> by vhost-cuse. Since vhost-cuse should be dropped, and "dev-basename" >>> is not a suitable name for the vhost-net socket. Therefore, this patch >>> is to change this option name for examples/vhost. >>> >>> Signed-off-by: Jiayu Hu >>> --- >>> examples/vhost/main.c | 41 +++++++++++++++++++++-------------------- >>> 1 file changed, 21 insertions(+), 20 deletions(-) >>> >>> diff --git a/examples/vhost/main.c b/examples/vhost/main.c >>> index 92a9823..a718577 100644 >>> --- a/examples/vhost/main.c >>> +++ b/examples/vhost/main.c >>> @@ -90,9 +90,6 @@ >>> /* Size of buffers used for snprintfs. */ >>> #define MAX_PRINT_BUFF 6072 >>> >>> -/* Maximum character device basename size. */ >>> -#define MAX_BASENAME_SZ 10 >>> - >>> /* Maximum long option length for option parsing. */ >>> #define MAX_LONG_OPT_SZ 64 >>> >>> @@ -139,8 +136,8 @@ static uint32_t burst_rx_delay_time = BURST_RX_WAIT_US; >>> /* Specify the number of retries on RX. */ >>> static uint32_t burst_rx_retry_num = BURST_RX_RETRIES; >>> >>> -/* Character device basename. Can be set by user. */ >>> -static char dev_basename[MAX_BASENAME_SZ] = "vhost-net"; >>> +/* Socket file path. Can be set by user */ >>> +static char socket_file[PATH_MAX] = "vhost-net"; >> >> Not very important, but now that we only support vhost-user, >> maybe we could default the name to "vhost-user"? >> >> There is no real convention I think, but this is what OVS is >> used to use in its examples. > > I think it doesn't matter now, since since the 2nd patch, --socket-path > is a must but not optional any more, meaning there is no default > socket file path. Yes, just noticed it while reviewing patch 2. So this is all good to me for this patch. Thanks, Maxime