From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8155A00C2; Mon, 26 Sep 2022 12:45:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FCE74069B; Mon, 26 Sep 2022 12:45:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7693C40695 for ; Mon, 26 Sep 2022 12:45:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664189101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T7/r2lLoAIUxaEUGVFdnyOgZbyEqoVjGUwbnWGyw+Ag=; b=TX0Z7rUgNYJvtPWGjJMmY55CiK8Fu9REmr9qhBsKiYsZFQlR9BscY+htJo62eP4iNKTpjo ebqCRmaL1vQPEyrwgZpronuqccvXYoPiFtJP9sykNsBQPkELXB12S0ZGmrvX0/8RZwVYRb yDCl1VdquD/hC7lv5MCaeRvbPCwWneY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-497-uNEa5ysBMgCi3UGmlUlo7A-1; Mon, 26 Sep 2022 06:45:00 -0400 X-MC-Unique: uNEa5ysBMgCi3UGmlUlo7A-1 Received: by mail-wm1-f71.google.com with SMTP id 62-20020a1c0241000000b003b4922046e5so3982124wmc.1 for ; Mon, 26 Sep 2022 03:44:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:content-language :references:cc:to:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=T7/r2lLoAIUxaEUGVFdnyOgZbyEqoVjGUwbnWGyw+Ag=; b=bNJt26qFHIvM7G08UwG0nzz7tVobXIzIzoO7rdYnirD1Mwl8ukPS3ozTs6Skh3o/Dy VAFEiIJT9LMscQO7ircnwjRJaKsQKfDkt9I5fhq7ikj6Gc9+duLMu0CQzDSh0B7sx2lE 7ymzvx0PjMCXa6EiKtnCzRdwx1wL9FkZglcLDrayUNqqEzsTvYK5UU25wm57VImIYPhO mpEL13bLXj8ZwgteYPm/lVQcAyI7FJ2HvHfD6jReUcR8kZ3o1kdhv7xVi3D5mHqnBZ/A cLN/WXNyLmRuVKVsEIsccft7psmFP2Z7v9YvjGG7JVhfW4mOiRzgDMKYt6wvVhR0ybaB XT+g== X-Gm-Message-State: ACrzQf3G8TMiAjnJ8VVedE8BRkOveIoT8bKwjKMHUA7VzitotutCioTD N57KAxezUUGAUHhGqthsxCUbKmbdpXj5HaR0M231kCV9Hg7Q9PCr2LreEY9CuwQMYDtgpUyq+uu bCEU= X-Received: by 2002:a05:6000:1acb:b0:22a:d11b:5eb9 with SMTP id i11-20020a0560001acb00b0022ad11b5eb9mr13287888wry.492.1664189098509; Mon, 26 Sep 2022 03:44:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM58nrYJHDaL6P+AyA3731XrZpnLDXxOUe+UlCpk9p/QtaxtJonTNCLuNdsXAvzosXV0x1dIiw== X-Received: by 2002:a05:6000:1acb:b0:22a:d11b:5eb9 with SMTP id i11-20020a0560001acb00b0022ad11b5eb9mr13287878wry.492.1664189098309; Mon, 26 Sep 2022 03:44:58 -0700 (PDT) Received: from [192.168.0.36] ([78.16.251.119]) by smtp.gmail.com with ESMTPSA id f12-20020adffccc000000b0022afddab5dfsm14453564wrs.7.2022.09.26.03.44.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 03:44:57 -0700 (PDT) Message-ID: <0d5dd85b-8fb5-3526-df9c-6e1ca23b1646@redhat.com> Date: Mon, 26 Sep 2022 11:44:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 To: David Marchand , =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= , Luca Boccassi , "Xueming(Steven) Li" , Christian Ehrhardt Cc: dev@dpdk.org, ferruh.yigit@xilinx.com, Stephen Hemminger References: <20220922081843.50b6d22e@hermes.local> <20220923070613.697210-1-omer.yamac@ceng.metu.edu.tr> From: Kevin Traynor Subject: Re: [PATCH v3] eal: update lcore-worker name due to high number of cores In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 26/09/2022 10:39, David Marchand wrote: > Hello, > > On Fri, Sep 23, 2022 at 9:06 AM Abdullah Ömer Yamaç > wrote: >> >> In this patch we suggest a new name for lcore-worker. >> In case of more than 99 logical cores, name is truncated >> (length is restricted to 16 characters, including the >> terminating null byte ('\0')) and it makes hard to follow threads. >> >> Signed-off-by: Abdullah Ömer Yamaç >> Acked-by: Stephen Hemminger > > - Thanks, good catch. > > Some comments though. > What matters is the lcore index, not the core/lcore count. > The commitlog could probably describe this better. > > For example, this issue can be triggered with --lcores=0,10@1,100@2 > and here we only have three lcores. > $ cat /proc/$(pidof dpdk-testpmd)/task/*/comm > dpdk-testpmd > eal-intr-thread > rte_mp_handle > lcore-worker-10 > lcore-worker-10 > telemetry-v2 > telemetry-v1 > > > And what do you think of following title: > "eal: fix thread names for high order lcores" > > Can you update the release notes? > > > - Question to stable maintainers: > Do you think we should backport this fix? > As you can see below, this change affects EAL thread names, maybe some > users are monitoring them based on the names... > No strong opinion, but backporting will change the name for any user who looks at this and only fix an issue for users using lcore names 100+. So would be inclined not to backport unless someone complains it is causing a real issue for their use case. > >> >> --- >> Cc: David Marchand >> --- >> lib/eal/freebsd/eal.c | 2 +- >> lib/eal/linux/eal.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c >> index ee5c929da8..a1bb5363b1 100644 >> --- a/lib/eal/freebsd/eal.c >> +++ b/lib/eal/freebsd/eal.c >> @@ -817,7 +817,7 @@ rte_eal_init(int argc, char **argv) >> >> /* Set thread_name for aid in debugging. */ >> snprintf(thread_name, sizeof(thread_name), >> - "lcore-worker-%d", i); >> + "rte-worker-%d", i); >> rte_thread_setname(lcore_config[i].thread_id, thread_name); >> >> ret = pthread_setaffinity_np(lcore_config[i].thread_id, >> diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c >> index 46bf52cef0..9a168b7773 100644 >> --- a/lib/eal/linux/eal.c >> +++ b/lib/eal/linux/eal.c >> @@ -1248,7 +1248,7 @@ rte_eal_init(int argc, char **argv) >> >> /* Set thread_name for aid in debugging. */ >> snprintf(thread_name, sizeof(thread_name), >> - "lcore-worker-%d", i); >> + "rte-worker-%d", i); >> ret = rte_thread_setname(lcore_config[i].thread_id, >> thread_name); >> if (ret != 0) >> -- >> 2.27.0 >> > > Merci ! >