From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E23CA0557; Thu, 9 Jun 2022 10:07:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F14E240689; Thu, 9 Jun 2022 10:07:07 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 803C840220; Thu, 9 Jun 2022 10:07:06 +0200 (CEST) Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LJc6v2rcmzRhm8; Thu, 9 Jun 2022 16:03:51 +0800 (CST) Received: from [10.67.103.235] (10.67.103.235) by kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 9 Jun 2022 16:07:04 +0800 Subject: Re: [PATCH v5] app/testpmd: add help messages for multi-process To: Ferruh Yigit , "Min Hu (Connor)" , References: <20220228032617.46618-1-humin29@huawei.com> <20220307010435.56784-1-humin29@huawei.com> <856292cb-de33-507e-1de0-4625d7253694@huawei.com> <92d5d8fa-2e40-1b47-d44c-9801e1069129@xilinx.com> CC: Huisong Li , , Xiaoyun Li , Aman Singh , Yuying Zhang , Lijun Ou , Ajit Khaparde From: Dongdong Liu Message-ID: <0d67365f-bc16-9fa5-3f0c-8a40f107cf10@huawei.com> Date: Thu, 9 Jun 2022 16:07:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <92d5d8fa-2e40-1b47-d44c-9801e1069129@xilinx.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.235] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemi500017.china.huawei.com (7.221.188.110) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ferruh Many thanks for your review. On 2022/6/3 7:08, Ferruh Yigit wrote: > On 6/2/2022 3:24 AM, Min Hu (Connor) wrote: >> Hi, all, >> any comments? >> >> 在 2022/3/7 9:04, Min Hu (Connor) 写道: >>> From: Huisong Li >>> >>> This patch adds help messages for multi-process. >>> --num-procs=N: set the total number of multi-process instances >>> --proc-id=id: set the id of the current process from multi-process >>> instances(0 <= id < num-procs) >>> >>> Fixes: a550baf24af9 ("app/testpmd: support multi-process") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Huisong Li >>> Signed-off-by: Min Hu (Connor) >>> --- >>> v6: >>> * fix comments. >>> v5: >>> * delete space >>> v4: >>> * update description for parameters. >>> v3,v2: >>> * adjust the position of parameters. >>> --- >>> app/test-pmd/parameters.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c >>> index daf6a31b2b..2834e9e180 100644 >>> --- a/app/test-pmd/parameters.c >>> +++ b/app/test-pmd/parameters.c >>> @@ -61,6 +61,9 @@ usage(char* progname) >>> "extended statistics to show. Used with --stats-period " >>> "specified or interactive commands that show Rx/Tx >>> statistics " >>> "(i.e. 'show port stats').\n"); >>> + printf(" --num-procs=N: set the total number of multi-process >>> instances\n"); >>> + printf(" --proc-id=id: set the id of the current process from >>> multi-process instances\n" >>> + "(0 <= id < num-procs).\n"); >>> printf(" --nb-cores=N: set the number of forwarding cores " >>> "(1 <= N <= %d).\n", nb_lcores); >>> printf(" --nb-ports=N: set the number of forwarding ports " >>> > > Hi Connor, > > output is as following [1], is "(0 <= id < num-procs)." part break into > next line intentionally? This breaks the output. > > I assume the line is broken in source code to fit into line length, but > it doesn't have to break the line in output, what do you think? Thanks for pointing this, will fix. Thanks, Dongdong > > > [1] > ... > --num-procs=N: set the total number of multi-process instances > --proc-id=id: set the id of the current process from multi-process .. > (0 <= id < num-procs). > --nb-cores=N: set the number of forwarding cores (1 <= N <= 55). > ... > . >