From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FF19A2EDB for ; Fri, 6 Sep 2019 14:21:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6751E1F305; Fri, 6 Sep 2019 14:21:58 +0200 (CEST) Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32]) by dpdk.org (Postfix) with ESMTP id EFB7F1F162 for ; Fri, 6 Sep 2019 14:21:56 +0200 (CEST) Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 9D203EFE5E93E065B698; Fri, 6 Sep 2019 20:21:55 +0800 (CST) Received: from [127.0.0.1] (10.57.115.182) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.439.0; Fri, 6 Sep 2019 20:21:45 +0800 To: Jerin Jacob Kollanukkaran , "dev@dpdk.org" References: CC: "xavier_huwei@163.com" , "linuxarm@huawei.com" , "forest.zhouchang@huawei.com" From: "Wei Hu (Xavier)" Message-ID: <0d6946bf-12ff-2337-b8df-b3c191b446cf@huawei.com> Date: Fri, 6 Sep 2019 20:21:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.115.182] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2019/9/2 12:24, Jerin Jacob Kollanukkaran wrote: >> -----Original Message----- >> From: Wei Hu (Xavier) >> Sent: Saturday, August 31, 2019 7:41 AM >> To: Jerin Jacob Kollanukkaran ; dev@dpdk.org >> Cc: xavier_huwei@163.com; linuxarm@huawei.com; >> forest.zhouchang@huawei.com >> Subject: [EXT] Re: [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files >> >>>>> +- Arch support: ARMv8. >>>> Is it an integrated NIC controller? Why it is supported only on ARMv8? >>>> The reason why I asking because, Enabling >>>> CONFIG_RTE_LIBRTE_HNS3_PMD=y only on arm64 will create a case >> where >>>> build fails for arm64 and passes for x86. I would like to avoid such >>>> disparity. If the build is passing on x86 make it enable in the common >> code, not in arm64 config. >>> Currently this network engine is integrated in the SoCs, the SoCs can >>> be used as a PCIe EP integrated NIC controllers or be used as >>> universal cpus on the device, such as servers. The network engine is >>> accessed by ARM cores in the SoCs. >>> We will enabling CONFIG_RTE_LIBRTE_HNS3_PMD=y in common_linux >> config in V2. >>> Thanks. >> Hi, Jerin > Hi Xaiver, > >> as a PCIe EP integrated NIC controllers -> as a PCIe EP Intelligent NIC >> controllers >> >> Since it is currently only accessed by ARM cores on SoCs, >> maybe it is also reasonable to compile only on ARMv8, right? > Since it is using PCIe infra to probe the devices and it will be always > Probed only on the intended system and if there is no armv8 specific > Instructions used then I prefer to build it for all archs to avoid the case > where build fails only with arm64 and not with other arch incase > If there is build issue with this PMD. Hi, Jerin We will ensure it can be built successfully with arm64 and x86-64 arch in patch V2. Thanks for your suggestion. Regards Xavier > >