From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Igor Romanov <Igor.Romanov@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH 0/2] ethdev: change xstats reset function return value to int
Date: Tue, 24 Sep 2019 12:56:55 +0100 [thread overview]
Message-ID: <0d6c7a6a-4d86-9f59-d1c8-44ec0348d312@intel.com> (raw)
In-Reply-To: <1567780495-14120-1-git-send-email-arybchenko@solarflare.com>
On 9/6/2019 3:34 PM, Andrew Rybchenko wrote:
> It is the third patch series to get rid of void returning functions
> in ethdev in accordance with deprecation notice [1].
>
> It should be applied on top of the first [2] and the second [3].
> It could be applied separately, but few simple conflicts should
> be resolved.
>
> Functions which return void are bad since they do not provide explicit
> information to the caller if everything is OK or not.
> It is especially painful in the case of promiscuous mode since it is
> not always supported, there are real cases when it fails to apply and
> it affects traffic which is received by the port.
>
> Driver maintainrs are encouraged to review the patch which changes
> driver callbacks prototype.
>
> [1] https://patches.dpdk.org/patch/56969/
> [2] https://patches.dpdk.org/project/dpdk/list/?series=6222
> [3] https://patches.dpdk.org/project/dpdk/list/?series=6264
>
> Igor Romanov (2):
> ethdev: change xstats reset function return value to int
> ethdev: make stats and xstats reset callbacks return int
For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Series applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2019-09-24 11:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 14:34 Andrew Rybchenko
2019-09-06 14:34 ` [dpdk-dev] [PATCH 1/2] " Andrew Rybchenko
2019-09-06 14:34 ` [dpdk-dev] [PATCH 2/2] ethdev: make stats and xstats reset callbacks return int Andrew Rybchenko
2019-09-24 11:56 ` Ferruh Yigit
2019-09-24 13:03 ` Andrew Rybchenko
2019-09-24 11:56 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d6c7a6a-4d86-9f59-d1c8-44ec0348d312@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Igor.Romanov@oktetlabs.ru \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).