From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4DB9A04DB; Fri, 16 Oct 2020 14:16:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D68C61ED80; Fri, 16 Oct 2020 14:16:46 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A02E71C22A for ; Fri, 16 Oct 2020 14:16:45 +0200 (CEST) IronPort-SDR: hkPUWgBeTWE2JilTl9kZIFVBxIcu01IEuP15RvcbC2WJ8ltS3lEqsKZdBnFGUINtxppdwksSwK 8hJW4FmEYU/A== X-IronPort-AV: E=McAfee;i="6000,8403,9775"; a="163123695" X-IronPort-AV: E=Sophos;i="5.77,382,1596524400"; d="scan'208";a="163123695" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 05:16:43 -0700 IronPort-SDR: Dt9+zys7GwxdMlFqD4pS7UAodzp0tkF1wvZM8XHPOFa9aAu1E483CrFWnFYFWBx6lJbWgr47iZ AIelKeMG3feg== X-IronPort-AV: E=Sophos;i="5.77,382,1596524400"; d="scan'208";a="531694644" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.19.66]) ([10.252.19.66]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 05:16:41 -0700 To: Thomas Monjalon , Andrew Rybchenko Cc: dev@dpdk.org, "Min Hu (Connor)" , "Wei Hu (Xavier" References: <20201012164602.1965694-1-ferruh.yigit@intel.com> <20201014022649.2165524-1-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: <0d8f6cf8-66e0-8754-f700-aa7dfbff9aba@intel.com> Date: Fri, 16 Oct 2020 13:16:38 +0100 MIME-Version: 1.0 In-Reply-To: <20201014022649.2165524-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/14/2020 3:26 AM, Ferruh Yigit wrote: > Queue stats are stored in 'struct rte_eth_stats' as array and array size > is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. > > As a result of technical board discussion, decided to remove the queue > statistics from 'struct rte_eth_stats' in the long term. > > Instead PMDs should represent the queue statistics via xstats, this > gives more flexibility on the number of the queues supported. > > Currently queue stats in the xstats are filled by ethdev layer, using > some basic stats, when queue stats removed from basic stats the > responsibility to fill the relevant xstats will be pushed to the PMDs. > > During the switch period, temporary 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' > device flag is created. Initially all PMDs using xstats set this flag. > The PMDs implemented queue stats in the xstats should clear the flag. > > When all PMDs switch to the xstats for the queue stats, queue stats > related fields from 'struct rte_eth_stats' will be removed, as well as > 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag. > Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be > removed. > > Signed-off-by: Ferruh Yigit Hi Thomas, Andrew, What do you think having the patch for this release? Connor, Xavier, Are you OK to superseded your existing patch [1] with this approach? [1] https://patches.dpdk.org/patch/78886/