From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id DEDC42986
 for <dev@dpdk.org>; Wed, 17 May 2017 13:12:35 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga104.jf.intel.com with ESMTP; 17 May 2017 04:12:34 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,354,1491289200"; d="scan'208";a="87878699"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81])
 ([10.237.220.81])
 by orsmga002.jf.intel.com with ESMTP; 17 May 2017 04:12:33 -0700
To: John Daley <johndale@cisco.com>
Cc: dev@dpdk.org
References: <20170331020622.25498-8-johndale@cisco.com>
 <20170517030348.2663-1-johndale@cisco.com>
 <20170517030348.2663-2-johndale@cisco.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <0d92cb13-a4bd-a851-4831-65da554f954d@intel.com>
Date: Wed, 17 May 2017 12:12:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170517030348.2663-2-johndale@cisco.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v3 1/6] net/enic: flow API skeleton
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 17 May 2017 11:12:36 -0000

On 5/17/2017 4:03 AM, John Daley wrote:
> Stub callbacks for the generic flow API and a new FLOW debug define.
> 
> Signed-off-by: John Daley <johndale@cisco.com>
> Reviewed-by: Nelson Escobar <neescoba@cisco.com>

<...>

> diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c
> index 8e16a71b7..4e8a0d9e0 100644
> --- a/drivers/net/enic/enic_ethdev.c
> +++ b/drivers/net/enic/enic_ethdev.c
> @@ -116,13 +116,28 @@ enicpmd_dev_filter_ctrl(struct rte_eth_dev *dev,
>  		     enum rte_filter_op filter_op,
>  		     void *arg)
>  {
> -	int ret = -EINVAL;
> +	int ret = 0;
> +
> +	ENICPMD_FUNC_TRACE();
>  
> -	if (RTE_ETH_FILTER_FDIR == filter_type)
> +	if (dev == NULL)
> +		return -EINVAL;

dev can't be NULL here if it is only called via filter_ctrl eth_dev_ops

<...>

> diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c
> new file mode 100644
> index 000000000..d25390f8a
> --- /dev/null
> +++ b/drivers/net/enic/enic_flow.c
> @@ -0,0 +1,154 @@
> +/*
> + * Copyright 2008-2017 Cisco Systems, Inc.  All rights reserved.
> + * Copyright 2007 Nuova Systems, Inc.  All rights reserved.
> + *
> + * Copyright (c) 2017, Cisco Systems, Inc.
> + * All rights reserved.

Is this file header correct, dates and "Nuova Systems" and double Cisco
copyright.

As a side note, there is also another LICENSE file under net/enic folder

<...>